From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 01/15] eal: introduce atomic exchange operation
Date: Thu, 8 Mar 2018 14:12:40 -0800 [thread overview]
Message-ID: <20180308141240.523cd1ff@xeon-e3> (raw)
In-Reply-To: <d8aa050e-7848-6926-4743-317a1e3bf556@intel.com>
On Thu, 11 Jan 2018 17:01:10 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 1/8/2018 5:45 PM, Stephen Hemminger wrote:
> > To handle atomic update of link status (64 bit), every driver
> > was doing its own version using cmpset.
> > Atomic exchange is a useful primitive in its own right;
> > therefore make it a EAL routine.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> <...>
>
> > @@ -98,6 +98,18 @@ rte_atomic64_cmpset(volatile uint64_t *dst, uint64_t exp, uint64_t src)
> > return res;
> > }
> >
> > +static inline uint64_t
> > +rte_atomic64_exchange(volatile uint64_t *dest, uint64_t val)
> > +{
> > + uint64_t old;
> > +
> > + do {
> > + old = *dest;
> > + } while (rte_atomic64_t_cmpset(dest, old, val));
>
> rte_atomic64_cmpset ? (without _t)
Wasn't that fixed in later version?
next prev parent reply other threads:[~2018-03-08 22:12 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 17:44 [dpdk-dev] [PATCH v3 00/15] common ethdev linkstatus functions Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-11 17:01 ` Ferruh Yigit
2018-01-25 23:24 ` Stephen Hemminger
2018-03-08 22:12 ` Stephen Hemminger [this message]
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-09 10:30 ` Andrew Rybchenko
2018-01-09 16:29 ` Stephen Hemminger
2018-01-11 17:01 ` Ferruh Yigit
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 03/15] net/virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-11 17:02 ` Ferruh Yigit
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 04/15] net/vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-11 17:02 ` Ferruh Yigit
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 05/15] net/dpaa2: " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 06/15] net/nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 07/15] net/e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 08/15] net/ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 09/15] net/sfc: use new " Stephen Hemminger
2018-01-09 10:35 ` Andrew Rybchenko
2018-01-09 16:27 ` Stephen Hemminger
2018-01-09 19:29 ` Andrew Rybchenko
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 10/15] net/i40e: use " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 11/15] net/liquidio: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 12/15] net/thunderx: " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 13/15] net/szedata: " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 14/15] net/octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 15/15] net/enic: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 01/15] eal: introduce atomic exchange operation Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 02/15] ethdev: add linkstatus get/set helper functions Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 03/15] net/virtio: use eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 04/15] net/vmxnet3: use rte_eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 05/15] net/dpaa2: " Ferruh Yigit
2018-01-16 9:44 ` Shreyansh Jain
2018-01-16 9:57 ` Shreyansh Jain
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 06/15] net/nfp: use rte_eth_linkstatus functions Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 07/15] net/e1000: use rte_eth_linkstatus helpers Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 08/15] net/ixgbe: use rte_eth_linkstatus functions Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 09/15] net/sfc: use new " Ferruh Yigit
2018-01-12 7:45 ` Andrew Rybchenko
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 10/15] net/i40e: use " Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 11/15] net/liquidio: use _rte_eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 12/15] net/thunderx: " Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 13/15] net/szedata: " Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 14/15] net/octeontx: use rte_eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 15/15] net/enic: use _rte_eth_linkstatus_set Ferruh Yigit
2018-01-12 14:05 ` Hyong Youb Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308141240.523cd1ff@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).