From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) by dpdk.org (Postfix) with ESMTP id 1E76C6CA2 for ; Fri, 9 Mar 2018 01:52:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1331; q=dns/txt; s=iport; t=1520556780; x=1521766380; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZDZoMITtJsy/TqhbrO2x77TXNKb+3JaflP0gOYR7nKo=; b=CzkfWi80+6MfXl81xCVeBOFl5yJel/Az/9/ImIQnbCWXNhVuzV/KVV8A /C6B/Bavl+bpeJzJp4P7BnJ1T7TFISm2mx9QK7CL39yvrNdGcxLcp9dco AaoOqJKrDhJB4UOk6r8VpOyo7wEXyDdmaTdXfxfKQrspxYaOv4H3sKcKk 8=; X-IronPort-AV: E=Sophos;i="5.47,443,1515456000"; d="scan'208";a="81347020" Received: from alln-core-7.cisco.com ([173.36.13.140]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2018 00:52:59 +0000 Received: from HYONKIM-FTCPE.cisco.com ([10.24.40.60]) by alln-core-7.cisco.com (8.14.5/8.14.5) with ESMTP id w290qsgK006005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 9 Mar 2018 00:52:57 GMT Date: Fri, 9 Mar 2018 09:52:54 +0900 From: Hyong Youb Kim To: Stephen Hemminger Cc: John Daley , ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180309005253.GA19460@HYONKIM-FTCPE.cisco.com> References: <20180306014634.28398-2-johndale@cisco.com> <20180308024702.25974-1-johndale@cisco.com> <20180308024702.25974-9-johndale@cisco.com> <20180308141427.08475f17@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180308141427.08475f17@xeon-e3> User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v3 08/10] doc: describe Rx bytes counter behavior for enic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 00:53:00 -0000 On Thu, Mar 08, 2018 at 02:14:27PM -0800, Stephen Hemminger wrote: > On Wed, 7 Mar 2018 18:47:00 -0800 > John Daley wrote: > > > 'catch-all' filters should be added last. > > > > +- **Statistics** > > + > > + - ``rx_good_bytes`` (ibytes) always includes VLAN header (4B) and CRC bytes (4B). > > + - When the NIC drops a packet because the Rx queue has no free buffers, > > + ``rx_good_bytes`` still increments by 4B if the packet is not VLAN tagged or > > + VLAN stripping is disabled, or by 8B if the packet is VLAN tagged and stripping > > + is enabled. > > All drivers must provide consistent statistics! > That means do NOT include CRC in the rx byte counts. > Yes, several drivers in DPDK are already broken for this. > > Otherwise there are cases like packets being forwarded from HW NIC to virtio and the counts > differ and customers think data is lots. Thanks for sharing this specific use case issue. We are aware that our current counters are non-standard. Newer 100G hardware models have fixed the problem (i.e. no CRC bytes, no incrementing of bytes when no buffers). We plan to update the doc again when we add these newer models to the supported hardware list. As for older models, we will see if we can fix up stats in software.. -Hyong