Re: [dpdk-dev] [PATCH] net/mrvl: convert license headers to SPDX tags

[Tomasz Duszynski <tdu@semihalf.com>]

On Fri, Mar 09, 2018 at 11:03:51PM +0530, Hemant Agrawal wrote:
> Hi,
> On 3/9/2018 3:35 PM, Ferruh Yigit wrote:
> >On 3/9/2018 9:39 AM, Tomasz Duszynski wrote:
> >>Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> >>---
> >>  drivers/net/mrvl/Makefile      | 35 ++++-------------------------------
> >>  drivers/net/mrvl/mrvl_ethdev.c | 36 ++++--------------------------------
> >>  drivers/net/mrvl/mrvl_ethdev.h | 36 ++++--------------------------------
> >>  drivers/net/mrvl/mrvl_qos.c    | 36 ++++--------------------------------
> >>  drivers/net/mrvl/mrvl_qos.h    | 36 ++++--------------------------------
> >>  5 files changed, 20 insertions(+), 159 deletions(-)
> >>
> >>diff --git a/drivers/net/mrvl/Makefile b/drivers/net/mrvl/Makefile
> >>index f75e53c..41ae6ec 100644
> >>--- a/drivers/net/mrvl/Makefile
> >>+++ b/drivers/net/mrvl/Makefile
> >>@@ -1,34 +1,7 @@
> >>-#   BSD LICENSE
> >>-#
> >>-#   Copyright(c) 2017 Marvell International Ltd.
> >>-#   Copyright(c) 2017 Semihalf.
> >>-#   All rights reserved.
> >
> ><...>
> >
> >>+# Copyright(c) 2018 Marvell International Ltd.
> >>+# Copyright(c) 2018 Semihalf.
> >>+# All rights reserved.
> >
> >Hi Tomasz,
> >
> >Related to the Copyright year update (2017 -> 2018), I am definitely not right
> >person for legal issues,
> >
> >but as far as I know that year indicates the year that copyright starts, I
> >assume you don't want to start your copyright from beginning 2018 but you want
> >to extend it, for that case year part should be "start - extended", like:
> ># Copyright(c) 2017-2018 Marvell International Ltd.
> >
> >cc'ed Hemant who know more than me about licensing.
>
> Well, as a DPDK contribution it is upto Marvell/Semihalf to change it.
>
> However, Ferruh made a good suggestion here.
>
> if nothing important is added, ideally the copyright year should not change.
> So, don't change the copyright  year or make it "Copyright(c) 2017-2018" .
> It is not good for Marvell/Semihalf to just relinquish the 2017 copyright
> for no good reason.
>
> Regards,
> Hemant

Fair enough. I'll send v2 with the year unchanged.

>
>
> >
> >Thanks,
> >ferruh
> >
>

--
- Tomasz Duszyński