From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65])
 by dpdk.org (Postfix) with ESMTP id 2FECEE5D
 for <dev@dpdk.org>; Mon, 12 Mar 2018 10:14:52 +0100 (CET)
Received: by mail-wm0-f65.google.com with SMTP id t6so14592114wmt.5
 for <dev@dpdk.org>; Mon, 12 Mar 2018 02:14:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:content-transfer-encoding:in-reply-to
 :user-agent; bh=ZnppfDmdy+UHR/EGLXCxuecRthKOxialvnovdjxoQ8I=;
 b=YEVs35kx7bY1ClbSsEnxTIJJ7jM3K9hqcESBfotRrwEjgLjcauauU4dcjcnXkp4CcQ
 vdN4O68TFtuEDC4bcp+CE27nfHwyuhozwPSCjNTb11SI5ciuDDX4IexAe1It7EOM7WQp
 bx2LqzeiOMzC6LQ3F/T0fcNAzya8U1xZn7UEzsupD3joNZt074SMX3lZskxQoTx1gckR
 wV8WgPHOplTFaj/i1X2OGZqUJs0dgFMTrRSPQjmnowSFu6cuHUYjPV5vd8NaaRotuYo7
 s+oWRIsXXZJA2FbCZJcrzzWjODjZWy7ok9ySuhcG8AcdnSPDQbyYV/ZKSTZvr5A1lsvX
 vRDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:content-transfer-encoding
 :in-reply-to:user-agent;
 bh=ZnppfDmdy+UHR/EGLXCxuecRthKOxialvnovdjxoQ8I=;
 b=uY05kWzDcVHQXmkjvOlPNYoEVCRvkzS4Ts3joT5zt9vDl0tWP8ytF3JcxBsCWyVxZC
 atem0SvtZ7JQw3pNMBIc+S/Q2Nx/Wgd1MIYzngDjZTmRpoEr/IIrn5+z3y2C8LH9qi8F
 eAk+MA51Dfuv0pp3cvm+r2G7hqV9Dj2ESlbrhLhPveRvrpu9cAC6JW4UT0ywHhh317SU
 20x6+mOPnEywY/4Tjczf1LrF13gPeVmWIUhVB+lclQmHNBGg0MXS9QDcoohGDpR/LWTD
 CqOdQzYamKrls1HtWuhecG9O6hSyyWwPSJ0iCIjxeUDwyRnvyH3ldIkzeNph/p9cruWB
 kdEw==
X-Gm-Message-State: AElRT7EqMLB7J57D9zkWqtChENgJoY28UpXeR7BBpzH9crM04cTfDxkN
 N4yniEal4mBN6lOLVcIyqLK5
X-Google-Smtp-Source: AG47ELudSAy5E8k1eS/G5BGUk3t8M+7GEQh8EYLD2GOs42q4VGhQb+gb421TFMWiOkYvoVP8Ut/wAg==
X-Received: by 10.28.227.66 with SMTP id a63mr4621873wmh.128.1520846091965;
 Mon, 12 Mar 2018 02:14:51 -0700 (PDT)
Received: from laranjeiro-vm.dev.6wind.com
 (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id y6sm3933669wmy.16.2018.03.12.02.14.51
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 12 Mar 2018 02:14:51 -0700 (PDT)
Date: Mon, 12 Mar 2018 10:13:39 +0100
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, adrien.mazarguil@6wind.com,
 olivier.matz@6wind.com, dev@dpdk.org
Message-ID: <20180312091339.w4pgp3gjmq4v2kkg@laranjeiro-vm.dev.6wind.com>
References: <20180310012532.15809-1-yskoh@mellanox.com>
 <20180310012532.15809-4-yskoh@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180310012532.15809-4-yskoh@mellanox.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v1 3/6] net/mlx5: add a function to rdma-core
	glue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Mar 2018 09:14:52 -0000

On Fri, Mar 09, 2018 at 05:25:29PM -0800, Yongseok Koh wrote:
> mlx5dv_create_wq() is added.
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_glue.c | 9 +++++++++
>  drivers/net/mlx5/mlx5_glue.h | 4 ++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c
> index 1c4396ada..e33fc76b5 100644
> --- a/drivers/net/mlx5/mlx5_glue.c
> +++ b/drivers/net/mlx5/mlx5_glue.c
> @@ -287,6 +287,14 @@ mlx5_glue_dv_create_cq(struct ibv_context *context,
>  	return mlx5dv_create_cq(context, cq_attr, mlx5_cq_attr);
>  }
>  
> +static struct ibv_wq *
> +mlx5_glue_dv_create_wq(struct ibv_context *context,
> +		       struct ibv_wq_init_attr *wq_attr,
> +		       struct mlx5dv_wq_init_attr *mlx5_wq_attr)
> +{
> +	return mlx5dv_create_wq(context, wq_attr, mlx5_wq_attr);
> +}
> +
>  static int
>  mlx5_glue_dv_query_device(struct ibv_context *ctx,
>  			  struct mlx5dv_context *attrs_out)
> @@ -347,6 +355,7 @@ const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue){
>  	.port_state_str = mlx5_glue_port_state_str,
>  	.cq_ex_to_cq = mlx5_glue_cq_ex_to_cq,
>  	.dv_create_cq = mlx5_glue_dv_create_cq,
> +	.dv_create_wq = mlx5_glue_dv_create_wq,
>  	.dv_query_device = mlx5_glue_dv_query_device,
>  	.dv_set_context_attr = mlx5_glue_dv_set_context_attr,
>  	.dv_init_obj = mlx5_glue_dv_init_obj,
> diff --git a/drivers/net/mlx5/mlx5_glue.h b/drivers/net/mlx5/mlx5_glue.h
> index b5efee3b6..21a713961 100644
> --- a/drivers/net/mlx5/mlx5_glue.h
> +++ b/drivers/net/mlx5/mlx5_glue.h
> @@ -100,6 +100,10 @@ struct mlx5_glue {
>  		(struct ibv_context *context,
>  		 struct ibv_cq_init_attr_ex *cq_attr,
>  		 struct mlx5dv_cq_init_attr *mlx5_cq_attr);
> +	struct ibv_wq *(*dv_create_wq)
> +		(struct ibv_context *context,
> +		 struct ibv_wq_init_attr *wq_attr,
> +		 struct mlx5dv_wq_init_attr *mlx5_wq_attr);
>  	int (*dv_query_device)(struct ibv_context *ctx_in,
>  			       struct mlx5dv_context *attrs_out);
>  	int (*dv_set_context_attr)(struct ibv_context *ibv_ctx,
> -- 
> 2.11.0
 
You missed to change the GLUE ABI version, it must be updated.

Regards,

-- 
Nélio Laranjeiro
6WIND