From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Harish Patil <harish.patil@cavium.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Shahed Shaikh <shahed.shaikh@cavium.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Shrikrishna Khare <skhare@vmware.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag
Date: Mon, 12 Mar 2018 12:39:00 +0000 [thread overview]
Message-ID: <20180312123900.22361-2-ferruh.yigit@intel.com> (raw)
In-Reply-To: <20180312123900.22361-1-ferruh.yigit@intel.com>
ICC warning #188 already disabled globally via commit [1], no
need individual arguments in PMDs.
[1]
Fixes: 1b80b9c854c3 ("mk: disable icc warning 188")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/bnx2x/Makefile | 4 ----
drivers/net/cxgbe/Makefile | 8 --------
drivers/net/e1000/Makefile | 2 +-
drivers/net/i40e/Makefile | 2 +-
drivers/net/qede/Makefile | 1 -
5 files changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index e3a39a9e0..0c0f51aaa 100644
--- a/drivers/net/bnx2x/Makefile
+++ b/drivers/net/bnx2x/Makefile
@@ -17,10 +17,6 @@ EXPORT_MAP := rte_pmd_bnx2x_version.map
LIBABIVER := 1
-ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS += -diag-disable 188 #188: enumerated type mixed with another type
-endif
-
#
# all source are stored in SRCS-y
#
diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile
index 5dee3c723..33267f6a6 100644
--- a/drivers/net/cxgbe/Makefile
+++ b/drivers/net/cxgbe/Makefile
@@ -45,12 +45,6 @@ EXPORT_MAP := rte_pmd_cxgbe_version.map
LIBABIVER := 1
-ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-#
-# CFLAGS for icc
-#
-CFLAGS_BASE_DRIVER = -diag-disable 188
-else
#
# CFLAGS for gcc/clang
#
@@ -59,9 +53,7 @@ ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1)
CFLAGS += -Wno-deprecated
endif
endif
-CFLAGS_BASE_DRIVER =
-endif
LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
LDLIBS += -lrte_bus_pci
diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile
index 01941ac69..87cfb265d 100644
--- a/drivers/net/e1000/Makefile
+++ b/drivers/net/e1000/Makefile
@@ -22,7 +22,7 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 -diag-disable 188
+CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181
CFLAGS_BASE_DRIVER += -diag-disable 869 -diag-disable 2259
else
#
diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index c91545741..7e34b50a7 100644
--- a/drivers/net/i40e/Makefile
+++ b/drivers/net/i40e/Makefile
@@ -24,7 +24,7 @@ LIBABIVER := 2
# to disable warnings
#
ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS_BASE_DRIVER = -diag-disable 593 -diag-disable 188
+CFLAGS_BASE_DRIVER = -diag-disable 593
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
CFLAGS_BASE_DRIVER += -Wno-sign-compare
CFLAGS_BASE_DRIVER += -Wno-unused-value
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index db5ba966e..831ee15df 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -73,7 +73,6 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion -Werror -E - < /dev/null > /dev
CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion
endif
else #ICC
-CFLAGS_BASE_DRIVER += -diag-disable 188 #188: enumerated type mixed with another type
CFLAGS_qede_ethdev.o += -diag-disable 279 #279: controlling expression is constant
endif
--
2.13.6
next prev parent reply other threads:[~2018-03-12 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 12:38 [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter Ferruh Yigit
2018-03-12 12:39 ` Ferruh Yigit [this message]
2018-04-11 10:12 ` [dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag De Lara Guarch, Pablo
2018-04-11 10:11 ` [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter De Lara Guarch, Pablo
2018-04-11 10:46 ` Ferruh Yigit
2018-04-13 22:21 ` [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning Ferruh Yigit
2018-04-13 22:21 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: remove redundant icc flag Ferruh Yigit
2018-04-13 22:30 ` [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312123900.22361-2-ferruh.yigit@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@cavium.com \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=shahed.shaikh@cavium.com \
--cc=skhare@vmware.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).