From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 99034AAD4 for ; Tue, 13 Mar 2018 16:00:04 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id o8so23628802wra.1 for ; Tue, 13 Mar 2018 08:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=n60zaDKHQL8Z5EtMty5+UuUH9ywTvwT0AQJSZ25mQEI=; b=tTwxQ55rNzhKsr2BbOibZJYJVrOTtvkpNCQfimQNaSyjGjBR3XNjzekn8KfBA7Asy7 QBRuADLCp+wbGO4EObcBr9ELtSFtqwDGXtSyNBStP+AL3AwgUX/brEsiQi+F8CkPW2Rc wXQOwr+uIL82Bxmx4ge17k8FeDOUSnod0WmlOyL9FY25NY9SRULrohQP+0kr/RUPr70M l8zvNYR2tOGABULU1xSLFmM4zvve83K3LTPeLBg8sHxLiCLtiKh24+D8YZ5hm6EcbKEZ Ypsv+CbaNWKyT6kMmmAQe5ej+Af5HtgJSfThJZZ3aAgObB3x2aU3PpjCDiwbwNxWhhUw xVdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=n60zaDKHQL8Z5EtMty5+UuUH9ywTvwT0AQJSZ25mQEI=; b=WctNALtYfc9L+lvmJxkNvGRyBEGu12Xytdz/ir9g6GkFD7qmvlb08jUJJlqu/LTUtL 5h3wrHtYnrOabn+pf+/W1ugeHsXC9rewbdwroWeATf/qhMOd8b7OMIwDTCWLi5twDSJu KJr8U6dc4914UGl8zve10VFLgccKs46W8hGPWw/dCAABN3VPXjY1eaxWRsMebh5ZsYCM In8lfpuztM8Z/oNZjmuExpUFTCJWaaIiW+TzJ+kE8uGPRnz58LrPLU6HqE5GgU6aUSdZ 8i+oGNVxBgRLKf88K7M2W2D4Zc3kTDb63U1X3nm9AIFic8NAWe4V4v8E+MjAYY6wGCDa 6IKg== X-Gm-Message-State: AElRT7EI6Sx0/mro4DAMjNR8NJBIWGHkscWpsEc84e84eMCxsmnoq7jM uTh3I6soII1mQXrnTwwkP24V X-Google-Smtp-Source: AG47ELtZ54VRaDifOB7ar+Rz68ITASlfNRrDTYaWlTcSWuiTRwHumKvrvlZ7uDFvEFF1KqlHcjqRQQ== X-Received: by 10.223.134.99 with SMTP id 32mr802650wrw.153.1520953204269; Tue, 13 Mar 2018 08:00:04 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 67sm542949wmw.17.2018.03.13.08.00.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Mar 2018 08:00:03 -0700 (PDT) Date: Tue, 13 Mar 2018 15:58:54 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Bruce Richardson Cc: Pascal Mazon , dev@dpdk.org Message-ID: <20180313145854.zrltyfs3xzm7usyx@laranjeiro-vm.dev.6wind.com> References: <881cd2e5dd39987f50789bde2de291740debbab2.1520943890.git.nelio.laranjeiro@6wind.com> <20180313135828.GA4612@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180313135828.GA4612@bricha3-MOBL3.ger.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] lib: move Netlink code into a common library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 15:00:04 -0000 On Tue, Mar 13, 2018 at 01:58:28PM +0000, Bruce Richardson wrote: > On Tue, Mar 13, 2018 at 01:28:26PM +0100, Nelio Laranjeiro wrote: > > Moves TAP PMD generic Netlink library into lib directory to let other PMD > > use Netlink to communicate with kernel. > > > > As this library uses a socket to communicate with Netlink it does not bring > > any dependency on the libnl. > > > > Cc: Pascal Mazon > > > > Signed-off-by: Nelio Laranjeiro > > --- > > MAINTAINERS | 3 + > > config/common_base | 6 ++ > > config/common_linuxapp | 1 + > > drivers/net/tap/Makefile | 3 +- > > drivers/net/tap/rte_eth_tap.c | 16 +-- > > drivers/net/tap/tap_flow.c | 118 ++++++++++----------- > > drivers/net/tap/tap_netlink.h | 42 -------- > > drivers/net/tap/tap_tcmsgs.c | 28 ++--- > > drivers/net/tap/tap_tcmsgs.h | 2 +- > > lib/Makefile | 2 + > > lib/librte_netlink/Makefile | 26 +++++ > > lib/librte_netlink/meson.build | 13 +++ > > .../librte_netlink/rte_netlink.c | 42 ++++---- > > lib/librte_netlink/rte_netlink.h | 42 ++++++++ > > lib/librte_netlink/rte_netlink_version.map | 17 +++ > > lib/meson.build | 2 +- > > mk/rte.app.mk | 1 + > > 17 files changed, 216 insertions(+), 148 deletions(-) > > delete mode 100644 drivers/net/tap/tap_netlink.h > > create mode 100644 lib/librte_netlink/Makefile > > create mode 100644 lib/librte_netlink/meson.build > > rename drivers/net/tap/tap_netlink.c => lib/librte_netlink/rte_netlink.c (88%) > > create mode 100644 lib/librte_netlink/rte_netlink.h > > create mode 100644 lib/librte_netlink/rte_netlink_version.map > > > > > > > diff --git a/lib/librte_netlink/meson.build b/lib/librte_netlink/meson.build > > new file mode 100644 > > index 000000000..77592c7d4 > > --- /dev/null > > +++ b/lib/librte_netlink/meson.build > > @@ -0,0 +1,13 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright 2018 6WIND S.A. > > +# Copyright 2018 Mellanox Technologies, Ltd. > > + > > + > > +name = 'netlink' > > +version = 1 > > Not a big issue, but the above two lines are unnecessary, and can be > omitted. I'd rather than the name of the lib *not* be explicitly called > out, to prevent the temptation of giving the library a different name to > the name of the directory it is in. > > > +allow_experimental_apis = true > > +sources = files('rte_netlink.c',) > > + > > +headers = files('rte_netlink.h') > > + > > +deps += ['net'] > > > > > diff --git a/lib/meson.build b/lib/meson.build > > index ef6159170..873a39785 100644 > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -23,7 +23,7 @@ libraries = [ 'compat', # just a header, used for versioning > > # add pkt framework libs which use other libs from above > > 'port', 'table', 'pipeline', > > # flow_classify lib depends on pkt framework table lib > > - 'flow_classify'] > > + 'flow_classify', 'netlink'] > > Given that this doesn't depend on anything apart from the core libs, > I think it should be placed earlier in the list, where the majority of > the libs are in alphabetical order. [Yes, I should have put a comment > just before the "acl" lib entry calling out the fact that it was meant > to be an alphabetical list - I forgot, sorry! :-)] > > /Bruce Hi Bruce, I will modify it for the v2. Thanks, -- Nélio Laranjeiro 6WIND