From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 2B2105B1C for ; Wed, 14 Mar 2018 09:16:02 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id s18so3729616wrg.9 for ; Wed, 14 Mar 2018 01:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jgvmYtXZAAtGt1K0D3yXEqfgAL4GsDEQUXByC8VUW3o=; b=JEYhtORvDPvG3+G66bW2O2n+FHPR3P5tMKkI29yyIQLPRp7Jwq0hnW1yeMcsi8pz9B PwvccFwTs/2p1ExSACjnNXYp3sGa7DSsxtDx4hMDka9mYSHeH7HqhDt4C0mqcmpzXhsy iujq7mpH6dorLV2RhI3IEJkla/RKn/pbpemNguaov07iZmAf2EK6PHJrcRbFKS67Ey0a yeh7SkhuDtqjuhnFIco8LQH5a3y2Rb6g70bQgKU3xLRrgMrMMD5Qgb1W5x2Z3plaijcS DTWwKlPsWlF2SDFalMZ7e0VQlKt+vG8U/OWFf3kJFdYS5aDpO+cAAua++fp6FE4PxQ5m VX3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jgvmYtXZAAtGt1K0D3yXEqfgAL4GsDEQUXByC8VUW3o=; b=QQ86I6qPokBdUKbGMqcDRnrc/sA2wQUCO/306AX398u0aFNGoCAHb6yXzZKW4peV0u NA5MWmpL9tmJHSN0dW4e5UcBbHE4bxnNruJaHQiZQnY99PIGlz++JQNjn0UOD8Yn3mMP 1hQg9bqQJE2dIFsssvPFwRHKIMblSkqfGhKuJyP9DSPw7iO3c5JXdcQLinJ8Gfk3Wi1n Oib19mB9hP8L/CPikDBglGq8CF6VKvsxJKElHvc1IF2jvRm/pGYG9Dmgrt+oZyC7lZnD YHUaa+mzvF7d5Qz4XAV+P64Li2BuPtNg31OA1Em0WprkHPit62tbucXD61HcWe6fL+Jt EP7A== X-Gm-Message-State: AElRT7FqrfG+eFIYUI8hdduqIOgfAakAIvlLX8s88rj9Hdup8i4jN0RW S/jn5OiUzbV0r25PWLF35iBA X-Google-Smtp-Source: AG47ELt0FNzsobL4TxD7Q9LIGumFXtoYC3h69MUgcFsbACwZqCopuJromEC4w+nMx1ynMpmln79Mnw== X-Received: by 10.223.173.197 with SMTP id w63mr3155235wrc.83.1521015361689; Wed, 14 Mar 2018 01:16:01 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u89sm890571wma.10.2018.03.14.01.16.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Mar 2018 01:16:00 -0700 (PDT) Date: Wed, 14 Mar 2018 09:14:53 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: Qi Zhang , Xiao Wang , John McNamara , Marko Kovacevic , Beilei Xing , Wenzhuo Lu , Rasesh Mody , Harish Patil , Shahed Shaikh , Tetsuya Mukawa , Yuanhan Liu , Maxime Coquelin , Tiwei Bie , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Konstantin Ananyev , Adrien Mazarguil , Yongseok Koh , dev@dpdk.org Message-ID: <20180314081453.5qkfkdk2cxml5pnp@laranjeiro-vm.dev.6wind.com> References: <20180313180534.232296-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180313180534.232296-1-ferruh.yigit@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] drivers/net: update link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 08:16:02 -0000 On Tue, Mar 13, 2018 at 06:05:34PM +0000, Ferruh Yigit wrote: > Update link status related feature document items and minor updates in > some link status related functions. > > Signed-off-by: Ferruh Yigit > --- > doc/guides/nics/features/fm10k.ini | 2 ++ > doc/guides/nics/features/fm10k_vf.ini | 2 ++ > doc/guides/nics/features/i40e_vf.ini | 1 + > doc/guides/nics/features/igb_vf.ini | 1 + > doc/guides/nics/features/qede.ini | 1 - > doc/guides/nics/features/qede_vf.ini | 1 - > doc/guides/nics/features/vhost.ini | 2 -- > doc/guides/nics/features/virtio_vec.ini | 1 + > drivers/net/e1000/em_ethdev.c | 2 +- > drivers/net/ena/ena_ethdev.c | 2 +- > drivers/net/fm10k/fm10k_ethdev.c | 6 ++---- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > drivers/net/mlx4/mlx4_ethdev.c | 2 +- > drivers/net/mlx5/mlx5_ethdev.c | 2 +- > 15 files changed, 15 insertions(+), 14 deletions(-) > > diff --git a/doc/guides/nics/features/fm10k.ini b/doc/guides/nics/features/fm10k.ini > index f0f61a7d7..58f58b99c 100644 > --- a/doc/guides/nics/features/fm10k.ini > +++ b/doc/guides/nics/features/fm10k.ini > @@ -5,6 +5,8 @@ > ; > [Features] > Speed capabilities = P > +Link status = Y > +Link status event = Y > Rx interrupt = Y > Queue start/stop = Y > Jumbo frame = Y > diff --git a/doc/guides/nics/features/fm10k_vf.ini b/doc/guides/nics/features/fm10k_vf.ini > index 32b93df4b..44b50faa1 100644 > --- a/doc/guides/nics/features/fm10k_vf.ini > +++ b/doc/guides/nics/features/fm10k_vf.ini > @@ -5,6 +5,8 @@ > ; > [Features] > Speed capabilities = P > +Link status = Y > +Link status event = Y > Rx interrupt = Y > Queue start/stop = Y > Jumbo frame = Y > diff --git a/doc/guides/nics/features/i40e_vf.ini b/doc/guides/nics/features/i40e_vf.ini > index 46e0d9fce..ba2d8cbe9 100644 > --- a/doc/guides/nics/features/i40e_vf.ini > +++ b/doc/guides/nics/features/i40e_vf.ini > @@ -5,6 +5,7 @@ > ; > [Features] > Rx interrupt = Y > +Link status = Y > Queue start/stop = Y > Jumbo frame = Y > Scattered Rx = Y > diff --git a/doc/guides/nics/features/igb_vf.ini b/doc/guides/nics/features/igb_vf.ini > index e641a2c97..d9653234b 100644 > --- a/doc/guides/nics/features/igb_vf.ini > +++ b/doc/guides/nics/features/igb_vf.ini > @@ -4,6 +4,7 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Features] > +Link status = Y > Rx interrupt = Y > Scattered Rx = Y > TSO = Y > diff --git a/doc/guides/nics/features/qede.ini b/doc/guides/nics/features/qede.ini > index cbadc1949..13e34ae33 100644 > --- a/doc/guides/nics/features/qede.ini > +++ b/doc/guides/nics/features/qede.ini > @@ -6,7 +6,6 @@ > [Features] > Speed capabilities = Y > Link status = Y > -Link status event = Y > MTU update = Y > Jumbo frame = Y > Scattered Rx = Y > diff --git a/doc/guides/nics/features/qede_vf.ini b/doc/guides/nics/features/qede_vf.ini > index 18857b6e3..70071a1bd 100644 > --- a/doc/guides/nics/features/qede_vf.ini > +++ b/doc/guides/nics/features/qede_vf.ini > @@ -6,7 +6,6 @@ > [Features] > Speed capabilities = Y > Link status = Y > -Link status event = Y > MTU update = Y > Jumbo frame = Y > Scattered Rx = Y > diff --git a/doc/guides/nics/features/vhost.ini b/doc/guides/nics/features/vhost.ini > index dffd1f493..31302745a 100644 > --- a/doc/guides/nics/features/vhost.ini > +++ b/doc/guides/nics/features/vhost.ini > @@ -4,8 +4,6 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Features] > -Link status = Y > -Link status event = Y > Free Tx mbuf on demand = Y > Queue status event = Y > Basic stats = Y > diff --git a/doc/guides/nics/features/virtio_vec.ini b/doc/guides/nics/features/virtio_vec.ini > index c06c860d4..e60fe36ae 100644 > --- a/doc/guides/nics/features/virtio_vec.ini > +++ b/doc/guides/nics/features/virtio_vec.ini > @@ -6,6 +6,7 @@ > [Features] > Speed capabilities = P > Link status = Y > +Link status event = Y > Rx interrupt = Y > Queue start/stop = Y > Promiscuous mode = Y > diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c > index 242375ff1..080df70c4 100644 > --- a/drivers/net/e1000/em_ethdev.c > +++ b/drivers/net/e1000/em_ethdev.c > @@ -1210,7 +1210,7 @@ eth_em_link_update(struct rte_eth_dev *dev, int wait_to_complete) > link.link_autoneg = !(dev->data->dev_conf.link_speeds & > ETH_LINK_SPEED_FIXED); > } else if (!link_check && (link.link_status == ETH_LINK_UP)) { > - link.link_speed = 0; > + link.link_speed = ETH_SPEED_NUM_NONE; > link.link_duplex = ETH_LINK_HALF_DUPLEX; > link.link_status = ETH_LINK_DOWN; > link.link_autoneg = ETH_LINK_FIXED; > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 34b2a8d78..ad4e03dba 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -724,7 +724,7 @@ static int ena_link_update(struct rte_eth_dev *dev, > { > struct rte_eth_link *link = &dev->data->dev_link; > > - link->link_status = 1; > + link->link_status = ETH_LINK_UP; > link->link_speed = ETH_SPEED_NUM_10G; > link->link_duplex = ETH_LINK_FULL_DUPLEX; > > diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c > index 94237610c..cc1a773a7 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -1233,13 +1233,11 @@ fm10k_link_update(struct rte_eth_dev *dev, > FM10K_DEV_PRIVATE_TO_INFO(dev->data->dev_private); > PMD_INIT_FUNC_TRACE(); > > - /* The speed is ~50Gbps per Gen3 x8 PCIe interface. For now, we > - * leave the speed undefined since there is no 50Gbps Ethernet. > - */ > - dev->data->dev_link.link_speed = 0; > + dev->data->dev_link.link_speed = ETH_SPEED_NUM_50G; > dev->data->dev_link.link_duplex = ETH_LINK_FULL_DUPLEX; > dev->data->dev_link.link_status = > dev_info->sm_down ? ETH_LINK_DOWN : ETH_LINK_UP; > + dev->data->dev_link.link_autoneg = ETH_LINK_FIXED; > > return 0; > } > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index fd003fe01..c771edde5 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -2107,7 +2107,7 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, > new_link.link_status = vf->link_up ? ETH_LINK_UP : > ETH_LINK_DOWN; > new_link.link_autoneg = > - dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED; > + !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); > > i40evf_dev_atomic_write_link_status(dev, &new_link); > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index 448325857..bad83968c 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3957,7 +3957,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, > bool autoneg = false; > > link.link_status = ETH_LINK_DOWN; > - link.link_speed = 0; > + link.link_speed = ETH_SPEED_NUM_NONE; > link.link_duplex = ETH_LINK_HALF_DUPLEX; > link.link_autoneg = ETH_LINK_AUTONEG; > memset(&old, 0, sizeof(old)); > diff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4/mlx4_ethdev.c > index fbeef16c8..beecc53ba 100644 > --- a/drivers/net/mlx4/mlx4_ethdev.c > +++ b/drivers/net/mlx4/mlx4_ethdev.c > @@ -710,7 +710,7 @@ mlx4_link_update(struct rte_eth_dev *dev, int wait_to_complete) > } > link_speed = ethtool_cmd_speed(&edata); > if (link_speed == -1) > - dev_link.link_speed = 0; > + dev_link.link_speed = ETH_SPEED_NUM_NONE; > else > dev_link.link_speed = link_speed; > dev_link.link_duplex = ((edata.duplex == DUPLEX_HALF) ? > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index b73cb53df..de5576099 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -536,7 +536,7 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev, int wait_to_complete) > } > link_speed = ethtool_cmd_speed(&edata); > if (link_speed == -1) > - dev_link.link_speed = 0; > + dev_link.link_speed = ETH_SPEED_NUM_NONE; > else > dev_link.link_speed = link_speed; > priv->link_speed_capa = 0; > -- > 2.13.6 Hi Ferruh, On mlx5 this hunk is conflicts with my series [1]. Regards, [1] https://dpdk.org/ml/archives/dev/2018-March/092495.html -- Nélio Laranjeiro 6WIND