From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f67.google.com (mail-pl0-f67.google.com [209.85.160.67]) by dpdk.org (Postfix) with ESMTP id 029FE4C9D for ; Wed, 14 Mar 2018 16:17:41 +0100 (CET) Received: by mail-pl0-f67.google.com with SMTP id w15-v6so1867952plq.9 for ; Wed, 14 Mar 2018 08:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NHTGES1GMYym+QPYqvS33z7oadFHIvRHLZP5nt9kNh0=; b=rZx/Ze5bmDn4eO2+MWqwMidnEJ1E7Ki5m00+0PZGyEbeJ6cFurs63s3cnkhp1Pmj1U ovxPql/qZ8NdNcijMZqiehdQyx98ITyLPRG5HDacMFJzHgxHrAXyrlMv5CtPaFxqEhMW 2Fth3MzWLNxYtrej6Ud6geR5ZbxR9P2uVuL6uWWkdLjoFD/9VvXL0DdocxgZ94ljZba2 BdxGpptwvRe2d6Au4rMyStf8m5fO6sNXEbVc7vOdulWjbutqha1n99BKqqcp76Xatpfb WpEwvzriWOUzd9mMR4gDReoT0G6h8wLCB751fdhGnNAUisOdNsyObLugZEG7Xj/+fwcX eViQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NHTGES1GMYym+QPYqvS33z7oadFHIvRHLZP5nt9kNh0=; b=ed/TShQKWikLb3NfG5oZh/RpnZHPUCB/IBoXqaFU0YpIPoeA1kky2iUmSlW/IrOzVw o2Ue82RXk4CHGPcJZTA75luuYbIc/9yWqlj97Nl35kvoOd0L7ipprqhL3BaSs7fbRKM+ 6h/zKWNhVLG5a63yP7dGg2vqdpEnMVAHCS5TtukPmChNLnY0Oo/nAohOtrW9X0qXUg9y v35Bs/ok6BEjmUHHB4Q5KcBGUE2MvLJsSj05AQ4ovpBiguHhE9HLmTGd92ugDL8i4h3H wAlIx2J3RZ2V/x9/4oXlGR6x2bW03JoC4qszyjJUJIciMUElaOLK7Ucx9XKT6gizKt9w 4TaA== X-Gm-Message-State: AElRT7E8DlFsIQZY4HQN0zb/cU+ma+Jav5+8OewmSNWs2YeJaT5MiK+y qZ4wN3aKqnugXG7euZRiZqHnOTlUPXA= X-Google-Smtp-Source: AG47ELvJpAU6TlCyNT62vbAmfFHjQzxB1DsTSnF1MtPewkZvMQzifcbECwDFfSPJU9ADpRBdws/PRg== X-Received: by 2002:a17:902:20c2:: with SMTP id v2-v6mr4570977plg.82.1521040659699; Wed, 14 Mar 2018 08:17:39 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id e16sm6342474pfb.157.2018.03.14.08.17.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Mar 2018 08:17:39 -0700 (PDT) Date: Wed, 14 Mar 2018 08:17:36 -0700 From: Stephen Hemminger To: =?UTF-8?B?TsOpbGlv?= Laranjeiro Cc: Pascal Mazon , dev@dpdk.org Message-ID: <20180314081736.6b06dd2f@xeon-e3> In-Reply-To: <20180314120855.avapkwbwx6hecwmw@laranjeiro-vm.dev.6wind.com> References: <20180313142031.3fd01cbc@xeon-e3> <20180314120855.avapkwbwx6hecwmw@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 15:17:42 -0000 On Wed, 14 Mar 2018 13:08:55 +0100 N=C3=A9lio Laranjeiro wrote: > On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: > > On Tue, 13 Mar 2018 13:28:25 +0100 > > Nelio Laranjeiro wrote: > > =20 > > > TAP PMD uses a wrapper to communicate with Netlink through a socket. = This > > > wrapper can be useful for other PMD which may need to communicate als= o with > > > the Linux kernel via Netlink. > > >=20 > > > This series moves this wrapper to the lib level to let any PMD implem= ent use > > > it when necessary. > > >=20 > > > Nelio Laranjeiro (2): > > > lib: move Netlink code into a common library > > > lib: add request Netlink messages > > >=20 > > > MAINTAINERS | 3 + > > > config/common_base | 6 ++ > > > config/common_linuxapp | 1 + > > > drivers/net/tap/Makefile | 3 +- > > > drivers/net/tap/rte_eth_tap.c | 16 +-- > > > drivers/net/tap/tap_flow.c | 118 ++++++++++-= ---------- > > > drivers/net/tap/tap_netlink.h | 42 -------- > > > drivers/net/tap/tap_tcmsgs.c | 28 ++--- > > > drivers/net/tap/tap_tcmsgs.h | 2 +- > > > lib/Makefile | 2 + > > > lib/librte_netlink/Makefile | 26 +++++ > > > lib/librte_netlink/meson.build | 13 +++ > > > .../librte_netlink/rte_netlink.c | 87 +++++++++++= ---- > > > lib/librte_netlink/rte_netlink.h | 43 ++++++++ > > > lib/librte_netlink/rte_netlink_version.map | 18 ++++ > > > lib/meson.build | 2 +- > > > mk/rte.app.mk | 1 + > > > 17 files changed, 263 insertions(+), 148 deletions(-) > > > delete mode 100644 drivers/net/tap/tap_netlink.h > > > create mode 100644 lib/librte_netlink/Makefile > > > create mode 100644 lib/librte_netlink/meson.build > > > rename drivers/net/tap/tap_netlink.c =3D> lib/librte_netlink/rte_net= link.c (77%) > > > create mode 100644 lib/librte_netlink/rte_netlink.h > > > create mode 100644 lib/librte_netlink/rte_netlink_version.map > > > =20 > >=20 > > I might have raised this before; but having yet another netlink library= is > > not a great advantage. It would be much better to use a common external= library > > libmnl which is already available on every distribution. =20 >=20 > The question is more do we really want to have a dependency on a so > small wrapper for a socket interface? >=20 Lots of drivers already have dependencies. And I trust libmnl rather than a reinvented library.