From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id CDBE25F59 for ; Wed, 14 Mar 2018 13:10:03 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id a20so18195947wmd.1 for ; Wed, 14 Mar 2018 05:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PjB6i+P4uQsYd04JMiJtXFr+Po6huR8Y5q0tTNpyeqw=; b=tDqFZKBhAsv4iW2Dkvj1AQocBQq7008eBGBv7hhKeRxf1WYW8p5upeim3FkS0cfDD4 dqySCewjFwwn4JUAyz8ozdXzWhy1j2FUw7sTWCqV/Qx05DIRVojCl2+SfiCXKvEDBtku e7tUajgYINYmKbQL79/RfEKXFIb4Y3ZPT7OAfzYCOKuKAm6W+N/qyBMBxENaOXr9Nzbb y8EDRoQlaXwNSbh5Syv+McrOoQSf/qJT2CHnKJ9idPZjgsGbWA6YzOdCCErcG8iU9YoY T0xv3D4BhvzHwSUzL0OFVgPjJUXjA3XOM/WiUZ9+0+I1MwPXCKVJdrFZbi+t+k+NS87U bj3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PjB6i+P4uQsYd04JMiJtXFr+Po6huR8Y5q0tTNpyeqw=; b=Pjql0f4yu6YvGyNCa40IP8z7kgju5QW0OHstKjyPqGfl2COhP/HNV25e4+KCVoIG/h Z4+6qBn4Ch7MeQJ2TG/asnLBj7nZr9eq9uBVQHC1VolLaM+ceCgmh7pxYtpHT/oBCoB6 dc2h+0oGKC+mF4nI1qzJIy59eA3QtTx9ttNv5uNl9E6EfIrRAhIHo0peoYRHXlpnx2kt 8mu1Mohs2g50PO3w0i5CPFKQMy4boAL9iOnPsdpfsohxvv/OhQq7mAZwrjAbGYiKl5JR QfK0ohJau7NRpCBvlELYFPeKDTvO8Z2BntKXV3BGvpWpMuwHbSR9ICzxIocBtgPN0YdU hEVQ== X-Gm-Message-State: AElRT7FhHLAROMXbilgBHOGoNREsNl1o5LTJVo3dfu0gxGXlgrdyCvoH pdMGWeXFWQf1e52BurhqBP9A X-Google-Smtp-Source: AG47ELuBbMEr0kV2Eed4qmWglKJyuUN9UMJf6LTdFefCuj++kZyOpA3QkJ8PNPTDZNBLsISg+mBajA== X-Received: by 10.28.158.205 with SMTP id h196mr1371531wme.25.1521029403395; Wed, 14 Mar 2018 05:10:03 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f127sm832171wmg.46.2018.03.14.05.10.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Mar 2018 05:10:02 -0700 (PDT) Date: Wed, 14 Mar 2018 13:08:55 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Stephen Hemminger Cc: Pascal Mazon , dev@dpdk.org Message-ID: <20180314120855.avapkwbwx6hecwmw@laranjeiro-vm.dev.6wind.com> References: <20180313142031.3fd01cbc@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180313142031.3fd01cbc@xeon-e3> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 12:10:04 -0000 On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: > On Tue, 13 Mar 2018 13:28:25 +0100 > Nelio Laranjeiro wrote: > > > TAP PMD uses a wrapper to communicate with Netlink through a socket. This > > wrapper can be useful for other PMD which may need to communicate also with > > the Linux kernel via Netlink. > > > > This series moves this wrapper to the lib level to let any PMD implement use > > it when necessary. > > > > Nelio Laranjeiro (2): > > lib: move Netlink code into a common library > > lib: add request Netlink messages > > > > MAINTAINERS | 3 + > > config/common_base | 6 ++ > > config/common_linuxapp | 1 + > > drivers/net/tap/Makefile | 3 +- > > drivers/net/tap/rte_eth_tap.c | 16 +-- > > drivers/net/tap/tap_flow.c | 118 ++++++++++----------- > > drivers/net/tap/tap_netlink.h | 42 -------- > > drivers/net/tap/tap_tcmsgs.c | 28 ++--- > > drivers/net/tap/tap_tcmsgs.h | 2 +- > > lib/Makefile | 2 + > > lib/librte_netlink/Makefile | 26 +++++ > > lib/librte_netlink/meson.build | 13 +++ > > .../librte_netlink/rte_netlink.c | 87 +++++++++++---- > > lib/librte_netlink/rte_netlink.h | 43 ++++++++ > > lib/librte_netlink/rte_netlink_version.map | 18 ++++ > > lib/meson.build | 2 +- > > mk/rte.app.mk | 1 + > > 17 files changed, 263 insertions(+), 148 deletions(-) > > delete mode 100644 drivers/net/tap/tap_netlink.h > > create mode 100644 lib/librte_netlink/Makefile > > create mode 100644 lib/librte_netlink/meson.build > > rename drivers/net/tap/tap_netlink.c => lib/librte_netlink/rte_netlink.c (77%) > > create mode 100644 lib/librte_netlink/rte_netlink.h > > create mode 100644 lib/librte_netlink/rte_netlink_version.map > > > > I might have raised this before; but having yet another netlink library is > not a great advantage. It would be much better to use a common external library > libmnl which is already available on every distribution. The question is more do we really want to have a dependency on a so small wrapper for a socket interface? -- Nélio Laranjeiro 6WIND