From: Stephen Hemminger <stephen@networkplumber.org>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org, Pascal Mazon <pascal.mazon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib
Date: Thu, 15 Mar 2018 09:26:56 -0700 [thread overview]
Message-ID: <20180315092656.11ebb017@xeon-e3> (raw)
In-Reply-To: <20180315161905.ypzfsmymdlvsiumc@laranjeiro-vm.dev.6wind.com>
On Thu, 15 Mar 2018 17:19:05 +0100
Nélio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
> On Thu, Mar 15, 2018 at 04:39:46PM +0100, Thomas Monjalon wrote:
> > 14/03/2018 16:17, Stephen Hemminger:
> > > On Wed, 14 Mar 2018 13:08:55 +0100
> > > Nélio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
> > > > On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote:
> > > > > On Tue, 13 Mar 2018 13:28:25 +0100
> > > > > Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
> > > > > > drivers/net/tap/Makefile | 3 +-
> > > > > > drivers/net/tap/rte_eth_tap.c | 16 +--
> > > > > > drivers/net/tap/tap_flow.c | 118 ++++++++++-----------
> > > > > > drivers/net/tap/tap_netlink.h | 42 --------
> > > > > > drivers/net/tap/tap_tcmsgs.c | 28 ++---
> > > > > > drivers/net/tap/tap_tcmsgs.h | 2 +-
> > > > > > lib/Makefile | 2 +
> > > > > > lib/librte_netlink/Makefile | 26 +++++
> > > > > > lib/librte_netlink/meson.build | 13 +++
> > > > > > .../librte_netlink/rte_netlink.c | 87 +++++++++++----
> > > > > > lib/librte_netlink/rte_netlink.h | 43 ++++++++
> > > > > > lib/librte_netlink/rte_netlink_version.map | 18 ++++
> > > > >
> > > > > I might have raised this before; but having yet another netlink library is
> > > > > not a great advantage. It would be much better to use a common external library
> > > > > libmnl which is already available on every distribution.
> > > >
> > > > The question is more do we really want to have a dependency on a so
> > > > small wrapper for a socket interface?
> > >
> > > Lots of drivers already have dependencies.
> > > And I trust libmnl rather than a reinvented library.
> >
> > Are we sure it is commonly installed in distributions?
> >
iproute2 now mostly requires libmnl. It is used for several networking types
and extended error reporting.
prev parent reply other threads:[~2018-03-15 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 12:28 Nelio Laranjeiro
2018-03-13 12:28 ` [dpdk-dev] [PATCH 1/2] lib: move Netlink code into a common library Nelio Laranjeiro
2018-03-13 13:58 ` Bruce Richardson
2018-03-13 14:58 ` Nélio Laranjeiro
2018-03-13 12:28 ` [dpdk-dev] [PATCH 2/2] lib: add request Netlink messages Nelio Laranjeiro
2018-03-13 21:20 ` [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib Stephen Hemminger
2018-03-14 12:08 ` Nélio Laranjeiro
2018-03-14 15:17 ` Stephen Hemminger
2018-03-15 15:39 ` Thomas Monjalon
2018-03-15 16:19 ` Nélio Laranjeiro
2018-03-15 16:26 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315092656.11ebb017@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=pascal.mazon@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).