From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 4C5995F29 for ; Thu, 15 Mar 2018 17:27:04 +0100 (CET) Received: by mail-pf0-f196.google.com with SMTP id a16so3010439pfn.9 for ; Thu, 15 Mar 2018 09:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h7/uVQt0SuPfI9lgS0W14jVRYlCh+gsl3Vz8tZ+Yhmw=; b=eXJflTe0lGJIwFZVGCDuM3GxlpNLHoBIkGCGX4xSwwgn6qbBtyvvI9TMEmYoa4ca/X J1VqAbeBqa+e3hzMGg7etMuwCOrpi+8jK/4FDqO1pg5Qs5yHAJ2Vo58NOQ4HDUfjvbxJ SkDdlPsLONbFYg1EXLddY6+XnyMWqzkSoyp1sxIiqll9chwG1Vt4SV+XafaQgE0My+E/ fOs0lTtZVtts4Wk+2NF/5MLiws6aFaWAnyhoMzbNwsERP87Dv6/Dnv/M9tgX0bEPHAVh Zdb1FtrJGKWfAbyrYs2bRJokNz4qL1XAKkzNs9Jh0LuZcW+1XkjSjBn2Afa9eHMXjt6g Hcyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h7/uVQt0SuPfI9lgS0W14jVRYlCh+gsl3Vz8tZ+Yhmw=; b=lZ51sPt4MhcqaSS3HXzxEmVOTHcM9w+Seu8OC/vazBvU4jP2vPC53EckCOWMxFmXbO 36DXAByAv0wFgcE+DltgLgTYKDgH4Uc+yCWYA5kAEVFqu4Ul1zvuNu9Btjtdaavt+h7r Y1skCbE8xQYIyGhOKd5+XfV491ZioXTwBpzORcyXBRCsR1sN+yhZNqDGcBJb9few5WvP 7whIMZU2h5S2WC5iDqMgtNdgzmITuW3L0Oq4IB6L6/uLHX/+Ht4UR6jJqpn3R4BOfqOW lzDl005I9IsZHWUlMLkOHBlcb3kVgQkmHDbZW91plto1xRVd4c4z1ol+SXEXBWByvxRI Psdw== X-Gm-Message-State: AElRT7GCmZnasyNS8jdzypvv6KlplxFrfnzi3IE0RFpRYdV0ADbM/Lri WlTH/lBJOSFBuvZXE+ZQ+uUpBYcc/AY= X-Google-Smtp-Source: AG47ELsuBT2jieOixxJHf5s+6bIhmgGpEbArrspBfVYNiHOe1kc9AtfNXvgu3gaDTg8ms2Q8sm428Q== X-Received: by 10.99.167.66 with SMTP id w2mr7223154pgo.357.1521131223366; Thu, 15 Mar 2018 09:27:03 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id h69sm11257024pfe.97.2018.03.15.09.27.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 09:27:03 -0700 (PDT) Date: Thu, 15 Mar 2018 09:26:56 -0700 From: Stephen Hemminger To: =?UTF-8?B?TsOpbGlv?= Laranjeiro Cc: Thomas Monjalon , dev@dpdk.org, Pascal Mazon Message-ID: <20180315092656.11ebb017@xeon-e3> In-Reply-To: <20180315161905.ypzfsmymdlvsiumc@laranjeiro-vm.dev.6wind.com> References: <20180314120855.avapkwbwx6hecwmw@laranjeiro-vm.dev.6wind.com> <20180314081736.6b06dd2f@xeon-e3> <2460477.86ImKqUlBA@xps> <20180315161905.ypzfsmymdlvsiumc@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 16:27:04 -0000 On Thu, 15 Mar 2018 17:19:05 +0100 N=C3=A9lio Laranjeiro wrote: > On Thu, Mar 15, 2018 at 04:39:46PM +0100, Thomas Monjalon wrote: > > 14/03/2018 16:17, Stephen Hemminger: =20 > > > On Wed, 14 Mar 2018 13:08:55 +0100 > > > N=C3=A9lio Laranjeiro wrote: =20 > > > > On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: = =20 > > > > > On Tue, 13 Mar 2018 13:28:25 +0100 > > > > > Nelio Laranjeiro wrote: =20 > > > > > > drivers/net/tap/Makefile | 3 +- > > > > > > drivers/net/tap/rte_eth_tap.c | 16 +-- > > > > > > drivers/net/tap/tap_flow.c | 118 +++++= +++++----------- > > > > > > drivers/net/tap/tap_netlink.h | 42 -----= --- > > > > > > drivers/net/tap/tap_tcmsgs.c | 28 ++--- > > > > > > drivers/net/tap/tap_tcmsgs.h | 2 +- > > > > > > lib/Makefile | 2 + > > > > > > lib/librte_netlink/Makefile | 26 +++++ > > > > > > lib/librte_netlink/meson.build | 13 +++ > > > > > > .../librte_netlink/rte_netlink.c | 87 +++++= ++++++---- > > > > > > lib/librte_netlink/rte_netlink.h | 43 +++++= +++ > > > > > > lib/librte_netlink/rte_netlink_version.map | 18 ++++ = =20 > > > > >=20 > > > > > I might have raised this before; but having yet another netlink l= ibrary is > > > > > not a great advantage. It would be much better to use a common ex= ternal library > > > > > libmnl which is already available on every distribution. =20 > > > >=20 > > > > The question is more do we really want to have a dependency on a so > > > > small wrapper for a socket interface? =20 > > >=20 > > > Lots of drivers already have dependencies. > > > And I trust libmnl rather than a reinvented library. =20 > >=20 > > Are we sure it is commonly installed in distributions? > >=20 iproute2 now mostly requires libmnl. It is used for several networking types and extended error reporting.