From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <nelio.laranjeiro@6wind.com> Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 0919C5F4D for <dev@dpdk.org>; Thu, 15 Mar 2018 17:20:10 +0100 (CET) Received: by mail-wr0-f195.google.com with SMTP id m12so8833716wrm.13 for <dev@dpdk.org>; Thu, 15 Mar 2018 09:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=cB6su2pbk9LC85cgtqEIN8uGFD2TMa7Ml3kK7OKfu34=; b=mP0tvZAKPgvkYrSDNO5CAHrKctEDgMSZ8lCrNrCW+pfth05AEhLezmoCCaNPkIuaOr h+FvTiMdZ/TwvGQy0Rp/enGZ/THnU7PxqojG3vMNFKV03FW+/NJhU6efy2kHA+PxEeio wBydEURoO7xnf5U5nKptXFSbUFZIWaoCfJUkWvzncXaLTCbga8fdrvFMohSG78I85TlP O98Ib49nL7MKUCwD7T/bfUpSKKya8izbWgC7oHTjmhncmkgl1xm9Quc/zd96j4/ThSpO 3cBUGZXscG5rdbM3qMJBmhWGDv+gFU7YtHvLi5I0tZnzMd6a+vD8kk4NQ2kR6oyNMxAy QC6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=cB6su2pbk9LC85cgtqEIN8uGFD2TMa7Ml3kK7OKfu34=; b=kFz5cnd6QGRJMS7NLd0rTxjCQsWa/xiIG04ZwYQAmG+/3V2VleodXcB+QK9LHY9CGR ZcNwksglA2/8lu6LpBIVhe+HBQj361mBvpgth4KgTC6KCD9LzF7dXlGGMy4zwZkwa3G3 0mLBMb15qUD5kzwnmBmJAE7U0zkgJvgfIURdeL3q8TPsceLaR1DbvQ+RSFEAirEbWCJG e4lLVqIV/CE6MU5kfLHhVbujG0kXBMhp+Nc+PrWBdI/uv4W/8GRXaMzDu0UQa+MWlUPS 8ZxeP5Ys+GvzbJvx8ptHKKipLMEb/Y++t8iCUB4qFjoltwI/Eq6JmpwdKk1tZAeAum0b xCBg== X-Gm-Message-State: AElRT7HzcvfyDMWGQs7LqM4rxK9Q1tIgTLvn5wM0Ou6LK3IS/Gm8RAgX lvWut68I12tqEVgX4qgHJX7rhFsawQ== X-Google-Smtp-Source: AG47ELtupZMxFO5maI5GToYYyJPDGl0jkk/W6MpbRu/F7qunbPUawoiLeS0X1fcBPlFgW1V6hxSMYg== X-Received: by 10.223.135.26 with SMTP id a26mr8173857wra.211.1521130810659; Thu, 15 Mar 2018 09:20:10 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l41sm5384217wrl.2.2018.03.15.09.20.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 09:20:10 -0700 (PDT) Date: Thu, 15 Mar 2018 17:19:05 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org, Pascal Mazon <pascal.mazon@6wind.com> Message-ID: <20180315161905.ypzfsmymdlvsiumc@laranjeiro-vm.dev.6wind.com> References: <cover.1520943890.git.nelio.laranjeiro@6wind.com> <20180314120855.avapkwbwx6hecwmw@laranjeiro-vm.dev.6wind.com> <20180314081736.6b06dd2f@xeon-e3> <2460477.86ImKqUlBA@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2460477.86ImKqUlBA@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 15 Mar 2018 16:20:11 -0000 On Thu, Mar 15, 2018 at 04:39:46PM +0100, Thomas Monjalon wrote: > 14/03/2018 16:17, Stephen Hemminger: > > On Wed, 14 Mar 2018 13:08:55 +0100 > > Nélio Laranjeiro <nelio.laranjeiro@6wind.com> wrote: > > > On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: > > > > On Tue, 13 Mar 2018 13:28:25 +0100 > > > > Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote: > > > > > drivers/net/tap/Makefile | 3 +- > > > > > drivers/net/tap/rte_eth_tap.c | 16 +-- > > > > > drivers/net/tap/tap_flow.c | 118 ++++++++++----------- > > > > > drivers/net/tap/tap_netlink.h | 42 -------- > > > > > drivers/net/tap/tap_tcmsgs.c | 28 ++--- > > > > > drivers/net/tap/tap_tcmsgs.h | 2 +- > > > > > lib/Makefile | 2 + > > > > > lib/librte_netlink/Makefile | 26 +++++ > > > > > lib/librte_netlink/meson.build | 13 +++ > > > > > .../librte_netlink/rte_netlink.c | 87 +++++++++++---- > > > > > lib/librte_netlink/rte_netlink.h | 43 ++++++++ > > > > > lib/librte_netlink/rte_netlink_version.map | 18 ++++ > > > > > > > > I might have raised this before; but having yet another netlink library is > > > > not a great advantage. It would be much better to use a common external library > > > > libmnl which is already available on every distribution. > > > > > > The question is more do we really want to have a dependency on a so > > > small wrapper for a socket interface? > > > > Lots of drivers already have dependencies. > > And I trust libmnl rather than a reinvented library. > > Are we sure it is commonly installed in distributions? > > This is needed only for TAP and mlx drivers. > Do we really want to add this dependency as mandatory for everybody > to compile DPDK with default PMDs? > > I see 4 options: > 1/ keep duplicated few functions in PMDs > 2/ use libmnl > 3/ add the functions in a DPDK lib (this patch) > 4/ add the functions in EAL > > I would vote for the first option because mlx5 has very minimal > requirement regarding netlink. > The first option can give us some time to think about the right way > to use netlink in the next releases. I also vote for option 1 until those 4 and maybe more options are discussed. -- Nélio Laranjeiro 6WIND