* [dpdk-dev] [PATCH 1/2] net/virtio: fix link autoneg value
@ 2018-03-16 10:51 Ferruh Yigit
2018-03-16 10:51 ` [dpdk-dev] [PATCH 2/2] net/vmxnet3: " Ferruh Yigit
2018-03-16 11:06 ` [dpdk-dev] [PATCH 1/2] net/virtio: " Ferruh Yigit
0 siblings, 2 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-03-16 10:51 UTC (permalink / raw)
To: Yuanhan Liu, Maxime Coquelin, Tiwei Bie; +Cc: dev, Ferruh Yigit, stephen
link_autoneg shold use ETH_LINK_FIXED, not ETH_LINK_SPEED_FIXED
Fixes: 138f367aec66 ("net/virtio: use linkstatus helper functions")
Cc: stephen@networkplumber.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/virtio/virtio_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 92a85e2c2..4dddb1c80 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -2001,7 +2001,7 @@ virtio_dev_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complet
memset(&link, 0, sizeof(link));
link.link_duplex = ETH_LINK_FULL_DUPLEX;
link.link_speed = ETH_SPEED_NUM_10G;
- link.link_autoneg = ETH_LINK_SPEED_FIXED;
+ link.link_autoneg = ETH_LINK_FIXED;
if (hw->started == 0) {
link.link_status = ETH_LINK_DOWN;
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread* [dpdk-dev] [PATCH 2/2] net/vmxnet3: fix link autoneg value
2018-03-16 10:51 [dpdk-dev] [PATCH 1/2] net/virtio: fix link autoneg value Ferruh Yigit
@ 2018-03-16 10:51 ` Ferruh Yigit
2018-03-16 11:06 ` [dpdk-dev] [PATCH 1/2] net/virtio: " Ferruh Yigit
1 sibling, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-03-16 10:51 UTC (permalink / raw)
To: Yuanhan Liu, Maxime Coquelin, Tiwei Bie, Shrikrishna Khare
Cc: dev, Ferruh Yigit, stephen, chas3
link_autoneg shold use ETH_LINK_FIXED, not ETH_LINK_SPEED_FIXED
Fixes: cd3c44c48caa ("net/vmxnet3: keep consistent link status")
Cc: chas3@att.com
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 2f65fe479..426008722 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -320,7 +320,7 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
memset(&link, 0, sizeof(link));
link.link_duplex = ETH_LINK_FULL_DUPLEX;
link.link_speed = ETH_SPEED_NUM_10G;
- link.link_autoneg = ETH_LINK_SPEED_FIXED;
+ link.link_autoneg = ETH_LINK_FIXED;
rte_eth_linkstatus_set(eth_dev, &link);
return 0;
@@ -813,7 +813,7 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)
memset(&link, 0, sizeof(link));
link.link_duplex = ETH_LINK_FULL_DUPLEX;
link.link_speed = ETH_SPEED_NUM_10G;
- link.link_autoneg = ETH_LINK_SPEED_FIXED;
+ link.link_autoneg = ETH_LINK_FIXED;
rte_eth_linkstatus_set(dev, &link);
}
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/virtio: fix link autoneg value
2018-03-16 10:51 [dpdk-dev] [PATCH 1/2] net/virtio: fix link autoneg value Ferruh Yigit
2018-03-16 10:51 ` [dpdk-dev] [PATCH 2/2] net/vmxnet3: " Ferruh Yigit
@ 2018-03-16 11:06 ` Ferruh Yigit
1 sibling, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-03-16 11:06 UTC (permalink / raw)
To: Yuanhan Liu, Maxime Coquelin, Tiwei Bie; +Cc: dev, stephen
On 3/16/2018 10:51 AM, Ferruh Yigit wrote:
> link_autoneg shold use ETH_LINK_FIXED, not ETH_LINK_SPEED_FIXED
>
> Fixes: 138f367aec66 ("net/virtio: use linkstatus helper functions")
> Cc: stephen@networkplumber.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Series
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-16 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-16 10:51 [dpdk-dev] [PATCH 1/2] net/virtio: fix link autoneg value Ferruh Yigit
2018-03-16 10:51 ` [dpdk-dev] [PATCH 2/2] net/vmxnet3: " Ferruh Yigit
2018-03-16 11:06 ` [dpdk-dev] [PATCH 1/2] net/virtio: " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).