From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id F09F85F18 for ; Fri, 16 Mar 2018 16:21:28 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EAA28402277A; Fri, 16 Mar 2018 15:21:27 +0000 (UTC) Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5119710B00A9; Fri, 16 Mar 2018 15:21:21 +0000 (UTC) From: Jens Freimann To: dev@dpdk.org Cc: tiwei.bie@intel.com, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mst@redhat.com Date: Fri, 16 Mar 2018 16:21:03 +0100 Message-Id: <20180316152120.13199-1-jfreimann@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 16 Mar 2018 15:21:27 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 16 Mar 2018 15:21:27 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:'' Subject: [dpdk-dev] [PATCH 00/17] implement packed virtqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 15:21:29 -0000 This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf It does not implement yet indirect descriptors and checksum offloading. A packed virtqueue is different from a split virtqueue in that it consists of only a single descriptor ring that replaces available and used ring, index and descriptor buffer. Each descriptor is readable and writable and has a flags field. These flags will mark if a descriptor is available or used. To detect new available descriptors even after the ring has wrapped, device and driver each have a single-bit wrap counter that is flipped from 0 to 1 and vice versa every time the last descriptor in the ring is used/made available. The idea behind this is to 1. improve performance by avoiding cache misses and 2. be easier for devices to implement. Regarding performance: with these patches I get 21.13 Mpps on my system as compared to 18.8 Mpps with the virtio 1.0 code. Packet size was 64 bytes, 0.05% acceptable loss. Test setup is described as in http://dpdk.org/doc/guides/howto/pvp_reference_benchmark.html Packet generator: MoonGen Intel(R) Xeon(R) CPU E5-2665 0 @ 2.40GHz Intel X710 NIC RHEL 7.4 Device under test: Intel(R) Xeon(R) CPU E5-2667 v4 @ 3.20GHz Intel X710 NIC RHEL 7.4 VM on DuT: RHEL7.4 I plan to do more performance test with bigger frame sizes. This patch series is based on a prototype implemented by Yuanhan Liu and Tiwei Bie. changes from v1->v2: * don't use VIRTQ_DESC_F_NEXT in used descriptors (Jason) * no rte_panice() in guest triggerable code (Maxime) * use unlikely when checking for vq (Maxime) * rename everything from _1_1 to _packed (Yuanhan) * add two more patches to implement mergeable receive buffers regards, Jens Jens Freimann (13): net/virtio: vring init for packed queues net/virtio: don't call virtio_disable_intr() for packed queues net/virtio: add virtio 1.1 defines net/virtio: add packed virtqueue helpers net/virtio: don't dump split virtqueue data net/virtio: implement transmit path for packed queues vhost: add virtio 1.1 defines vhost: add helpers for packed virtqueues vhost: dequeue for packed queues vhost: packed queue enqueue path net/virtio: disable ctrl virtqueue for packed rings net/virtio: add support for mergeable buffers with packed virtqueues vhost: support mergeable rx buffers with packed queues Yuanhan Liu (4): net/virtio-user: add option to use packed queues net/virtio: implement receive path for packed queues vhost: vring address setup for packed queues vhost: enable packed virtqueues drivers/net/virtio/Makefile | 1 + drivers/net/virtio/virtio_ethdev.c | 60 ++- drivers/net/virtio/virtio_ethdev.h | 5 + drivers/net/virtio/virtio_pci.h | 8 + drivers/net/virtio/virtio_ring.h | 64 ++- drivers/net/virtio/virtio_rxtx.c | 248 ++++++++++- drivers/net/virtio/virtio_rxtx_1.1.c | 161 ++++++++ drivers/net/virtio/virtio_user/virtio_user_dev.c | 12 +- drivers/net/virtio/virtio_user/virtio_user_dev.h | 3 +- drivers/net/virtio/virtio_user_ethdev.c | 15 +- drivers/net/virtio/virtqueue.c | 3 + drivers/net/virtio/virtqueue.h | 15 +- lib/librte_vhost/vhost.c | 4 + lib/librte_vhost/vhost.h | 7 +- lib/librte_vhost/vhost_user.c | 17 +- lib/librte_vhost/virtio-1.1.h | 63 +++ lib/librte_vhost/virtio_net.c | 506 +++++++++++++++++++++-- 17 files changed, 1127 insertions(+), 65 deletions(-) create mode 100644 drivers/net/virtio/virtio_rxtx_1.1.c create mode 100644 lib/librte_vhost/virtio-1.1.h -- 1.8.3.1