From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id A78185F2D for ; Mon, 19 Mar 2018 12:04:33 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2018 04:04:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,330,1517904000"; d="scan'208";a="39208408" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.164]) by fmsmga001.fm.intel.com with ESMTP; 19 Mar 2018 04:04:30 -0700 Date: Mon, 19 Mar 2018 19:02:56 +0800 From: Tiwei Bie To: Jens Freimann Cc: dev@dpdk.org, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mst@redhat.com Message-ID: <20180319110256.yaibpb37fybrohky@debian> References: <20180316152120.13199-1-jfreimann@redhat.com> <20180316152120.13199-14-jfreimann@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180316152120.13199-14-jfreimann@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 13/17] vhost: packed queue enqueue path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2018 11:04:34 -0000 On Fri, Mar 16, 2018 at 04:21:16PM +0100, Jens Freimann wrote: [...] > +static inline uint32_t __attribute__((always_inline)) > +vhost_enqueue_burst_packed(struct virtio_net *dev, uint16_t queue_id, > + struct rte_mbuf **pkts, uint32_t count) > +{ > + struct vhost_virtqueue *vq; > + struct vring_desc_packed *descs; > + uint16_t idx; > + uint16_t mask; > + uint16_t i; > + > + vq = dev->virtqueue[queue_id]; > + > + rte_spinlock_lock(&vq->access_lock); > + > + if (unlikely(vq->enabled == 0)) { > + i = 0; > + goto out_access_unlock; > + } > + > + if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)) > + vhost_user_iotlb_rd_lock(vq); > + > + descs = vq->desc_packed; > + mask = vq->size - 1; Queue size may not be a power of 2 in packed ring. > + > + for (i = 0; i < count; i++) { [...] > + mbuf_avail = rte_pktmbuf_data_len(m); > + mbuf_offset = 0; > + while (mbuf_avail != 0 || m->next != NULL) { > + /* done with current mbuf, fetch next */ > + if (mbuf_avail == 0) { > + m = m->next; > + > + mbuf_offset = 0; > + mbuf_avail = rte_pktmbuf_data_len(m); > + } > + > + /* done with current desc buf, fetch next */ > + if (desc_avail == 0) { > + if ((desc->flags & VRING_DESC_F_NEXT) == 0) { > + /* Room in vring buffer is not enough */ > + goto out; > + } > + > + idx = (idx + 1); > + desc = &descs[idx]; Need to check whether idx >= queue size. Thanks