From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0080.outbound.protection.outlook.com [104.47.42.80]) by dpdk.org (Postfix) with ESMTP id CB9775F1A for ; Tue, 20 Mar 2018 06:40:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=31pQf171OdWTFmv573F+joKjImoLgMGaZbV/yvwUDx4=; b=GpDuSwvQ8fkcRjmTcNVLwvwQOafqaBIvP9CAuLzraRMFnHG0Q1EiMAfGjLJwvLNgUEIwIUy7fVoPe7m/FF9KU0cagup3ubuhVbnJd4EvLSB5i45MMHKnRnmkAQ0A01bJOHPEnJwX5VlM1EWRrODV+Kt45H5nCwW9ktNCqtEQwCU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.200.244.169) by BN3PR07MB2513.namprd07.prod.outlook.com (2a01:111:e400:7bbf::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.14; Tue, 20 Mar 2018 05:39:56 +0000 Date: Tue, 20 Mar 2018 11:09:41 +0530 From: Jerin Jacob To: "Laatz, Kevin" Cc: Vipin Varghese , dev@dpdk.org, harry.van.haaren@intel.com Message-ID: <20180320053940.GA6251@jerin> References: <1519762085-77659-1-git-send-email-vipin.varghese@intel.com> <39dc23d4-bac3-7571-eaa8-a05c9f793efc@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39dc23d4-bac3-7571-eaa8-a05c9f793efc@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [106.200.244.169] X-ClientProxiedBy: MAXPR0101CA0059.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:e::21) To BN3PR07MB2513.namprd07.prod.outlook.com (2a01:111:e400:7bbf::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a734d042-d694-412d-3619-08d58e2504e2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:dAw/iVNf7tTIZoNOWHNb4wiAFtBqtDAY+2d2Ju2/hXVxakW3yteEw8slKV3l5cL5PhSZhD0yZ4H949vixtuce/TrX9fdQkOD+FsNQjztoxXXbcwRt9Rkge0rlBSG+Q/oyQ7ePzF5G9R46tmYZAfWF0isOXCAhV+6K3JMobmdhFAZVfsgcllSCJvZgcA+6NCYSlrlZXS03Xb7Nh/z92WWeuGGvyBtFD2E4rpNqIeejaN0dwk3HQmK5MDu/VYfsNNG; 25:SKZS6fQpGhMA4L5kUPEYXe2GPsl39ZJLt3RGYBOFYtisaigjKHEpDbPKWcIHGVjClxsECf89hXNiOLLUpNt7s9nP5QZ3eNa8WdGbCmqGHfiovYO2GPtC1vnZwm4yQE6hszJv0WBFBG1IQt7Mq1y/5Fev0JmYDQ/KFDXWjKSmgeY3W61Jts1v9AXpJ0sK1cYwnlrcATGuC7HgO8CS0/6pksDCMukBzu7hycnJbR9JBEDXw3psGOFNICKbl/7vJ3ADJL2+hE9asG1Gxfy4AP66O+6Qh9iD8gDuSAeVdpgYLrihucQw2T80WtXxMm/wd7LivvuPDCTJz+8idmUzw7tMwg==; 31:MGaV4P05q4AWLCv1Z9cCUyKYGg6wHGc9MiycW4TvApwFbTYyyqfUpv72YMELYiLkTHmvGmNCMhL+v6Oz69gxI9yoB8Fd+eA+LBkRZUyaF5EUltCBN+Bh5nxl+UJjY7bt3Mg9Q7rJ3lIwr6QiJZD/ubyuoS2q/3f9JSdJmFtbksZaa6k88VV+URfAdrSFS1w45fK9V1JSguIjHOEfRuVP621PELDuxZc28keJNI1Fuaw= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:45nx6R0M22N4JxH267Gnwml8YZwLFGGjAr5BDCCDK8MXXHy5nyKAUDCfwc7JxTRxl5JEdK+sedU8yCyg0rh+OYNjGS/fT9tIMPPsWn6kKEW1FiXAfrmly1Xy6v5qtfKPI4YG12kKvo078a+yPcXik0RT3+yo65BUFNBvnBmHBzMw0RjnDMf8B+bcJuSJCo72JpjRyDo9fi837Y9Zsi1Y3SX5TTbH+WTgycLe7lC3AeeyqdwOb9Qj/tjtu2yxcJ369M9WH/rMm7uM555WvsUZKNOWIE0UvSbyve5a6X35k9H1s8XGvW0M6ZIaqSiBSfX0tlixjQJLpmhuSFl86Po5ZbO85ZUzu7hqPX8ogE3ryY6i5sXj9cwdxnf0gbPERLIaf0oyzvHc9Yt6hAHI9fGaczwl8Cs+egQA/Op/YZWp65zHpInRhVlIwikwMxHndRB8uIj0WnFHrkalMPPeVsYF3/UkjMGF/EePrn21wJTovi87N4Wf5iQzXRQzyIaOHCjXrQ+cbOyRHGaucp6fuyUCQYvonsX8Xwc93kI9vzwHjhoSpHfoiLxYVe7gBiF12Ta3UwhcONiZPJmAnwkSVxrHAoYZoOqhqXfAZh/I5EHNVHM=; 4:fNQQ9bIK+MfIWgqnhTYo0SvvRtVto0hfGfLex2eHDGigBbvdEVwmyq467v1nlRbblTNmBp2B9LMsMDCKmG3jUpQQKgl9GasIdbJFpkVOAO2jVCu6UafMWF4aQpXtBfQ3wnI9aIGXgu+ltsnCK3KyVSmWaDvrPuoLaVkIdUI98M7S9xcgoxWbuLG8pytaGb9p/NBjZ3N0XeQw+u0yM9egw96iJPnz76SAp7Z9S1iXvFOXle+vBqaPzl/ytRLPOVUi1EwqIpviln3Os2btJHgZndmPKubeoVR2zLzVrnNie9YKsJjfFcB7SliNoLGq8PX/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231221)(944501307)(52105095)(93006095)(3002001)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:; SRVR:BN3PR07MB2513; X-Forefront-PRVS: 061725F016 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(39380400002)(376002)(396003)(346002)(199004)(189003)(13464003)(5009440100003)(6916009)(105586002)(42882007)(2950100002)(5660300001)(9686003)(478600001)(55016002)(33656002)(7736002)(72206003)(25786009)(305945005)(6246003)(8676002)(33716001)(53936002)(81166006)(66066001)(58126008)(47776003)(16586007)(50466002)(97736004)(6666003)(68736007)(4326008)(316002)(81156014)(59450400001)(2906002)(8936002)(186003)(16526019)(52116002)(33896004)(6496006)(106356001)(76176011)(1076002)(6116002)(23726003)(386003)(3846002)(229853002)(26005)(53546011)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2513; 23:VPaDZQ19XhIW7PrnUf5yPhkPchcyTC2TWHD00l16Q?= =?us-ascii?Q?/iGai/Fv5JQqLqe2nhNPoGy1QYcsvwtmHFPKOXqVU8yU24h/Kun4YVbuzjuh?= =?us-ascii?Q?EqVeIMmuoBFSMTgJzIRV6Mqa4Bk5gr0rpTzWh6zO8JOrmNSnupiksftjC5Iv?= =?us-ascii?Q?gocZ2xNikEyjf3KQo3z+XfsM9B88tzw5YayHNy0xCUiJZNPJR3YJe4VHyLpN?= =?us-ascii?Q?bjkvdAmcwXJLDKOghGvaOLp5KFz17CMGr6xhzscDCV6LyjM9TWwSpncAcDNB?= =?us-ascii?Q?+10EHrYVhv6VWlmOR8mHXJYZVo+QaywOb5RQfRgN3UZGP6IFdaNnSGLY8xRs?= =?us-ascii?Q?9qHzfn8RkF9Ar+mhGeVVUfG9IaMOvt4jEOlDpI2AF5YrwHUvSh3UeMOECPIu?= =?us-ascii?Q?VHJAUI6DATHCFXZyjACwdPmwtMMgLaaMgh9uBirX85os3nUzmkh8tRZ23lXT?= =?us-ascii?Q?6+FQFVxMWnSxam9Xc83D/G8SRskKHyeWgxHcGGKeyqJ/8nn4CJB2I/CLSt/u?= =?us-ascii?Q?dgxmNb/2na1AwNV8mZZjsd5XS7y2OnpxFhFnJjqFSMh7cMwlZxp76rdfoT0Z?= =?us-ascii?Q?Xx1OPNeAESks4jvgNklSi0z3y1duEnDvBOPTj2cRNd1+QbBERaDhPo1r5+mh?= =?us-ascii?Q?4x63izhRsC3QnfA5YX6lcKGBgvESte8OvLwZUhkmQrBginolegxW0DyROuVD?= =?us-ascii?Q?OQACrlndCy1k8AF16uB5hMMPDs0Pqt1O5KeIfiu9HgK3QWYDbLcIpSmN/gv2?= =?us-ascii?Q?RTEiDLMypaS8+1WHlsocvjwPKjMkkIG3xC8lbYzeQwhrbpO8V7Lq60TOQalP?= =?us-ascii?Q?AN/RrhbyXZVRpRqG2sPbrZC0u3vAhe+AxppwZZfb94W2VVF01b8z+kS0FtQ3?= =?us-ascii?Q?xR+6+EHDY1LzReAKva1hjo1B1fnGeC/w6/QoZSQHtY+TmDtOaZbNf/7Fn5Ue?= =?us-ascii?Q?SUYrPdwi9UksMMKad7zEeCbTBmG1LYC3poz6Q6BjezMBVyVq1D4b3xYihhm2?= =?us-ascii?Q?4CtvetcrcBRjdAL4D7wBfMzPSmIJOMzY01/WMWgptHFqhiPj7xrdEqNVZt/6?= =?us-ascii?Q?QgmlTihk/dd3GCMmYGBB+j12cTJ+lzI3tpmISvwHZRh2P5t8Wn2FM3Lc7uZU?= =?us-ascii?Q?sgJ5rnmXONTPHXF+/G5CVSSPw0lXvj2bmbJ2nE/ry1TfRwduSDoHDTmT5A/O?= =?us-ascii?Q?RJpL+56U4vOQhq00giMwa/oft4e+4a4f06FnW+hzAzq9DsN7DbbT7fCxssuE?= =?us-ascii?Q?1YyhGMkWVTJE+cwImuocsi6krGkwjTeoWkjzwhOUbSI3oMgHZMaKtHtZvQZl?= =?us-ascii?Q?8XBYLX0Ye0woynPQofa5U6e2oT0m2zZug/qA3UPfE+6?= X-Microsoft-Antispam-Message-Info: 4Nbo/BYBgTUSxsWLc8jduB7tWbglNrdjrkgf2DsjkzF/lwHLTOZ4wIwa13OkTULEerfllh0PfaEpRj1ElhOmebVetXbJ+LK5MTNECsc9EM5NEdfD1CWce3AkkRkBDoIQFWinWQuXr9qlDXmv7NOCORLeo0/N+26UuTHCrdDTaCGA9hveuOn8om30eid0MhMq X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:eOtZ0csV1ny6a6/ezWJ/NS5adbC0cYQkaFYAPTB5erOzLnZq8chA8uKgmxEBQhvTeCQJOphsTI/XYgXmcuA29+59F13SxlYNtHDzdfWod8Sk7qyYQB718T7sJpJm+jjs+p93d2iFkC9TQ8SdXkBmiSRLyiGdr6wWeuSgxKXp3mwR4EF3ibZcmlwXagYfYIYU1LZkf2CQgcnMlThkqXmu3JMNa+kiDAo9LBgVz3rWVYqi51wO6JTjfwGZHeeY5RtgyNGkAi8FwNqxTHUq9hmmdvxiWD7jVRGTYjWrv/oUOIu3JkgvsvUstHSs/1hRdFc55ZlqX06VIcovNMp6xuUmruvIPqMS7UNecRust0BLK8Q=; 5:z1nG7E0k2xLeJEpVfrqPyjX/dVhPNlIZ1I1qWC81Lk8YfyFxqsd6ox4NAgIz18kh0hs92CYivhomWDTFIYzeCnZ38NuzdTBRsm0JqtLcgxk7VUpFUPhNaFCXGbaygINjscb9LYeamObNeEkpWxAofKw6aauncpxQsxzSVPsS8S4=; 24:ztjOUTO9/c5p77shOjS6zI3dr3Ve+lvFMZNHXkv6czNMBC+v/DdsibHi+pAWt/Rqo3IqrOlR7Q184NoUE7tm+rVIB4xmh9nJB1j84NNp6lA=; 7:tHMZSj3zEsFbkhadR7WdhxvxkPySW7mTg5Prsf/rpVXT94hOB4f+hlTh4DoiaKMl0D/a0TQOElBSsmvkBFyeDyoYCo0Y2AHmV8P9u+POjoZ3WpsuV17h7lV0KAE0DZC1C5GEiCCeJOOfUREO1ltAJPY61CpBexQoKgKtGj/ID+S4kBKGDO2qh/wnQ8AF43fRp6e7cogGBH5ysIwGsIX9CAhjifkWAiHxILMmIwHf4wdkKctSs6dc41DFFFFdYbso SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2018 05:39:56.9112 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a734d042-d694-412d-3619-08d58e2504e2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH] event/sw: add unlikely branch predict X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 05:40:02 -0000 -----Original Message----- > Date: Wed, 14 Mar 2018 13:06:35 +0000 > From: "Laatz, Kevin" > To: Vipin Varghese > CC: dev@dpdk.org, harry.van.haaren@intel.com > Subject: Re: [dpdk-dev] [PATCH] event/sw: add unlikely branch predict > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.6.0 > > > On 27/02/2018 20:08, Vipin Varghese wrote: > > For most run cases 'sw->started' holds true. Adding a branch prediction > > suggestion to compiler helps as this is first conditional check just > > after entering the function. > > > > Signed-off-by: Vipin Varghese > > --- > > drivers/event/sw/sw_evdev_scheduler.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c > > index 3106eb3..17bd4c0 100644 > > --- a/drivers/event/sw/sw_evdev_scheduler.c > > +++ b/drivers/event/sw/sw_evdev_scheduler.c > > @@ -508,7 +508,7 @@ sw_event_schedule(struct rte_eventdev *dev) > > uint32_t i; > > sw->sched_called++; > > - if (!sw->started) > > + if (unlikely(!sw->started)) > > return; > > do { > > Acked-by: Kevin Laatz Applied to dpdk-next-eventdev/master. Thanks.