From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>,
jerin.jacob@caviumnetworks.com,
santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com,
lironh@marvell.com, bruce.richardson@intel.com,
fiona.trahe@intel.com, shreyansh.jain@nxp.com,
hemant.agrawal@nxp.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder
Date: Tue, 20 Mar 2018 21:36:25 +0530 [thread overview]
Message-ID: <20180320160624.GB18022@ltp-pvn> (raw)
In-Reply-To: <36228538.oZjJHnOzEO@xps>
Hi Thomas,
On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote:
> 20/03/2018 15:40, Pavan Nikhilesh:
> > Add driver/common folder and skeleton makefile for adding commonly used
> > functions across mempool, event and net devices.
>
> I am not sure there is a real benefit of introducing such new directory.
> Is it only solving the choice of where you add files used
> by several drivers?
> Is drivers/bus/X/ the directory of choice for platform shared files?
drivers/bus doesn't seem to be a appropriate abstraction common API's
used across multiple PMD's.
This change is in regards with the discussion on ml:
http://dpdk.org/ml/archives/dev/2018-March/092822.html
drivers/common seems to be a popular opinion but maybe we could use something
like drivers/SoC or if you have something in mind please suggest.
Thanks,
Pavan.
>
>
>
next prev parent reply other threads:[~2018-03-20 16:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 9:27 [dpdk-dev] [PATCH " Pavan Nikhilesh
2018-03-19 9:27 ` [dpdk-dev] [PATCH 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-19 10:35 ` [dpdk-dev] [PATCH 1/2] drivers: add " Shreyansh Jain
2018-03-20 14:38 ` Pavan Nikhilesh
2018-03-20 14:40 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2018-03-20 14:40 ` [dpdk-dev] [PATCH v2 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-20 15:01 ` Hemant Agrawal
2018-03-20 16:00 ` Pavan Nikhilesh
2018-03-20 15:45 ` [dpdk-dev] [PATCH v2 1/2] drivers: add " Thomas Monjalon
2018-03-20 16:06 ` Pavan Nikhilesh [this message]
2018-03-20 17:01 ` Bruce Richardson
2018-03-20 17:27 ` Thomas Monjalon
2018-03-20 19:25 ` Trahe, Fiona
2018-03-26 7:53 ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2018-03-26 7:53 ` [dpdk-dev] [PATCH v3 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-27 16:15 ` Thomas Monjalon
2018-03-30 17:23 ` Pavan Nikhilesh
2018-03-27 16:11 ` [dpdk-dev] [PATCH v3 1/2] drivers: add " Thomas Monjalon
2018-04-02 9:09 ` [dpdk-dev] [PATCH v4 " Pavan Nikhilesh
2018-04-02 9:10 ` [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-04-04 3:29 ` Jerin Jacob
2018-04-04 5:06 ` santosh
2018-04-04 9:23 ` Thomas Monjalon
2018-04-03 6:57 ` [dpdk-dev] [PATCH v4 1/2] drivers: add " Hemant Agrawal
2018-04-04 3:08 ` Jerin Jacob
2018-04-04 5:01 ` santosh
2018-04-04 14:30 ` [dpdk-dev] [PATCH v5 " Pavan Nikhilesh
2018-04-04 14:30 ` [dpdk-dev] [PATCH v5 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-04-04 14:37 ` Thomas Monjalon
2018-04-04 21:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320160624.GB18022@ltp-pvn \
--to=pbhagavatula@caviumnetworks.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=lironh@marvell.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=shreyansh.jain@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).