From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40055.outbound.protection.outlook.com [40.107.4.55]) by dpdk.org (Postfix) with ESMTP id C73E62BF1 for ; Wed, 21 Mar 2018 00:07:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WISgdKWl9dqhK708wwqBn7gOmNOy33aZpP6F5fglvrc=; b=BxdifC1EFdD8zVE3rdcgHGXzf4ARJrRoy6fADuADd6ize+Bqy27dhUzcTzWdPE9RcQv5h31SbJ54KxO/SPIYzH5PNkx84Mf9vr3QBHcLjdzY7apMwMrxuA89jNn9KzkFs0M8JuxIlx/st3ZE7ZJiGoFK3i3vsAlq9VEj7Y4MnSA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from yongseok-MBP.local (209.116.155.178) by HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Tue, 20 Mar 2018 23:07:25 +0000 Date: Tue, 20 Mar 2018 16:07:11 -0700 From: Yongseok Koh To: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Cc: Allain Legacy , adrien.mazarguil@6wind.com, dev@dpdk.org, matt.peters@windriver.com Message-ID: <20180320230710.GA49230@yongseok-MBP.local> References: <20180319163007.11516-1-allain.legacy@windriver.com> <20180320122608.6noglggdsojbtqsx@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180320122608.6noglggdsojbtqsx@laranjeiro-vm.dev.6wind.com> User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR2201CA0020.namprd22.prod.outlook.com (2603:10b6:301:28::33) To HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ef6083ae-32a4-4555-1ce3-08d58eb7596b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2043; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 3:I45WdLPtZFui/P/xAWQEXLEr6Y8SlDlMZbfQIsjo2dmnaWf/aawUtcFi6rC0jgMonGX8RoJUnxs3vrInjMbe3BQVkkHDLjMuMCi0biB7yB2FqAQ+VU7FYrwU1nNyI9BDWM0bCecc5KFpfEsVWrHoYdM17KRv/aXDH8+c95GCa2eGqZFFjXjURoPTahINYjWJw5T82BwN5+9hpAFjbz9bOURaqVI6CgTq8qlsdDKvhxChBgdLPGngqAWyRhfU503x; 25:qypl6k/lddOusH81tb5iXf4URLR9XCavxOpIHdZmDHuZky1v5M/6Q7XzDhmoRHTFLRaMRZ30S08VPpil/S2/Kf230RckVCbeXLt6H5TXNNTKBMapQJPxLlojrY5v6yY2aBZxGJWbwQ/FMaHCbnc0n7ZJzBSGlI54SNG4ww/RhvA0tCAdgrKxaUXHYyc4VhAJWZKvVveeDS0EoMx04Q1k8MPz0GLNjG9MjjPHCvUPoUkcsJ0l4J7BAkT4Zw+CuDS4gRqd09I7NTObyfOYJtt36uppcndw+AVBQ2PMbGjGKcc9ozft+baGj0A1vRZ1jToar98NPIhxrotzeNraawngQg==; 31:oiXec9WouT62Mtp2DUOQUXqhg15u0YPk7hJG0k51Bgx161KP06q23RgZNxUBxcjHHVWeRy8yTgfag3S20DWxMWXReMuXU/Rn4f07+B+cis9kdlhwmETmYszWP/FEeCIeEKJNHlroaaRgJjlyRk3FeOisIPOHx/qMglbfwLpnbuqDSQlZf1xXy7Up1Xj7QH2qZhmG0ksfomtGTFmvMEPFt4HJHxk22dRPRvtzY7VrxiM= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2043: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 20:7oC50AMhem4WG3AW6ySqCkqAanCPTa5YqdOH+GKsxiFLc6WcDjiF6612WMuJiTE4X7R4GRLXTZ/UGLSxIScW1CF3aj8cj25vfOavxpWi3xPRYuLuAw7aeADE8ut1yxTaehGjZ5iGmlwtrRj3b28uERQBk1qHJQCSr7B/LFb/q7WsaJYVfZ2wmTH+V9Om0sr80V1OmT4aCd/kffTI7pVF/EQVgCM6FgxXV4AZeXSd6VVZGA09yNcAifNg59FYaH/BA2ydmM/Bhhr92msW3lNNfpMHNzYQ0uF2StRukR2lu4fWftDjxQEfRD186rQzfqRwXoOgBYqYWfERAoA2Uk9RrzwBTY6nuHp5iGWzLHXIs8+t+gvlG7p9PsP5vGMLuLz/APX2GS1JFDzRNo61ciN9ZMZP2OxyH6mtzbt2bJg6sZWiXb2yKRvFc5peurX0/+uQHkYUcg0p1W9iw0YJL//IkpKKJwulGp4p8PbQr4yuMgcbRMTtsSQTcCfp2UE3fI0K; 4:1HkPWsIXOdZ4/C2J/H2Ra8Pz7eZgRhoOyL6GAcC0LLL5JtLpLLGqk6vr2/IBrtZhsImJlG6lMsaZpgS1VB5BLyGqZB/NyKr+MhwI4C3YPHkuJCiF/pNcYWAH3pdPRfAvO3AX3uEHXaVLNbu4peNatguCmUCvb2aI0lJc1PC3Y8uWUTghhqdisL9otIBSjAFLnIwLvV7Rk1mrs1qY8Cc1+tnc2ZDcR9Wh1e/nROONPnV3qcGsn1k57VsGAcWtiijmQHnmIiKgYEKpGOO3nve9/Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231221)(944501316)(52105095)(6055026)(6041310)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR0501MB2043; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2043; X-Forefront-PRVS: 061725F016 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(376002)(39860400002)(39380400002)(346002)(189003)(199004)(98436002)(33656002)(305945005)(50466002)(316002)(58126008)(7736002)(9686003)(53936002)(6246003)(25786009)(55016002)(33896004)(97736004)(5660300001)(4326008)(105586002)(23756003)(1076002)(47776003)(66066001)(86362001)(2906002)(2950100002)(2870700001)(575784001)(6916009)(6666003)(106356001)(52116002)(76176011)(7696005)(229853002)(8936002)(81156014)(81166006)(8676002)(6116002)(16526019)(186003)(68736007)(59450400001)(6506007)(478600001)(26005)(386003)(3846002)(18370500001)(26953001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2043; H:yongseok-MBP.local; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; HE1PR0501MB2043; 23:MF3QeZ7pV0wf/tQx+77tjDgDzWQ37q+pFY5/y?= =?iso-8859-1?Q?6sQBfhWEzcCqr/ZYpu8FCKifjMuC6EM3wgR3QVLJ12b9QSz7aO5BHs6z73?= =?iso-8859-1?Q?cKvr23J34fgPU4QLW4BGnuakMi0md6Gm4EvpPMGQ1yPm4IdwMOKtPxDtul?= =?iso-8859-1?Q?3G4p50ReIw8OwMUUA9KZDzdnQ5mOBC8umdkDhpRbf0TdNIhKTVxvbwtk9I?= =?iso-8859-1?Q?qigPEea7A7/HO6P95ViHTLx26/3TtmJxeQTa0L7iIdcRQYailrr88v/B69?= =?iso-8859-1?Q?tluZ6JGTbTyT8CqlSPCOmjQCIR52mAR9AVU5gzgA6OWMvza52cNKa6uHC2?= =?iso-8859-1?Q?DMMmveX2bCjIU/9jd3J6EIj7cN93wJK67s9E4C+/7v6c+LE/ZKqSNYBrPN?= =?iso-8859-1?Q?RMEkoQsVeSDb8OHWG/N9SB2AL4W9vYkQavJ2GE88dTHSdXDjcubgeQUJFw?= =?iso-8859-1?Q?ENxji/PNWlsfDXRVgWKiUssFWVJVf09ePpSvP/i07nL28TW84L/VTjg60l?= =?iso-8859-1?Q?tgyI86SRcAohyketAnyD2iGAjobru88csTNpwOd0juEm0jHKxAXfTlomnR?= =?iso-8859-1?Q?LVmiWpTxxYp6UeUqO3DBOQB+ailtADRMc9ISIiZihP8CPxSfQtY/DoUdBH?= =?iso-8859-1?Q?tucVwuGyMul1LM8Vq9RISRhuTdYLfMTRWWf4dsQjZNU5BwG7x3SVhKLcwm?= =?iso-8859-1?Q?WOogxSA+kZsr83qOIaVhW+FjTPjf4AskeUCfM+Exfmhq+MMuY5HwHtEX9U?= =?iso-8859-1?Q?4QhgF7AZIHnpcAJZKy6AzrSaYGlvuKDIvvzRWKrr+JtEHsxgkDDbsCFUU2?= =?iso-8859-1?Q?55PDG5gsiSlievVwx3CaINsZsx2cp2Pu009Xh2BQUS+FTH93Jgobo9/dJH?= =?iso-8859-1?Q?0A2VBHpPPniEuTJ8NQtO/eLeUx42eh1yNtNsKzOX/beUg+4ZGDOb9/tyWb?= =?iso-8859-1?Q?2oSt3kCs65aLfAnLvJrbf6cXeiJYCgUvBvfCPn2WlrPqksUTzfvxJnX0nI?= =?iso-8859-1?Q?bnvGssSuGxLm0rsgUjmtd4fYUcwO7YG2ykCtpzZaeE6d5OV3ECyQ9502/3?= =?iso-8859-1?Q?IwKgmJhnM4Ics8TC2SbXGeLXZF50xaj1dXu68K5b//dA1skotpOwF05Cjd?= =?iso-8859-1?Q?xgkbpCWA8qzxbH1fgh+AG61w4wSENLhGZ1LF5ggzdDfF9W9JO2uTb7vI54?= =?iso-8859-1?Q?2vf+QV4NKwM95lylgfktiOIt1rgf/v6tA9BhoKX6DN0ZReFH2YfB0dsgnY?= =?iso-8859-1?Q?TNFvkuRUDAsgFEX7oNWsXJ9hg6CWqFK7Hp0Ze+exFs8LZDTWzkOnh/7neb?= =?iso-8859-1?Q?EceJM9mUMkJy+VO1P7bb4CwkH6+raufxz0lcVsDblfWkCMLBHNdLHRkpFq?= =?iso-8859-1?Q?rZKMUkvQKE=3D?= X-Microsoft-Antispam-Message-Info: SHaz5Ns6qyH9+9VFkAlyohvFkiF0JN/3DuwRuR3IatkJdEA1s0QP47kwAEiYwn+yNMlnaFESYyHkyFFsS7eXL675f9cob4R6PCbGpEo3GTy0ZnioudEgzT1KIFYIIAkcLgpvMyXase74X3wDPSU5pCVq/b+tOzVeQnmcekYaItcFnPf4yyCzEblM+hM3Hsrp X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 6:cX3BArP0kX7UKDrJUlSPGexjJlHNYa9WU29nEqpQAI5jXN7b13MiXWKbSEJ1q+ElyymtuOHO9YfhNQDFI4s6lo7FgMZfYAg7oQ1S01ah0FsaUf/7eeh6fkwj3Jmo+3R4EuWVUdPaWq7hs6J6/BD4lfyv7KsmeartvKHe1nXehvrh4jZkahiu91PuVOY8Pi2RVsGTbehp+sKyPsOKPWpBXCKjlFzzQqUXjC3uHlrZlOw8joir2G1WfDL3aag78tp7nhW8hwC+Vj9jckm8K+e1A2dXyDW9mO3tDR8XmDc3vMHUMTidHvoiDg68FNMhhKCEHng0vP52uJHWDKcn0Zp+9c/HNfRyb6Q3/6ySfJO3IJ0=; 5:IsWuDIPwOHz17DO/LnXbwKANWXPZA4sGJBKRe1kHe2icfeIoipTm/WP6dkw8aoDV63LuakXzPC9FTEnUWjR6O3Oy/qOvFFkXeeUB7pgaabt+uCACf5yS9kNgbC7EcQkMnizzFbk/W+hV5JIao1QJBcOF5mf9w/nGVzisispyVl0=; 24:NTlQgh8ZKfV0yIHOziJf47UkaZlHOq17z4nOHF4+uRoIB89Y0lf/sTRZ1E6UArNJPtvxj6twup2u/aIBCdt8iigKCSM81ceIHs5SFU2DCKM=; 7:RC/zk49i0ofY2LIvk9PPh0JPEnaV5TvWiNoOJLfqwl6cU13iT283rlBFEvjn8T6Dj1lb+FumKclLIJoySdxchk2xwfBgIha/2oRVyCYThex2e01ScLV2jp8M/tQXIsL00joc5yJgq8525jqxkbnvuMciQpJKxvQMSiQiiTvQSco3xmtik+hYrTfc35teq8nfmMkAv5zkENSg9SQWpGKplDxjh6dBePxROcciXII39i/NkMg1qff1HM8pmXKz1wO7 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2018 23:07:25.9112 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef6083ae-32a4-4555-1ce3-08d58eb7596b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2043 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: setup RSS regardless of queue count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 23:07:30 -0000 On Tue, Mar 20, 2018 at 01:26:08PM +0100, Nélio Laranjeiro wrote: > On Mon, Mar 19, 2018 at 11:30:07AM -0500, Allain Legacy wrote: > > From: Dahir Osman > > > > In some environments it is desirable to have the NIC perform RSS > > normally on the packet regardless of the number of queues configured. > > The RSS hash result that is stored in the mbuf can then be used by > > the application to make decisions about how to distribute workloads > > to threads, secondary processes, or even virtual machines if the > > application is a virtual switch. This change to the mlx5 driver > > aligns with how other drivers in the Intel family work. > > > > Signed-off-by: Allain Legacy > > --- > > drivers/net/mlx5/mlx5_rxq.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > > index ff58c4921..e6b05b0ad 100644 > > --- a/drivers/net/mlx5/mlx5_rxq.c > > +++ b/drivers/net/mlx5/mlx5_rxq.c > > @@ -1028,7 +1028,8 @@ mlx5_priv_rxq_new(struct priv *priv, uint16_t idx, uint16_t desc, > > tmpl->rxq.crc_present ? "disabled" : "enabled", > > tmpl->rxq.crc_present << 2); > > /* Save port ID. */ > > - tmpl->rxq.rss_hash = priv->rxqs_n > 1; > > + tmpl->rxq.rss_hash = (!!(dev->data->dev_conf.rxmode.mq_mode & > > + ETH_MQ_RX_RSS)); > > tmpl->rxq.port_id = dev->data->port_id; > > tmpl->priv = priv; > > tmpl->rxq.mp = mp; > > -- > > 2.12.1 > > Unfortunately, is not enough to have a valid RSS hash result when the > PMD has a single Rx queue, a little more work needs to be handled in the > mlx5_flow.c engine to configure the hash field in Verbs Hash Rx queues > when a single queues is being used. It is good to have such feature like described in the commit message. And from Allain's other email, it seems datapath of mlx5 ignores valid hash result from HW for no reason if the number of queue is one. Allain, you wanted to fix that, didn't you? Nelio, can you please share a bit more idea of what should be done further in mlx5_flow.c for this, so that Allain can come up with a right patch? Thanks, Yongseok