From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id A6F955F2F for ; Wed, 21 Mar 2018 22:37:46 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id f125so12430062wme.4 for ; Wed, 21 Mar 2018 14:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=TST9S2iaXPL5DBNq0X3+AoIwRfkbJ4rOfrnuYkHyeoY=; b=ff7Ma4oMpnlxxQCL/qPZ2vCVJFVFIILI8v8DTnQsm8efcGgKjca99DNsmpQY1Pn9DY rqlgKDmYn5iWZ9DClo3O23mul9VWIbdRVabZ2gYIaxg7aCaLqiW6JyoFZXcTdezzazim fV6Bmw5U/zv9AMsdQDhz0Mz4AwJOoev8nTQgaGejp/h8FCukatM5ovv7KaPsSm2JmdP0 ieOCiWKX2bdh3wVr2s2DKCdwP1KwbydCY8PWVZRPuMWpqlh3C9PtIiuj8pV5Gyk4UQEy 3vFRWWThk0JSKTI/5aQbLBGTzetMkBW62+RuIYUa304m0LywB0ULhY+roRfbpcTy07EL OQnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=TST9S2iaXPL5DBNq0X3+AoIwRfkbJ4rOfrnuYkHyeoY=; b=XFINRS+LP9Sx+AmpXgo19O5n9sHdlc4QmaPNzWswp5wgpHX2L4ISoVNf8dQ4/VSeQe Q0peA/sxKgjlqvDD1MhVUYarctV5th8k8N59x7gSJq++15In53XtqfAa74m/vlT3ZXlu /iEaIa60fyOhz0/+f00yajDUNaqS1e9JJ8+sw2KQYylElllQzx1jvtsNpDXL8R4aAA65 xxnUmS6Gher9wnq8l0vFdmdWqrH7lJnVuk7yF4ucNCAX17B52vuC8N6EqNlfcvT7LL59 9tWoNXTO1mAkxy8TPCIyH+tqG8JDuENgt/mKrDWPqrf6QPg10AgqB5wiUlqVFy0hPN7J XZlw== X-Gm-Message-State: AElRT7G8T6oV8Avg5LxeGZILgMGOolqewR4/HLjjIsly1e9lqI+rd6G3 5VTyQRooI0c2jH/jSaEOf4EwLw== X-Google-Smtp-Source: AG47ELtdN2CBaPReUUk/XRoi7IxVOwoHl3MRHl8sJmfBcwcEt6RilXlY8VBCHcIwz9cV6HpbgEjiIg== X-Received: by 10.28.40.194 with SMTP id o185mr2947819wmo.111.1521668266127; Wed, 21 Mar 2018 14:37:46 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m184sm4724061wme.40.2018.03.21.14.37.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Mar 2018 14:37:45 -0700 (PDT) Date: Wed, 21 Mar 2018 22:37:30 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: Xiao Wang , junjie.j.chen@intel.com, dev@dpdk.org, maxime.coquelin@redhat.com, yliu@fridaylinux.org, zhihong.wang@intel.com, tiwei.bie@intel.com, rosen.xu@intel.com, dan.daly@intel.com, cunming.liang@intel.com, anatoly.burakov@intel.com Message-ID: <20180321213730.iidhaoib6nprr5qq@bidouze.vm.6wind.com> References: <20180309230809.63361-3-xiao.w.wang@intel.com> <20180321132108.52464-1-xiao.w.wang@intel.com> <20180321132108.52464-2-xiao.w.wang@intel.com> <2126445.Z7b39kXXoB@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2126445.Z7b39kXXoB@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal/vfio: add support for multiple container X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 21:37:46 -0000 On Wed, Mar 21, 2018 at 09:32:18PM +0100, Thomas Monjalon wrote: > Hi, > > 21/03/2018 14:21, Xiao Wang: > > +#endif /* VFIO_PRESENT */ > > #endif /* _RTE_VFIO_H_ */ > > Please keep the empty line which was present between endif. > > > + rte_vfio_create_container; > > + rte_vfio_destroy_container; > > + rte_vfio_bind_group_no; > > + rte_vfio_unbind_group_no; > > + rte_vfio_dma_map; > > + rte_vfio_dma_unmap; > > + rte_vfio_get_group_fd; > > Please keep alphabetical order. > > About the naming, I see "no" and "idx" are used. > Other APIs in DPDK are using "num" and "id". Any strong opinion? {bind,unbind}_group is sufficient as a name. _no is redundant as implicit from the parameter type. -- Gaëtan Rivet 6WIND