From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 7CE1C4C8C for ; Thu, 22 Mar 2018 15:21:37 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2018 07:21:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,345,1517904000"; d="scan'208";a="35940810" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.52]) by FMSMGA003.fm.intel.com with SMTP; 22 Mar 2018 07:21:34 -0700 Received: by (sSMTP sendmail emulation); Thu, 22 Mar 2018 14:21:33 +0000 Date: Thu, 22 Mar 2018 14:21:33 +0000 From: Bruce Richardson To: "Hanoch Haim (hhaim)" Cc: Ferruh Yigit , "dev@dpdk.org" Message-ID: <20180322142133.GA7112@bricha3-MOBL.ger.corp.intel.com> References: <782383cd531a4248a3634705f46d8acf@XCH-RTP-017.cisco.com> <20180322113457.GB608@bricha3-MOBL.ger.corp.intel.com> <856b65d4-a35f-3b2e-73d4-dbfdf105b9c6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] i40e mbuf->rss indication X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 14:21:38 -0000 On Thu, Mar 22, 2018 at 12:52:30PM +0000, Hanoch Haim (hhaim) wrote: > Hi, > I think this is not the vector driver because I'm user scatter/gather > Vector driver has supported multi-buffer packets for a while now, so it should be used for packet RX in i40e in just about all cases. If possible, could you check if adjusting the setting for 16B/32B descriptors in the build-time config makes a difference. For 16B descriptors the flow director ID and RSS hash share a field in the descriptor, while they don't with 32B versions (though the vector driver only ever reads the first 16B of each descriptor in any case). /Bruce > Thanks, > Hanoh > > > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Thursday, March 22, 2018 2:18 PM > To: Hanoch Haim (hhaim); Bruce Richardson > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] i40e mbuf->rss indication > > On 3/22/2018 11:46 AM, Hanoch Haim (hhaim) wrote: > > Driver: i40e > > > > DPDK : 17.11 > > > > Configuration : > > > > 1) RSS configuration > > rxmode.mq_mode = ETH_MQ_RX_RSS; > > rss->rss_hf = ETH_RSS_UDP | ETH_RSS_TCP; > > rss->rss_key = Microsoft key > > rss->rss_key_len = 52 > > > > *configure RETA to some rx-queues > > > > 2) Change hash to TOEPLITZ (only for i40e) > > > > struct rte_eth_hash_filter_info info = {}; > > info.info_type = RTE_ETH_HASH_FILTER_GLOBAL_CONFIG; > > info.info.global_conf.hash_func = RTE_ETH_HASH_FUNCTION_TOEPLITZ; > > rte_eth_dev_filter_ctrl(m_repid, > > RTE_ETH_FILTER_HASH, > > RTE_ETH_FILTER_SET, &info); > > > > 3) Configure some flow-director rules > > > > 4) TCP/UDP packets are received to the *right* core (based on a SW Toeplitz calculation +reta table) however > > The reported rss value is *wrong* in the mbuf > > (m->hash.rss == *wrong value*) > > Are you getting same result with both scalar and vector driver? > > > ((m->ol_flags&PKT_RX_RSS_HASH) == PKT_RX_RSS_HASH > > > > 5) The above works fine for mlx5 and ixgbe > > > > 6) I suspect the hash is something else, maybe flow-director id or xor hash .. > > > > Wanted to know if this is a known issue. I can provide a simple way to reproduce it using TRex > > > > Thanks, > > Hanoh > > > > > > -----Original Message----- > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Thursday, March 22, 2018 1:35 PM > > To: Hanoch Haim (hhaim) > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] i40e mbuf->rss indication > > > > On Wed, Mar 21, 2018 at 06:47:22PM +0000, Hanoch Haim (hhaim) wrote: > >> Hi All, > >> DPDK:17.11 > >> When i40e is configured with RSS enabled and hash.type=toeplitz > >> > >> m->hash.rss = some weird number > >> ((m->ol_flags&PKT_RX_RSS_HASH) == PKT_RX_RSS_HASH > >> > >> The hash value is correct and match the MS Toeplitz standard. > >> > >> Is this expected? > > > > I'm sorry, but I don't quite follow the question, or the problem. Are you meaning to say that the hash value is incorrect, or that the flag is not being set or something else? > > > > /Bruce > > > >> > >> The above works fine with ixgbe/mlx5 > >> > >> Thanks, > >> Hanoh > >> >