From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 17F16354D for ; Mon, 26 Mar 2018 11:34:47 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id p9so1580848wmc.3 for ; Mon, 26 Mar 2018 02:34:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CAoJzpKJoQo0ueAEz7JlktOYLO2kXYOim+mzBhEG+9Y=; b=WCMsVKG6DES29sY3WKXak+ehInfwqNfHqHh68BoPIWOW1iQmRg90GKRV5iTxg9scUE KaYAZuAzK86jilH6ghXZv1qxgleHUw5V/YN64piCuPSv7dChpsBXYoI7aE+n98AxMt9g bHDSu7mcebKg3CKwNdqf9wNpVvjowaG1DXdQb19UvYEVd9wa46ZJ6iJI+goX7254d6k3 JxTjd+7j7RTfRKGg9xJ+RyZXoNoqfMNWB+pkmyga01s9x47pyfTxIaEzxtLW6Jg8J/Pe RCGe54zH9u8gyqj97mMEoVdX6JZue0wUqBOwkzCh3GeBIkSEP02G3MTz9GxyjCYB4sIZ CzcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CAoJzpKJoQo0ueAEz7JlktOYLO2kXYOim+mzBhEG+9Y=; b=ErkGwCdaLxRrQ6yM6als63b6lq8GCoJUbSYO7uhLOKlzzz7VStnt/rYmuL3B5AmUik CgUIqqJthtzvxt+84imGBWAng0dL0Hjlhqr9PK4+eE6Kz9caOjyAL1T0sAqGP74LAgZr YRBMxvdmW6cn5Km6nyof9XvBGzZjyUL/ay6iUn+0rFoqN/1TKXlFFOwubLoK87hVtJD+ x89UrV7cpa36YRZ5dX4hOvA9QR77Vt+wzi27+k7V9WOyYUlaCux+aUbwlc1MuRVUdc2L JJBcODExiAvKU9UFe0TSwmv8bRvMTsjXxjEtJJl0RLlLEHdPXJ6FtPwrS5/3mEmiw6tl lHWA== X-Gm-Message-State: AElRT7GPPXhHDaGv/cOoHTebxq+S0f9oXRgCWPR+B39IbrviQtpoWDv/ xFpTTQrb+7UJKOg7ZHEDg3z4xQ== X-Google-Smtp-Source: AG47ELsKaWg7/ypo9OVZEOUtESw03gFe9fNDgDlRO0MRdtejA4IteMpEovqNORptcxCljZfP6LqpIQ== X-Received: by 10.28.142.1 with SMTP id q1mr16327370wmd.0.1522056886756; Mon, 26 Mar 2018 02:34:46 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f14sm15630363wmi.11.2018.03.26.02.34.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 02:34:46 -0700 (PDT) Date: Mon, 26 Mar 2018 11:34:33 +0200 From: Adrien Mazarguil To: Ophir Munk Cc: dev@dpdk.org, Thomas Monjalon , Olga Shern , Shahaf shuler Message-ID: <20180326093433.GD4011@6wind.com> References: <1521477410-8936-1-git-send-email-ophirmu@mellanox.com> <1522009169-13860-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522009169-13860-1-git-send-email-ophirmu@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 09:34:47 -0000 On Sun, Mar 25, 2018 at 08:19:29PM +0000, Ophir Munk wrote: > Previous to this commit mlx4 CRC stripping was executed by default and > there was no verbs API to disable it. > > Signed-off-by: Ophir Munk > --- > v1: initial version > v2: following internal reviews > v3: following dpdk.org mailing list reviews Except for the remaining extra space mentioned below :) Acked-by: Adrien Mazarguil > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index ee93daf..eea6e93 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -562,7 +562,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) > (device_attr.vendor_part_id == > PCI_DEVICE_ID_MELLANOX_CONNECTX3PRO); > DEBUG("L2 tunnel checksum offloads are %ssupported", > - (priv->hw_csum_l2tun ? "" : "not ")); > + priv->hw_csum_l2tun ? "" : "not "); > priv->hw_rss_sup = device_attr_ex.rss_caps.rx_hash_fields_mask; > if (!priv->hw_rss_sup) { > WARN("no RSS capabilities reported; disabling support" > @@ -578,6 +578,10 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) > } > DEBUG("supported RSS hash fields mask: %016" PRIx64, > priv->hw_rss_sup); > + priv->hw_fcs_strip = !!(device_attr_ex.raw_packet_caps & > + IBV_RAW_PACKET_CAP_SCATTER_FCS); I know the extra space before IBV_RAW_PACKET_CAP_SCATTER_FCS is present in the original mlx5 code, but it's misaligned there also. This line should be aligned with "device_attr_ex.raw_packet_caps" for consistency. -- Adrien Mazarguil 6WIND