From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gaetan.rivet@6wind.com>
Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com
[209.85.128.194]) by dpdk.org (Postfix) with ESMTP id C22632A66
for <dev@dpdk.org>; Tue, 27 Mar 2018 11:53:33 +0200 (CEST)
Received: by mail-wr0-f194.google.com with SMTP id l49so12602133wrl.4
for <dev@dpdk.org>; Tue, 27 Mar 2018 02:53:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:content-transfer-encoding:in-reply-to
:user-agent; bh=pcXdHVbtizzvuyDocjm1V7R6PfBvyu76rin5YPXIsYU=;
b=n1pC/TTxMhFapwwWF7qWaJPLsLv+9ZIHmogUCbd81SpXTvWNnU26zNCos8WZSIodeS
H45v2gaktbH10Ludz2VmlB8TAoD110faPjZxsXRbdxi31CHUo5zSk8KpTaQ0xSW+CH4T
c5zBIfLGYkoBbkyCzEyaAHm3aR/6vcyUApDdLvfWvIyKkcC4Q6XZ+idMDpc2ZrurxKUY
0YaUBJqkss7i+67+FIUw7T4RMDTQmWNwiyQjqmRP3/Ji/jGi4s087x7QCylJM6yVhJoZ
DgktRz5HtMlro3x39dcmSDnR6pzSbZkcC0Cn64HRcZ6e30F2tmsRPlFvvPTX5k7bc2Ln
WZbQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:content-transfer-encoding
:in-reply-to:user-agent;
bh=pcXdHVbtizzvuyDocjm1V7R6PfBvyu76rin5YPXIsYU=;
b=Nc84RlRA9VFcC9ABxEeqbm6diMsS5DBZL1Djph4A4IaHhNTslrmHRPKPCm/nnJVUxl
BZBZYlHdpSqD7D/AjtaWS5YaHLqdRTvwbnP3TvA9nH4U051kdVJjsE0+uXvPmkMGbWpH
jXb6xL3IVavyYYcE4aOBw+nuQYBAYNKLXiHF73BguQDinkhTg8VDtJiGAxWDJmf6CmP+
Ae73+w0GKFZOQUNzrBjAir8FDbGKSS/UJUbH1ILyVg7UPEWJzrSY+QuGTMhXLs9YsJ0a
NLvcuzCpkI450JzYCYwBJd8ehg9o2SqqeqCMVhmDK/OFD92UO8wCvkqyI2xhik7FFoZJ
H9gA==
X-Gm-Message-State: AElRT7GacXaBz5uOS6HiycvQpp3LhmkkchOVHgSaPU+npGfmJg3/Y2vA
5eaXFuz8BtmjYm3gAobDwl5b5UOL
X-Google-Smtp-Source: AIpwx48qP7Uq+qRzvi6SE7nr+yqc/wiZEul2g0N5Iva7UcU4ZY8xErREfCzBeMMQx8CS9aYsCPIwjg==
X-Received: by 10.223.156.206 with SMTP id h14mr714892wre.281.1522144413359;
Tue, 27 Mar 2018 02:53:33 -0700 (PDT)
Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com.
[62.23.145.78])
by smtp.gmail.com with ESMTPSA id f22sm2604908wmi.39.2018.03.27.02.53.32
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 27 Mar 2018 02:53:32 -0700 (PDT)
Date: Tue, 27 Mar 2018 11:53:19 +0200
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Message-ID: <20180327095319.43ixbh5ozqgtfq74@bidouze.vm.6wind.com>
References: <cover.1522105876.git.gaetan.rivet@6wind.com>
<996543406679ba5e61341a71c030f06dd83f4ccf.1522105876.git.gaetan.rivet@6wind.com>
<20180327091220.GA23992@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180327091220.GA23992@bricha3-MOBL.ger.corp.intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v3 02/20] kvargs: build before EAL
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Mar 2018 09:53:33 -0000
On Tue, Mar 27, 2018 at 10:12:20AM +0100, Bruce Richardson wrote:
> On Tue, Mar 27, 2018 at 01:18:26AM +0200, Gaetan Rivet wrote:
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > ---
> > lib/Makefile | 3 +--
> > lib/librte_eal/common/Makefile | 2 +-
> > lib/librte_kvargs/Makefile | 2 +-
> > lib/librte_kvargs/rte_kvargs.c | 3 +--
> > lib/{librte_eal/common/include => librte_kvargs}/rte_string_fns.h | 0
> > 5 files changed, 4 insertions(+), 6 deletions(-)
> > rename lib/{librte_eal/common/include => librte_kvargs}/rte_string_fns.h (100%)
> >
> Don't forget to update the meson.build file. You need to move kvargs before
> EAL in the list of libraries, and modify the special case for
> default dependencies for non-EAL libs.
>
> /Bruce
Sure, I will tackle meson build once everything is a little more stable.
I'm not at all convinced by this librte_kvargs move, these two patches
are verging on RFC.
Once I know where everything will be, I will complete the build support.
--
Gaëtan Rivet
6WIND