From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7BF277CFC for ; Tue, 27 Mar 2018 22:26:20 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 13:26:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,368,1517904000"; d="scan'208";a="186507951" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.9.99]) by orsmga004.jf.intel.com with SMTP; 27 Mar 2018 13:26:13 -0700 Received: by (sSMTP sendmail emulation); Tue, 27 Mar 2018 21:26:12 +0100 Date: Tue, 27 Mar 2018 21:26:12 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Andrew Rybchenko , dev@dpdk.org Message-ID: <20180327202611.GA16780@bricha3-MOBL.ger.corp.intel.com> References: <1521545187-27096-1-git-send-email-arybchenko@solarflare.com> <1521545187-27096-2-git-send-email-arybchenko@solarflare.com> <1793816.7vs2QY3WLW@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1793816.7vs2QY3WLW@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 01/13] net/bonding: fix library version in meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 20:26:20 -0000 On Tue, Mar 27, 2018 at 06:43:48PM +0200, Thomas Monjalon wrote: > > --- a/drivers/net/bonding/meson.build > > +++ b/drivers/net/bonding/meson.build > > @@ -2,6 +2,7 @@ > > # Copyright(c) 2017 Intel Corporation > > > > name = 'bond' #, james bond :-) > > Ah ah ah, I had missed this important comment! > > Unfortunately I think the real name is "bonding". > Does it mean the full name should be james bonding? > Nope, the name of the driver when built is "bond", according to the old build system anyway. The name of the directory is "bonding", hence the override here. ls x86_64-native-linuxapp-gcc/lib/librte_pmd_bond* x86_64-native-linuxapp-gcc/lib/librte_pmd_bond.a Ideally, I'd like to be able to get rid of that "name" parameter entirely, if we can just rename all directories to match the driver names exactly. In this case, if we do want the driver to be called librte_pmd_bonding.a/.so, then we just remove this override. /Bruce