From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <olivier.matz@6wind.com> Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id B80392C18 for <dev@dpdk.org>; Wed, 28 Mar 2018 10:24:33 +0200 (CEST) Received: from lfbn-lil-1-702-109.w81-254.abo.wanadoo.fr ([81.254.39.109] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from <olivier.matz@6wind.com>) id 1f16OG-0002sn-6Z; Wed, 28 Mar 2018 10:25:05 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Wed, 28 Mar 2018 10:24:27 +0200 Date: Wed, 28 Mar 2018 10:24:27 +0200 From: Olivier Matz <olivier.matz@6wind.com> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net> Message-ID: <20180328082427.4agrvcn3hgywwlbu@platinum> References: <20180227151129.30387-1-olivier.matz@6wind.com> <b06a8115-11c3-20f6-d3c5-88aaf68400f2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <b06a8115-11c3-20f6-d3c5-88aaf68400f2@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 28 Mar 2018 08:24:33 -0000 Hi Ferruh, On Mon, Mar 26, 2018 at 07:39:00PM +0100, Ferruh Yigit wrote: > On 2/27/2018 3:11 PM, Olivier Matz wrote: > > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > > return code is added to notify the caller (librte_ether) if an error > > occurred in the PMD. > > > > The new default MAC address is now copied in dev->data->mac_addrs[0] > > only if the operation is successful. > > > > The patch also updates all the PMDs accordingly. > > > > Signed-off-by: Olivier Matz <olivier.matz@6wind.com> [...] > ethdev part looks good to me. > Are you planning to have another version for mrvl and sfc comments? > > PMD maintainers, please check and provide feedback for your PMD, otherwise the > patch will go in as it is. Yes, I'll send a new version adressing the comments as soon as possible. Thanks, Olivier