From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rahul.lakkireddy@chelsio.com>
Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])
 by dpdk.org (Postfix) with ESMTP id 22D121E35
 for <dev@dpdk.org>; Wed, 28 Mar 2018 11:30:04 +0200 (CEST)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id w2S9U0nl020177;
 Wed, 28 Mar 2018 02:30:01 -0700
Date: Wed, 28 Mar 2018 14:59:12 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Kumar A S <kumaras@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>,
 Indranil Choudhury <indranil@chelsio.com>
Message-ID: <20180328092911.GA19730@chelsio.com>
References: <cover.1520720053.git.rahul.lakkireddy@chelsio.com>
 <af9d1a4f-41fe-7fbf-9348-7a6d71d581cf@intel.com>
 <20180327070155.GA17402@chelsio.com>
 <DB7PR05MB44262EF3F2DD367CB0CD2D2DC3A30@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <20180328073933.GA19600@chelsio.com>
 <DB7PR05MB44261D37B2501F5CADDB3255C3A30@DB7PR05MB4426.eurprd05.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DB7PR05MB44261D37B2501F5CADDB3255C3A30@DB7PR05MB4426.eurprd05.prod.outlook.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Mar 2018 09:30:05 -0000

On Wednesday, March 03/28/18, 2018 at 14:00:58 +0530, Shahaf Shuler wrote:
> Wednesday, March 28, 2018 10:40 AM, Rahul Lakkireddy:
> > On Wednesday, March 03/28/18, 2018 at 10:19:17 +0530, Shahaf Shuler
> > >
> > > What exactly is the offload you try to expose? To strip the inner VLAN while
> > keeping the outer one?
> > >
> > 
> > Sorry about that, I should have provided more details on this earlier.
> > Chelsio hardware supports below for double-vlans:
> > 1) Dropping Outer VLAN in hw; inner vlan is stripped and available as packet
> > metadata.
> 
> So this is basically the DEV_RX_OFFLOAD_QINQ_STRIP with limitation from your device you cannot return the outer vlan in the packet metadata
> 

Since this is specific to Chelsio devices, is it better handled by
devargs approach instead? We will respin this particular patch
separately.
 
Hi Ferruh,
Should we re-post the entire series minus this particular patch?

> > 2) Preserving Outer VLAN so, Outer VLAN is stripped and available as packet
> > metadata. Inner VLAN is available as part of packet itself.
> 
> And this one is the regular DEV_RX_OFFLOAD_VLAN_STRIP
> 
> > 
> > So, the configurability here is with respect to Outer VLAN and subsequently
> > what is available as part of packet metadata (outer or inner vlan).  Inner
> > VLAN gets retained in both cases.  However, based on how Outer VLAN is
> > configured, Inner VLAN will be available either as packet metadata or as part
> > of packet itself.
> > 
> > We are not very sure if DEV_RX_OFFLOAD_QINQ_STRIP could be used here.
> > If it holds the same meaning then we will use the same.
> 
> Yeah , we are missing good documentation of what each offload means. 
> > 
> > Thanks,
> > Rahul