From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id EDA652B9D for ; Wed, 28 Mar 2018 14:54:48 +0200 (CEST) Received: from lfbn-lil-1-702-109.w81-254.abo.wanadoo.fr ([81.254.39.109] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f1Abr-0003XJ-33 for dev@dpdk.org; Wed, 28 Mar 2018 14:55:24 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Wed, 28 Mar 2018 14:54:46 +0200 Date: Wed, 28 Mar 2018 14:54:46 +0200 From: Olivier Matz To: dev@dpdk.org Message-ID: <20180328125446.7r7y4xlz6r37hyo6@platinum> References: <20171208102657.2699-1-olivier.matz@6wind.com> <20180227144630.29613-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180227144630.29613-1-olivier.matz@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 0/4] fix control thread affinities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 12:54:49 -0000 Hi, On Tue, Feb 27, 2018 at 03:46:26PM +0100, Olivier Matz wrote: > Some parts of dpdk use their own management threads. Most of the time, > the affinity of the thread is not properly set: it should not be scheduled > on the dataplane cores, because interrupting them can cause packet losses. > > This patchset introduces a new wrapper for thread creation that does > the job automatically, avoiding code duplication. > > Olivier Matz (4): > eal: use sizeof to avoid a double use of a define > eal: new function to create control threads > eal: set name when creating a control thread > eal: set affinity for control threads > > drivers/net/kni/Makefile | 1 + > drivers/net/kni/rte_eth_kni.c | 3 +- > lib/librte_eal/bsdapp/eal/eal.c | 2 +- > lib/librte_eal/bsdapp/eal/eal_thread.c | 2 +- > lib/librte_eal/common/eal_common_thread.c | 70 ++++++++++++++++++++++++++ > lib/librte_eal/common/include/rte_lcore.h | 26 ++++++++++ > lib/librte_eal/linuxapp/eal/eal.c | 4 +- > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 17 ++----- > lib/librte_eal/linuxapp/eal/eal_thread.c | 2 +- > lib/librte_eal/linuxapp/eal/eal_timer.c | 12 +---- > lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c | 10 +--- > lib/librte_eal/rte_eal_version.map | 1 + > lib/librte_pdump/Makefile | 1 + > lib/librte_pdump/rte_pdump.c | 13 ++--- > lib/librte_vhost/socket.c | 7 +-- > 15 files changed, 123 insertions(+), 48 deletions(-) Any comment about this patchset? Thanks, Olivier