From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 0DD6C4C8F for ; Wed, 28 Mar 2018 17:09:55 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id r131so5977458wmb.2 for ; Wed, 28 Mar 2018 08:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=R++jKjROizGN5E+8kf95iNcl8HQrumsljcxG3cX2Pfs=; b=xgiUuII2c6M30/M/ugdheiFQsfJivNTP4J74bLJEkqZ1tdRgAbOQmXu2IlSIoDEsnB 09ZSw2KgnYzfYoi9BSFV03S3xCP4DmhAwwTo1As/kJbVGjfP5uTkD0oUbKsE7zYZFvcc IPOmWbNSS0CNCz55vi6Ny4ySa51CTKyBfNsa8AXZRphP35gfCpM0zX+KmHjqZ2hcWWkL lMkevayBdeBVMyhScrtzlmM6+ZAH8jqV91bVf/KjePTxl0hh6+RbYbv10wGQemZwUPHj povxGzdEuLALjsjwPozCD6EOODlsFadzYld1h8eZJvV1z0VHGiVEkEsUCizDMfp4Wuy+ y9sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=R++jKjROizGN5E+8kf95iNcl8HQrumsljcxG3cX2Pfs=; b=iuO5u+Eckbj318aRu8aMLuAKwg5M8AHNCnRw6Wkm5f2mvDlCqmxpG6s0ZFOB17w/Hp FPY9Kcbohraf0OyyIs8j/aHylPPNs1oGRnwohdBZ7dsYpZPrXXasV9ExGUWDIhMYbDr6 6kNgB2OyxTvkAWdq+XF0AsNBEIH+Gs3sUzuG1GHk99fQpuKWyEAlev+0AdeezL+a7CPm T7jpl4vQTHCn/ZZELfa9qkxjb+zXh3AwOTMmMVbZB5SFXtseCcUQI24m5DWKlox8RcSw jLaRYjMFuNKGxoNoZRCwf1nLthRWhhmMjMEBZ7m1XGgVhIl+f/T+JcgWqZ4zJDYrVW5R 2aYQ== X-Gm-Message-State: AElRT7Ho+/EUOHId/DtUBeKw9V907A/h55efbisutEjMZqXDPJteBirm SzhaZhXBzmMcMP5mDZED6J2M X-Google-Smtp-Source: AIpwx4/IjaAUIUYJPtFKnbRoJeBr+LQknYKjx+TC8sUm9j6MxtODEbxuSmJCBgzRyLMxTqkLWpr43A== X-Received: by 10.28.236.76 with SMTP id k73mr2062988wmh.122.1522249794772; Wed, 28 Mar 2018 08:09:54 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a185sm4559863wmf.24.2018.03.28.08.09.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Mar 2018 08:09:54 -0700 (PDT) Date: Wed, 28 Mar 2018 17:09:43 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: Shahaf Shuler , Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20180328150943.ughfvwa2p5a4hvgi@laranjeiro-vm.dev.6wind.com> References: <7aeb54018d1a8dd06638632076f25fbc88945afd.1518686582.git.nelio.laranjeiro@6wind.com> <07145c9505263ba30de44a5c5186431935b98884.1520950386.git.nelio.laranjeiro@6wind.com> <6b81cc53-f6a5-a5e8-0972-16da937644ab@intel.com> <3e8d0155-ed53-07cc-6344-dfdce1a8b159@intel.com> <20180328113419.g3rmsgcuzn2hpudf@laranjeiro-vm.dev.6wind.com> <5b296774-aec3-b600-e215-7756579654ec@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5b296774-aec3-b600-e215-7756579654ec@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] net/mlx5: fix flow single queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 15:09:55 -0000 On Wed, Mar 28, 2018 at 02:16:44PM +0100, Ferruh Yigit wrote: > On 3/28/2018 12:34 PM, Nélio Laranjeiro wrote: > > On Wed, Mar 28, 2018 at 11:13:42AM +0000, Shahaf Shuler wrote: > >> Wednesday, March 28, 2018 12:05 PM, Ferruh Yigit: > >>> On 3/21/2018 6:45 PM, Ferruh Yigit wrote: > >>>> On 3/13/2018 2:17 PM, Nelio Laranjeiro wrote: > >>>>> The flow is created with any steering being applied in the NIC when > >>>>> the device is handling a single Rx queue. > >>>>> > >>>>> Fixes: cede123a158f ("net/mlx5: fix flow creation with a single > >>>>> target queue") > >>>> > >>>> This patch is from current release and still in next-net. If it is > >>>> possible to split this patch to fix issue in this particular commit it > >>>> can be squashed into original fix. > >>> > >> > >> We can say it only fixes the above and squash the commits. > > > > Indeed they are fixing the same issue. > > Can you please confirm it is safe to squash this commit [1] into [2]? > > [1]: ebfe9a38cb47 ("net/mlx5: fix flow single queue") > [2]: cede123a158f ("net/mlx5: fix flow creation with a single target queue") I confirm, [1] is a fix fixing a bug introduced in [2]. Both are needed to fix the same bug, they should be squash in a single commit. The confusion came from the fact commit [2] was already integrated in shshaf's branch, when the issue was raised using another scenario. Sorry for the confusion. > >>> Cc'ed Shahaf. > >>> > >>>> > >>>> If not commit id for fixes will be wrong and needs to be fixed when > >>>> merged into main repo. > >>>> > >>>>> Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS > >>>>> flow") > >>>>> Cc: stable@dpdk.org > >>>>> > >>>>> Signed-off-by: Nelio Laranjeiro > >>>> > >>>> <...> > >>>> > >> > > > Regards, -- Nélio Laranjeiro 6WIND