DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com,
	Darren Edamura <darren.edamura@broadcom.com>,
	Rahul Gupta <rahul.gupta@broadcom.com>,
	Scott Branden <scott.branden@broadcom.com>
Subject: [dpdk-dev] [PATCH v3] igb_uio: bind error if pcie bridge
Date: Thu, 29 Mar 2018 09:37:35 -0700	[thread overview]
Message-ID: <20180329163735.51606-1-ajit.khaparde@broadcom.com> (raw)

From: Darren Edamura <darren.edamura@broadcom.com>

Probe function should exit immediately if pcie bridge detected

Signed-off-by: Darren Edamura <darren.edamura@broadcom.com>
Signed-off-by: Rahul Gupta <rahul.gupta@broadcom.com>
Signed-off-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
----
v1->v2: add a log message if the condition is true.
v2->v3: rebase against latest dpdk-next-net tree.
---
 kernel/linux/igb_uio/igb_uio.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c
index 4cae4dd27..cbc5ab63a 100644
--- a/kernel/linux/igb_uio/igb_uio.c
+++ b/kernel/linux/igb_uio/igb_uio.c
@@ -473,6 +473,11 @@ igbuio_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
 	void *map_addr;
 	int err;
 
+	if (pci_is_bridge(dev)) {
+		dev_warn(&dev->dev, "Ignoring PCI bridge device\n");
+		return -ENODEV;
+	}
+
 	udev = kzalloc(sizeof(struct rte_uio_pci_dev), GFP_KERNEL);
 	if (!udev)
 		return -ENOMEM;
-- 
2.14.3 (Apple Git-98)

             reply	other threads:[~2018-03-29 16:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 16:37 Ajit Khaparde [this message]
2018-03-30 10:34 ` Ferruh Yigit
2018-04-11 21:36   ` Thomas Monjalon
2018-04-16 15:35 ` Ferruh Yigit
2018-04-16 20:51   ` [dpdk-dev] [PATCH] igb_uio: only check for pci bridge in supported by linux kernel Ajit Khaparde
2018-04-17  9:35     ` Ferruh Yigit
2018-04-17 12:58     ` Iremonger, Bernard
2018-04-17 13:33       ` Ferruh Yigit
2018-04-17 13:49         ` Iremonger, Bernard
2018-04-17 17:52           ` [dpdk-dev] [PATCH v2] igb_uio: only check for pci bridge if " Ajit Khaparde
2018-04-17 18:07             ` Ferruh Yigit
2018-04-20  9:08               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329163735.51606-1-ajit.khaparde@broadcom.com \
    --to=ajit.khaparde@broadcom.com \
    --cc=darren.edamura@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=rahul.gupta@broadcom.com \
    --cc=scott.branden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).