From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02hn0203.outbound.protection.outlook.com [104.47.38.203]) by dpdk.org (Postfix) with ESMTP id E062D4F9A for ; Fri, 30 Mar 2018 19:24:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=t4tWlArSdMXZ8sdLL0l6OeYG/yX5IODvFKqKGtyjpsM=; b=HuqlF92/pb/iwLxHK23AERsr+/aRCqP7tfgrhYOLr7FiwWP0uDAcl5NuSupr7NV44BIJ5sWhMCMPA1mQtGFpoChZNMld2bUC3rq5U5xfRoM4cx53aVDtv6TWb1stNHUc392JJF5aYT5fgvJPwRv/c0UKsYS2exrBz51ZKJDSq1o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (103.16.71.47) by MWHPR07MB3470.namprd07.prod.outlook.com (2603:10b6:301:63::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Fri, 30 Mar 2018 17:23:58 +0000 Date: Fri, 30 Mar 2018 22:53:37 +0530 From: Pavan Nikhilesh To: Thomas Monjalon , jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com, lironh@marvell.com, bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com Cc: dev@dpdk.org Message-ID: <20180330172336.GA3184@ltp-pvn> References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com> <20180326075344.2209-1-pbhagavatula@caviumnetworks.com> <20180326075344.2209-2-pbhagavatula@caviumnetworks.com> <1810472.xOB8M7Gf6E@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1810472.xOB8M7Gf6E@xps> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [103.16.71.47] X-ClientProxiedBy: SG2PR0401CA0006.apcprd04.prod.outlook.com (2603:1096:3:1::16) To MWHPR07MB3470.namprd07.prod.outlook.com (2603:10b6:301:63::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a42aef68-e539-430a-8da0-08d59663070a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:MWHPR07MB3470; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3470; 3:wxo4BYRv5g2ctYpSwVKnI57FtBsie9uGUCjpYvCBwp5Jh/Im+HqsppaMmonEs68O1tNSG8QfLDZ4Vh2zuPVJkPSCis5gv6Q22LAbDd+SYm17MWH/aE2YRYL3zcPzCdghupNkT7m8EAyFOHWXmM2/5D8fKm86OwYofwkbxbGGCwT7VFUqeDVmcgbFSDuwtxpGR4LJHOsADGCCvnx0A6TV5suVRmbNtmPfMTQ+9SLSjSjEKITaC2hLp5JLEFPowZS5; 25:JBVVA3LQ+Ga5kU4jAnu7JoQ/+pvdVDPWi3cLBp/mv3gq7wOiXDPsQaZ65pX7v6kZgknqQah4ny/lwouWEqXkGN+kvjV63yBYoawG6FCUB3I/7GzVUbK3akhKLazajCLcKgYfTeBFrPUP26JBdTbtDuFTJNha2Gcgz9wp3gmaeFHWS+xZScxz233dm4stU5hgfBhPoMrNJqkiX56GoavLGNY1ivjF+cCx0t5gHe3qSNYggiYhCRBHFcj0+GNsUj15Vx07oBWcTGwonkescLc5wBfIiGV+MryvfjF45dkYKIBpa7cefWmep8x6CkQbWbL7ViN6WTBVkbWJ376oRSrTlg==; 31:gSavTnS7agdnoE5t1SwtSuUR/kS2Rr77jAhP/0gEMqKNnqi+WhLN8jC4mBAkgIPjrgcGuTB2gVd1y1HtDFoPvjQTi6cAvLKf9fqvIF8XgiupimgG2YBN04V2sdjObWHH070B2Pv3kHimUJHabAiv/svhunl13wN0oH0/EvxfYijrukuWS80oNh8ux5VNB6pmkTTgJ5qVtnlWIUR4oJd6il6EschdN0Pk/BH0wRFm5qc= X-MS-TrafficTypeDiagnostic: MWHPR07MB3470: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3470; 20:jhLHxfy0I48WnsXx8uB8e10WhMvJv7A54ymvs9jUsvTGvRaDpsqHDUT6Y0OOB712hFY92zisfGoq/nQRypWAkFm5/KprUlzX/syNP9BmxLHEeZD/dWRFYf+Wuxv3/VRKUp6AW9yK+wrwVOrgBlADhpRwnonLMY+zcjZC8s171N0P/1QlF9DQcQ+XwlWHzmegR1pnmoS/B9vmZ65l65GEoiNhmim5b7raf2fggC9T9DkScfSVWhhc3U72TXAPwy2p/+d0bp0X/+K6RGh9llYE+Z7UABNaPrSm4xPwvCWEvYdZQa5hnyOtzMtuVouc39PMcrI9yvDD0BJVNc2R7OJ+FTGsc19pOHk57+erDjhc9oGmRE/uu6OQxpTNJDZTIJU3NVCowxOwB3l0WR/QVc7P0Lk1fbo50UnhS6L0hdi/4lNhCypfGGOhg+sFt3KsQpdlgU37KNza2iquSRnGH4MTKuB0V/hyMgBHkT/uYgdaPQEALWHwgo/Uk2m5Nhpi1lQUGtuVtUe3d0JqvKZmuF19ZYg1N0G4VkglaH6igFQEAwjXftJHhKPg6Lu73sAOa+Ki9hSUpUVOP/8JI0F6+cXxub4/880mCQqof2XwHSnxBLY=; 4:mPibqQq/T50t7u4F7gi5KVSqELAkJRtiN4y0jNSwahEAIJPRgg+VElas4n6TLAukHvyMsPvgP9ixKfa8rtGZyYHkfWGqFAg0fv29H2nx29GBYjR7HjD55pMXT1Hi7fjsiqwneg1K+CaRw8jePoT77ONa0nA3DvM2KSHkhLK4oCp0o0Zh/q6kaHcGdRkNcDvSS8zu/mpWvWbJTMA5qbGisuCC5lxtiGMNnOZwApcRCgrgW6SmN53bnVx88lJXDPC2CfrdqK6g96MnWF7fIcB2jL8VsdQv50PQPUmpDPf8r39wxDr34vdVN0yh7ojT9gff X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(66839620246622); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(3002001)(3231221)(2232076)(944501327)(52105095)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:MWHPR07MB3470; BCL:0; PCL:0; RULEID:; SRVR:MWHPR07MB3470; X-Forefront-PRVS: 06274D1C43 X-Forefront-Antispam-Report: SFV:SPM; SFS:(10009020)(39380400002)(366004)(346002)(39860400002)(376002)(396003)(51914003)(199004)(189003)(4326008)(72206003)(316002)(33656002)(68736007)(229853002)(8656006)(386003)(16586007)(478600001)(59450400001)(33716001)(50466002)(58126008)(6496006)(93886005)(25786009)(33896004)(52116002)(76176011)(106356001)(7736002)(305945005)(66066001)(47776003)(105586002)(2906002)(55016002)(9686003)(186003)(53936002)(6246003)(26005)(16526019)(5660300001)(956004)(11346002)(23726003)(446003)(1076002)(486005)(486005)(3846002)(6666003)(476003)(6116002)(81166006)(42882007)(81156014)(8676002)(97736004)(8936002)(59010400001)(18370500001); DIR:OUT; SFP:1501; SCL:5; SRVR:MWHPR07MB3470; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3470; 23:fqph55I1Xu4k84epQXYh3/7N4t+8+xifnxLTaCn6Q?= =?us-ascii?Q?1JivrthbVGfhcxgQ0i5uHlAlXoC4NhzzrkpcuTrjBcVUhw0hceeDD3TLEt0n?= =?us-ascii?Q?cO7HxZBx8SYqIUPYR/CYeZby0Ita7rbg3nJAiMFN2Ieg/SE86PicrX85nRQe?= =?us-ascii?Q?nSQ1pizh3WEQLP2UF2FNzHyWg2Ibb6bQQMMmtsHqlewn7/3d2UHNtPoDotww?= =?us-ascii?Q?/dy8MqqZwtzOfRVfA4GnCB9i/IF52SoP7gpzGqro5kJyjBp+Qd5ualNAVdR7?= =?us-ascii?Q?eh+7AWmZ19uCRTlqnwA6gAcWdTA/IAIYO7Uj8ClGcb2DKbnSJAxF8qEcTgKc?= =?us-ascii?Q?NIbDCJyKvJK/A0OE2QlE9voV/mW6rN987Nr+XM5Wrx+2FlsITt0ahSHRByHY?= =?us-ascii?Q?s0h/PO5T2I3VbfO/K17VHwBFz1vn1CHlFfAHqyXwYtOTr7eix5OaR5Si7Gfk?= =?us-ascii?Q?DZ30g7TWR5jTgeJP5ZHLeUo1GuCx0rPPjPI+QOZsbyn2BQRJqIHm2H3q/Rad?= =?us-ascii?Q?LUw9ebrblTUeLrv+Wi/zfC0W3i7WAq3bLefxRTLhsxuGT5axrpXSd7fVsqYE?= =?us-ascii?Q?JDcvAJ4s8uTOOeeCCxlGvjtRbchbuR77+v4TNpBA02I2sCJnuFzdUgnBXkBw?= =?us-ascii?Q?NKaFmEjS3AsI6omIGK0AP4DCoKISErEFPrWLBGg7HsoLKG9/uJB7WefHeeH/?= =?us-ascii?Q?u4JnsQdM/byYEf0MVfn62geYrhR40FO6NvoJKvlvb20/+vOfDgEMpvX/Fz5N?= =?us-ascii?Q?FEGGxtXFpBMTvVmbFSqcErDZQ1gltKVOpPw6X7DJyGcrmHUBQZLzh3jelsr4?= =?us-ascii?Q?hfk9T+DBMtKIDVCrhhi4K/9ojaJNvI6PxTEd7sI+Rxuz4jDnyHCCSetwG9Im?= =?us-ascii?Q?ve926poAbQwDzoI1hUpvQDB8FCqM3guDBKHzZEXBICTd4xE/+QMRIPzItFnQ?= =?us-ascii?Q?I6qxN7OCYFPEDUapg67oXCK9+llS11wP9zjAT5wPvYUlWruTVoVrzMMkbLGX?= =?us-ascii?Q?1JB/erQy2FMwYhXgz4Fd2PIpRueUd54KwCDDiRExyLT7lW2MCU/V5sV0QbNL?= =?us-ascii?Q?Ei9rK/WboZE6VihHhn7h0AOAp4W7i5CGPznouqarJUVsXzhJ+Fjqm4dei3HI?= =?us-ascii?Q?dOjd3sACePQZIivbmj6GkEQLzIzr6x2vrQqyvYQZlDwMurCfH7KeuXYbRzqH?= =?us-ascii?Q?2/sUAG6v60cvRi7bKIPGLvvIpJVNVQiNCzoPphZAvXaAM8y6LfwfnqLtfxqM?= =?us-ascii?Q?hsD1ld6rBmLkTzEaQ1l1C8pHMP9do/zkvCg4F1C/d2UEumNJweVGZqkHdhJe?= =?us-ascii?Q?4uhNDIIF89rj4RZvdbl/CoTza+fxxQgPuUyrzPMdED4Za1pS6gDKMYuhpvSm?= =?us-ascii?Q?kDl4QudN/0WZlgOG9PZgzOZL9g6i7tigU/oIpOurOqaYpwv3gPDUc66rLGIP?= =?us-ascii?Q?ad0QS4KCcOjWMmhB0GxR6FiHgaXX6g=3D?= X-Microsoft-Antispam-Message-Info: zcAHB5JZgM1yjWpnxD3fqrxrVytEguPbFnxNXNTN3UsYNHQLuMlUbupiisVZt6vtDBnoQfYy4w1L+QEsZzkMwUA7GTNOwBf5XhNwig4kZAvGjJ/Iidry8Lisrwq1QPUKvjHvAKjCSnYjcN1ydZ5j0il2Tq5crTGPzJWxnwzte+P3WlscykkIAzqvfv7HRACT4hynrWbnFz8a9IOv0MpAaFT+o0KJoQSHoSFYDkjVWvs0jxHw/zgc4a/noS2h8+n7PdYn4mE7VhTngeGjUL4g1PSfhC7SWFfNyxcX7Qw5zEtD3hnDBewJahMWJ8YURsqRh9uLiz4+eZTxvn5GL9iTRe9U5TG/EEGtRo3Le8t69uqPJ41mUDxUnNtoRCTdjiHO3czSMhY63Rkcm9LHrt2q61Baklbbp4CxpEMIV9+P+RuKXO9K/kqPXfOgNDI1T/pCCJ/bnrP3ZRMG5O/He90EGhmyx9MOjORysmMpKTZh/ORcBAO2/zOTWGsyg+zHGhYT X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3470; 6:0UymvhCSo3VXJqfL6ADPZ7eUHltiw7PJMDovYf8rTjC5BhYFZI0Kgeq0u9/pPKYn190qKrvvVHXM+sot8gSWkXvx3k4pCZXtwrWsxfMC8u5z8UYifndYqNUBQkC5ANHPx6sxyXrnBGUHuW87OfzvzzVO4sEhDA5+eUYX7YPTvRCZQy3u+5sl4fJuF04NGWoMvvChpu8OtLUP3Iq6Qky2bBfjSPLIkm2+FOaenUR1kDUWsAAZgkH1GyaRWIEvvhd0UZKmJ4hKI2dC/+vpwBx1noa70nXuhBKydnVFBLkBAX3bbqnMIow3pQ5TPvLL1HDpL+N9AzWik5uGKBtG6WlVb75C0BsSeT5I5LD/KcfSS0+h4opmBeXiHtKmLDo7lORDusu0c5BcBf8iYfhE0x+sE/Qo0TkBMyuWy5b2PNCjzT2jGSSf0I0msSaEriMyDOIjssWtm6HRZDHX1k6f+tI+WebKIOk+mR877Oj1e0Dzia7KN0zhwG9zD+IZQa2LgWP0; 5:kobjigtw10h8WQIIbvahUe6C405ldMn5ocIFWC3mgy0qvjtwbjjQmz+JC/gdQ6IiwZJxe8whLKEfWm04Zu8aDB9k+/8ACN72XPsdJlJKg1l/kC3OyPwki1bO1kUVKVTi/kLgQcRpCxycYD2+HJjGsiEzYeiv6Bao1Rn+/8B1C8M=; 24:EB8fOteHVuaxc19XOJ0xkIASbxKHU48CC/jcXUtEGZLcApbuEFCqNjzKi6NFVXf60NLrvzWEntDronNX9XiDZg== SpamDiagnosticOutput: 1:22 X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3470; 7:h28uphh16PQglCUC1IphzNFAbpJpK0TUVklDel66CcbfPmk3vb7dNh2/uLcOp4vAYoLjETepyBHzXd8JYWV7OD7jL1t00xU/u9oXeanKjviEbOyYQs1QN5JoQaw6WhlDVgBOKF4lRdr6D4kIgM6XTxjinvzjQzSxPDDt78winw7vuY8W+u0ldCxupm7aW7o5JSDSzqSZk01IMeCkM7QvNU3G7s5qBZR44WuPcvPf/EvCY1M7fh3k54JfwLBx/VCg X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2018 17:23:58.0447 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a42aef68-e539-430a-8da0-08d59663070a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3470 Subject: Re: [dpdk-dev] [PATCH v3 2/2] octeontx: move mbox to common folder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 17:24:04 -0000 Hi Thomas, Thanks for the comments, will send out v4 soon addressing the comments. I have verified static and shared builds already and everything seems to be good. Pavan On Tue, Mar 27, 2018 at 06:15:56PM +0200, Thomas Monjalon wrote: > Hi, > > 26/03/2018 09:53, Pavan Nikhilesh: > > Move commonly used functions across mempool, event and net devices to a > > common folder in drivers. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/common/Makefile | 4 ++ > > drivers/common/meson.build | 1 + > > drivers/common/octeontx/Makefile | 24 ++++++++ > > drivers/common/octeontx/meson.build | 6 ++ > > .../{mempool => common}/octeontx/octeontx_mbox.c | 65 +++++++++++++++++----- > > .../{mempool => common}/octeontx/octeontx_mbox.h | 14 +++++ > > .../octeontx/rte_common_octeontx_version.map | 9 +++ > > drivers/event/octeontx/Makefile | 4 +- > > drivers/event/octeontx/meson.build | 5 +- > > .../{mempool => event}/octeontx/octeontx_ssovf.c | 20 ++++++- > > drivers/mempool/octeontx/Makefile | 5 +- > > drivers/mempool/octeontx/meson.build | 6 +- > > drivers/mempool/octeontx/octeontx_fpavf.c | 4 -- > > drivers/mempool/octeontx/octeontx_pool_logs.h | 9 --- > > .../octeontx/rte_mempool_octeontx_version.map | 6 -- > > drivers/net/octeontx/Makefile | 3 +- > > You need to update MAINTAINERS for this new directory. > > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -217,6 +217,10 @@ endif # CONFIG_RTE_LIBRTE_DPAA_BUS > > > > endif # CONFIG_RTE_LIBRTE_CRYPTODEV > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL),yy) > > +_LDLIBS-y += -lrte_common_octeontx > > +endif > > + > > ifeq ($(CONFIG_RTE_LIBRTE_EVENTDEV),y) > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV) += -lrte_pmd_skeleton_event > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += -lrte_pmd_sw_event > > It is strange to insert common lib in the middle of PMDs after crypto > and before eventdev, in the "static-only" section. > I think it should be just after bus libs. > > Please test static and shared library compilation. > > Thanks > >