From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id DF53E2BB1 for ; Mon, 2 Apr 2018 03:29:15 +0200 (CEST) Received: by mail-pf0-f182.google.com with SMTP id h69so8473286pfe.13 for ; Sun, 01 Apr 2018 18:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LsmCiEBKksPaj9Shv/1mYPg/kZDx3PHZtXuzH0I3QEY=; b=paUp6jA/M1/QWILWO2HzgF1nkDLNzlSf9reGT6U6jaLqncg+OCr54Ps1KLI8LVXg1l 3kM6Lqop/d2D8jBDitjdqM0sugm0Tris/B3TObPkaQNjYFDqvZ5h9imFoSiF8h5leyOY GQGJ4i9GJjAmEVTwl9QilBaMGP3N7NN7Q4Vt9uVosBLsWeEW1vb+un5k9bj2WrRKaGMx jx0hGr2h6CbC1rDvDucJVW1VkJIgfCMfe/mYZ0OJ2zhr4a/giUzpwGhEC0W1bipW9kXE /6AtPZPZDA+mZd/y+VtWV2GAQx4py6aVkRKWBkTubWP2UFTaM8PluwzOJIQ1W8ZQnC2g hwGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LsmCiEBKksPaj9Shv/1mYPg/kZDx3PHZtXuzH0I3QEY=; b=Td2y6MnpIZXjhPO9C5D/trYgMRptt/E7uZATLeifnCbXdw0oJRAzYf2fjLj8Kgfwgm 3UfqptcdgW/mB5ClkA50AGJrP6wQhuC8X0pYmhZJntdgV50/aM5Pk/Pz/Ss9sxHXu9KD qwcIu9IfSLM9s3nwxOlNDRjM4l6Pn+cQCjm50nGyKKCKstXq87CYISXO2ocwKu46V3fg 22LbNFX6q5nv9jTIn7T+6ISJhfgehrD3/rhYlhtf9rBF1cabMnmIOhf9d5lnile3ZFUD dRs7gqYXyav2rODIvvD+WJpX36GGGlyuc8eAqem7jT7DE4eUIbl0w9oHcq7FZcRl1JSD hUCg== X-Gm-Message-State: AElRT7GYVEqh2I6/ZkOMITErwmYWonSDPpF9ZHWbGI/y8PEEtI3EVNZu A2R+yHbsLAeZ7557AlkW0UycUx19IgM= X-Google-Smtp-Source: AIpwx49r77dvcmlB+kr/oA21khpZp2knxtp6+fO9z5u4Qq8nVuAMwDYoYKpx7ScqheK5LyD0Xj3dBw== X-Received: by 10.98.60.146 with SMTP id b18mr5960332pfk.36.1522632555034; Sun, 01 Apr 2018 18:29:15 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id l74sm1778673pfi.138.2018.04.01.18.29.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 01 Apr 2018 18:29:14 -0700 (PDT) Date: Sun, 1 Apr 2018 18:29:07 -0700 From: Stephen Hemminger To: bugzilla@dpdk.org Cc: dev@dpdk.org Message-ID: <20180401182907.1d7aaa61@xeon-e3> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [Bug 22] Ixgbe driver sets RDRXCTL with the wrong RSCACKC and FCOE_WRFIX values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 01:29:16 -0000 On Sun, 01 Apr 2018 12:42:38 +0000 bugzilla@dpdk.org wrote: > https://dpdk.org/tracker/show_bug.cgi?id=3D22 >=20 > Bug ID: 22 > Summary: Ixgbe driver sets RDRXCTL with the wrong RSCACKC and > FCOE_WRFIX values > Product: DPDK > Version: unspecified > Hardware: All > OS: All > Status: CONFIRMED > Severity: normal > Priority: Normal > Component: ethdev > Assignee: dev@dpdk.org > Reporter: solal.pirelli@gmail.com > Target Milestone: --- >=20 > The Intel 82599 data sheet > (https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/= 82599-10-gbe-controller-datasheet.pdf, > =C2=A78.2.3.8.8) states that the RDRXCTL register's RSCACKC (bit 25) and = FCOE_WRFIX > (bit 26) values, while reserved, should be set to 1 by software. >=20 > The ixgbe driver does not do that, e.g. in ixgbe_dev_rx_init > (http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/ixgbe_rxtx.c?h=3Dv18.= 02#n4855). It is done elsewhere. static int ixgbe_set_rsc(struct rte_eth_dev *dev) { ... /* Set RDRXCTL.RSCACKC bit */ rdrxctl =3D IXGBE_READ_REG(hw, IXGBE_RDRXCTL); rdrxctl |=3D IXGBE_RDRXCTL_RSCACKC; IXGBE_WRITE_REG(hw, IXGBE_RDRXCTL, rdrxctl);