From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id AB2D51AFFF
 for <dev@dpdk.org>; Mon,  2 Apr 2018 21:32:50 +0200 (CEST)
Received: from cpe-2606-a000-111b-40b7-640c-26a-4e16-9225.dyn6.twc.com
 ([2606:a000:111b:40b7:640c:26a:4e16:9225] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1f35C4-0001ZG-BU; Mon, 02 Apr 2018 15:32:46 -0400
Date: Mon, 2 Apr 2018 15:32:07 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 Solal Pirelli <solal.pirelli@epfl.ch>, solal.pirelli@gmail.com
Message-ID: <20180402193207.GA32677@hmswarspite.think-freely.org>
References: <20180402120619.30404-1-nhorman@tuxdriver.com>
 <2880455.xF8ZZNx2Pu@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2880455.xF8ZZNx2Pu@xps>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCH] linuxapp eal: set fd to -1 for MAP_ANONYMOUS
	cases
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2018 19:32:51 -0000

On Mon, Apr 02, 2018 at 06:50:12PM +0200, Thomas Monjalon wrote:
> 02/04/2018 14:06, Neil Horman:
> > https://dpdk.org/tracker/show_bug.cgi?id=18
> 
> I really appreciate reading such bug request.
No worries. It was there, I had time :)

> Maybe we should add a Suggested-by line
> 	Suggested-by: Solal Pirelli <solal.pirelli@gmail.com>
> before the SoB line (chronological order).
> 
Philisophically, I'm not opposed, feel free to add it in during the commit.

That said, I'm not sure its overly needed, given that the bz is referenced, and
one can follow the documentation trail to the individual that opened the bug
report.

Neil

> 
> > Indicated that several mmap call sites in the linuxapp eal code used an
> > fd that was not -1 in their calls while using MAP_ANONYMOUS.  While
> > probably not a huge deal, the man page does say the fd should be -1 for
> > portability, as some implementations don't ignore fd as they should for
> > MAP_ANONYMOUS, and seting -1 here allows us to eliminate some code.
> > 
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > CC: Thomas Monjalon <thomas@monjalon.net>
> > CC: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> 
> 
>