Re: [dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Mon, 2 Apr 2018 14:39:45 -0500
> From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> To: pbhagavatula@caviumnetworks.com
> CC: dev@dpdk.org, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com
> Subject: [PATCH v9 0/9] eventtimer: introduce event timer adapter 
> X-Mailer: git-send-email 1.7.10
> 
> This patch series contains the next iteration of the Event Timer Adapter
> library, which abstracts timer mechanisms that are tightly coupled with event
> devices, and extends the event based programming model so that timer
> expirations are represented as an event.
> 
> v9
> - Addressed comments on previous series from Pavan:
>   - Don't assume services exist in HW cases
>   - Adjust retry logic in a couple of tests
> - Addressed comments on previous series from Jerin:
>   - Fix build warning
> - Addressed comments on previous series from Hemant:
>   - Adjust copyright text

1) Please fix following check-patch warnings:

### eventtimer: introduce event timer adapter

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#273: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:238:
+struct rte_event_timer_adapter * __rte_experimental

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#303: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:268:
+struct rte_event_timer_adapter * __rte_experimenta


### eventtimer: add common code
ERROR:SPACING: space required after that ',' (ctx:VxB)
#113: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:28:
+		RTE_FMT("EVTIMER: %s() line %u: "
RTE_FMT_HEAD(__VA_ARGS__,) \
 		                                                          ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#114: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:29:
+			"\n", __func__, __LINE__,
RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                                  ^

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#186: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:101:
+struct rte_event_timer_adapter * __rte_experimental

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#193: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:108:
+struct rte_event_timer_adapter * __rte_experimental

total: 4 errors, 0 warnings, 695 lines checked


2) PLEASE don't remove previous Acked-by: in the patches that you have got it.
For example, PATCH v9 2/9, Already had Acked-by: from me and Hemant on
License change(Which is missing in this series)