From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name
Date: Tue, 3 Apr 2018 10:58:56 +0100 [thread overview]
Message-ID: <20180403095855.GB32@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20180403092859.71589-1-ferruh.yigit@intel.com>
On Tue, Apr 03, 2018 at 10:28:59AM +0100, Ferruh Yigit wrote:
> Library folder name and output library name are same except a few flaws
> including librte_ether.
>
> This library is network device abstraction layer, the name "ethdev" fits
> better than "ether", and library & header files already named as ethdev.
>
> Also there is a rte_ether.h in the net library which can cause confusion.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Not sure if the we are ready for this change J
>
> This is one the issues that the hassle of the change doesn't worth the
> benefit and you may prefer to live with the flaw.
>
> Also a concern is this breaks the git history.
> ---
I strongly support this change. The impacts should all be internal, since
the installed headers and final library name are all unchanged, so I see
little reason not to do this.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2018-04-03 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 9:28 Ferruh Yigit
2018-04-03 9:58 ` Bruce Richardson [this message]
2018-04-03 10:24 ` Thomas Monjalon
2018-04-03 10:57 ` Bruce Richardson
2018-04-03 12:20 ` Thomas Monjalon
2018-04-03 12:33 ` Bruce Richardson
2018-04-03 13:23 ` Wiles, Keith
2018-04-03 13:17 ` Wiles, Keith
2018-04-03 13:29 ` Ferruh Yigit
2018-04-03 16:43 ` Thomas Monjalon
2018-04-04 0:50 ` Jerin Jacob
2018-04-26 21:25 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-04-27 0:08 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403095855.GB32@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).