From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8CE4E1B6B9 for ; Tue, 3 Apr 2018 11:59:01 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 02:58:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,400,1517904000"; d="scan'208";a="29141304" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga007.fm.intel.com with SMTP; 03 Apr 2018 02:58:56 -0700 Received: by (sSMTP sendmail emulation); Tue, 03 Apr 2018 10:58:56 +0100 Date: Tue, 3 Apr 2018 10:58:56 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Thomas Monjalon , John McNamara , Marko Kovacevic , dev@dpdk.org Message-ID: <20180403095855.GB32@bricha3-MOBL.ger.corp.intel.com> References: <20180403092859.71589-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180403092859.71589-1-ferruh.yigit@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 09:59:03 -0000 On Tue, Apr 03, 2018 at 10:28:59AM +0100, Ferruh Yigit wrote: > Library folder name and output library name are same except a few flaws > including librte_ether. > > This library is network device abstraction layer, the name "ethdev" fits > better than "ether", and library & header files already named as ethdev. > > Also there is a rte_ether.h in the net library which can cause confusion. > > Signed-off-by: Ferruh Yigit > --- > Not sure if the we are ready for this change J > > This is one the issues that the hassle of the change doesn't worth the > benefit and you may prefer to live with the flaw. > > Also a concern is this breaks the git history. > --- I strongly support this change. The impacts should all be internal, since the installed headers and final library name are all unchanged, so I see little reason not to do this. Acked-by: Bruce Richardson