Re: [dpdk-dev] [PATCH v9 5/9] eventtimer: add default software driver

[Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>]

Hi Erik,

On Mon, Apr 02, 2018 at 02:39:50PM -0500, Erik Gabriel Carrillo wrote:
> If an eventdev PMD does not wish to provide event timer adapter ops
> definitions, the library will fall back to a default software
> implementation whose entry points are added by this commit.
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
>  lib/Makefile                                  |   2 +-
>  lib/librte_eventdev/Makefile                  |   2 +-
>  lib/librte_eventdev/rte_event_timer_adapter.c | 909 ++++++++++++++++++++++++++
>  lib/librte_eventdev/rte_event_timer_adapter.h |  57 +-
>  4 files changed, 966 insertions(+), 4 deletions(-)
>
<snip>
> +const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops;

We can make this as static instead of global as it is only used in this file.

> +
>  #define EVTIM_LOG(level, logtype, ...) \
>  	rte_log(RTE_LOG_ ## level, logtype, \
>  		RTE_FMT("EVTIMER: %s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) \
> @@ -33,8 +46,14 @@ static struct rte_event_timer_adapter adapters[RTE_EVENT_TIMER_ADAPTER_NUM_MAX];
>  #ifdef RTE_LIBRTE_EVENTDEV_DEBUG
>  #define EVTIM_LOG_DBG(...) \
>  	EVTIM_LOG(DEBUG, evtim_logtype, __VA_ARGS__)
> +#define EVTIM_BUF_LOG_DBG(...) \
> +	EVTIM_LOG(DEBUG, evtim_buffer_logtype, __VA_ARGS__)
> +#define EVTIM_SVC_LOG_DBG(...) \
> +	EVTIM_LOG(DEBUG, evtim_svc_logtype, __VA_ARGS__)
>  #else
>  #define EVTIM_LOG_DBG(...) (void)0
> +#define EVTIM_BUF_LOG_DBG(...) (void)0
> +#define EVTIM_SVC_LOG_DBG(...) (void)0
>  #endif

<snip>
> +
> +const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops = {
> +	.init = sw_event_timer_adapter_init,
> +	.uninit = sw_event_timer_adapter_uninit,
> +	.start = sw_event_timer_adapter_start,
> +	.stop = sw_event_timer_adapter_stop,
> +	.get_info = sw_event_timer_adapter_get_info,
> +	.stats_get = sw_event_timer_adapter_stats_get,
> +	.stats_reset = sw_event_timer_adapter_stats_reset,
> +	.arm_burst = sw_event_timer_arm_burst,
> +	.arm_tmo_tick_burst = sw_event_timer_arm_tmo_tick_burst,
> +	.cancel_burst = sw_event_timer_cancel_burst,
> +};

Move this above and make it static.

> +

With the above changes
Acked-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>