From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0060.outbound.protection.outlook.com [104.47.34.60]) by dpdk.org (Postfix) with ESMTP id E0D151B6D5 for ; Tue, 3 Apr 2018 12:00:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=66jSeCEUbUMc0f0z2aP7sTrYokwKH5QtIRifr05Fe0o=; b=cE1jHkeIpiA7OImPOAtMJoVZCZv/QvbBl2efDT53DO/PkL7fy3pRsCJA3p78lyi/3pBT4gVGLapjgujmIN7wwiWleTpWXiVY6ktw6Le5b10Osl0jkH+1eUu5TmJS+39T9fjQaGMPsDoas9YtBU8tA4n7ugbA+ukHHxHulrRxiIU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by DM5PR07MB3468.namprd07.prod.outlook.com (2603:10b6:4:67::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Tue, 3 Apr 2018 10:00:06 +0000 Date: Tue, 3 Apr 2018 15:29:50 +0530 From: Pavan Nikhilesh To: Erik Gabriel Carrillo , jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com Cc: dev@dpdk.org Message-ID: <20180403095949.GC8038@ltp-pvn> References: <1522358852-3630-1-git-send-email-erik.g.carrillo@intel.com> <1522697994-22515-1-git-send-email-erik.g.carrillo@intel.com> <1522697994-22515-6-git-send-email-erik.g.carrillo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522697994-22515-6-git-send-email-erik.g.carrillo@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR0101CA0023.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::33) To DM5PR07MB3468.namprd07.prod.outlook.com (2603:10b6:4:67::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5db6fbc3-c3bf-4468-ecf3-08d59949aeb0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR07MB3468; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 3:uw3M8887c7qt2AXMzr4PjqMMce2abZq9eH1UE8dnAKV4YlRWwgTqAYHA6wwSu9ZIH6TeJDNXgEmJYU2klxMk1Mp+3TlHLGHgvNt6M/R3YF/fvFC8TYE6xXSdBW7PNb+45VWgd7bAZjZRJ+8WRBMPQ/UyJlyNhnh9gwnh3dbs4jYhxampPI4W8MXOhVr8EQiCBYp8jXijnqF7ZC+gw4G0zokSFO0drWAspEa2XxKWAcqggBJoMRGlywEBmCJyOyoq; 25:kQ8o+XjUMIQXFDvng79QpCiNnKs/nY8qetS6Ru/fnjnLRhNENYQnTGlW8nY0i3/m4Vn7lzOq07ePRSvBTGQPzhOwBkge5jPrLdMnLHqhdOBNIhOAG9HyjtVglHvMEJkJBCZUAvXu7gVaRKGyqDaggkZ88Vco1xdqnLw+RAdQpU+Pv7fKNkBm/AsjEgHcAIQxXzF+oDPl8ghWUv9Z9ewohPdCpQKMNGaOQu+O3XtNok2CF2CIWthYFmISxgCJMUoSqVwOGmCDurBbrv8FDrNCKcRnCyp8aU4rJJTYxBqqugfRfpwobU4KtrbC7y9YBkltdIubWKDFGoW0TqyiiDVmpQ==; 31:jm6n+o/9Nf+MmnsiMnTVcyEhwfTWJAabovbjEX4GOTfqodDBtX7Pm3kxoh27QgnIjlMqeIFyhL6w78JZnXH4MMn/87ZhYbr5YXBRitRlZ9nhQ480V3I0/bd+19QaqnKhpEaJLe54cSrn2tbIv5fvbtbJydPXxIJwr+Xy5+THje7OOo0Z/euxQF50KGPaYtN9MU67OSHS8c6Lwx/qpmLIR7rdYgbV4eaipNdBCwnoEsE= X-MS-TrafficTypeDiagnostic: DM5PR07MB3468: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 20:3TQGN1o37bkcy7aGjY14XuhJaAvM/mBNx8oaGhBwyyufYp/aph0cThaZaNv//TOMljaKBiAPe1MXreykjRiKNv9g1Bp2XD2BQQFYGmnZ9x5Dq+J1aB07ZXDX6Ou6CYvXTuzT3WqpJ+177Nd9OVmjPeU+F5nBHZX6obW+vVUTA8Hk/5lADobck8ftn6ysdRV6aJgeHIYcsn5B/A7LAdcEcHgDScPXA7Jm9DBbs8yxfFUzS5bhrj8kf+2oUzV7ZOt2DFFho5aU0inzTpoYXMtD8gjPQQDNKhJg/pPbd9tgKcZSwJFxOGdu2g/m06rKPfE42PBo2YpGT86Z5UGztQxzKQ87bXNavkf4tJZ2goGehwweGUa/veAa+KXmcor8kFUdqKF+Ty3/E8doIdIq+P2GREZNnBTxfXRtr5xWFqGU5MFSy0a3FnjR35+elnthGPmhHTzPBuMuQeOAmRwrcUOnmZ3egN97KJa9Cyb4et9dCzlhvwVCc1qrpl1VKoKzqAwXQHwtLtSaBPVjkvD5zLXNQm3qYiz1BOm3iJdMksfTfocpZoJIjoXSaJJDSlbK+HtPvWMk6MBtbk0GyM/p3ZnRYAue+HOmrPjE2QyUVnv5kOA=; 4:k4KAU0XIGjZ1r0XpDIIxy7FjoTIJHo55a+vBGvBNtJrGYsHPUqxbxRrIM3u+dMtBS61tm2bp33baBEbyZdyUzG+s/tfvF1MsDbru3p8XjlGfZH+DP2sbQv0r95+xJoKV/htoNA8CpYA96yjk3wy1ckw2OxehNrQr2uaE3Y1DquhPLKij7nQqAa05cWZWTIngkoOtNHJRDF4gILKJ5QRf/AhexdG0wwcZHMjl8l/dBf/xQXfLyK71vHQ1CoV0vHBcVDSYRgY37mbIQfT2efhfBd/GhiujqwYlhfeJYdShju7a3Wxg117LaN2BhzpM67KQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(10201501046)(93006095)(3002001)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:DM5PR07MB3468; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3468; X-Forefront-PRVS: 0631F0BC3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(376002)(346002)(396003)(39860400002)(189003)(199004)(5009440100003)(50466002)(4326008)(6496006)(6246003)(446003)(76176011)(11346002)(58126008)(186003)(16526019)(6116002)(3846002)(23726003)(956004)(105586002)(16586007)(9686003)(5660300001)(8936002)(42882007)(52116002)(33656002)(1076002)(26005)(2906002)(8676002)(229853002)(25786009)(53936002)(478600001)(81156014)(386003)(33716001)(68736007)(55016002)(97736004)(66066001)(47776003)(486005)(476003)(486005)(7736002)(8656006)(81166006)(316002)(305945005)(6666003)(106356001)(33896004)(72206003)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3468; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3468; 23:4yDQgV74/pJ6b7nq42mJ6ZPiZBxphH4KLCJCx5DV8?= =?us-ascii?Q?Ee3aAFN/tzBz+OCxIZ2vA3ffTTL076DnyUQQpJ918grFGq6aJnT7ULarbwmC?= =?us-ascii?Q?R3afjOOKKKfnkHplhWpaCeAHixGZF7Ps5cqSccc7oJTUbxZ0b1yITBVjDUMM?= =?us-ascii?Q?kzpSpMKakrCNwFRqf3W/qv3iI7p2CjUbeZ9ix80m3oP6hh5c9eNI4M1oVYhk?= =?us-ascii?Q?5rRIUBUp2MdxOIXWu/3QZ+qYSe+71ro2S4U7xNcqtAyodAnLwotTccFcARsZ?= =?us-ascii?Q?dNdXkmHx7VaQBtjH6zwWUcrPYewGuNath5ovy1MHqYFlPMAtWaNzKq7RFcCY?= =?us-ascii?Q?WgBqfvUWQcWj1wynqSRrgeE7FAdfqp+7P03d1rx65oizXwe5uAB6GIGRJnNX?= =?us-ascii?Q?gd8xTeQPl1RrJXSGmB1MaISM1IecsO8K0ew71ar8pLE88zClm7mubospZznP?= =?us-ascii?Q?G7k8SwGIu2lveHl4eEwp/Rr1nGL1rySJHpf7EtKLAT0/jb3dcZj7h7Dia3S3?= =?us-ascii?Q?CzUQEBoSKzZ2mKhMs4TsxmDuMXCbOhtMNlTb/l+/8cDQBS9l5bt2Ue/lx7lK?= =?us-ascii?Q?BT6sbn5an4SzWlXYa1woMc2K37VAgne1d/F7n8AtJJal8oQtD8tiboCZ4l+H?= =?us-ascii?Q?ubHT3pbbiz6h12s89k5ADNqhhEZKVOlAlLuWlQFguczQXvBwUPKs3qXXIFCu?= =?us-ascii?Q?hIFJmZ+XM8sGGcybmE++/hn4RHyAp5HVRE5fX6SB1HJdHSbAox8FSs2C7Bo7?= =?us-ascii?Q?FURjtWRXUxIM47Z3iGe5NYFI57Pk2+WWlEjuKu4KUzyrTJsL/IYBdxnrpU4D?= =?us-ascii?Q?yyLhdXHrMSDFGROmkC6/vXd1rAGSUptXO9WAf6KHGu7derWVcHmRljw4qA+1?= =?us-ascii?Q?7sLnc4SGf0kzvhmx+Q2a0EBM6zGK5VpyrZUvTACPFa+exn3H3+K66p83Irms?= =?us-ascii?Q?6pq6YTYj/DeM1DSPHozMffQM9VfBdfYPsMyGnmVB4b+ydSNy9twIP+DBr0Se?= =?us-ascii?Q?R0jnVlFYKyxA3aVqJbblhNdg0XVNMHVsOXU0qU1QysyyUyg16pTFCeaL+SPB?= =?us-ascii?Q?rK3dwN18POS2WCfHIOM7JL5hwHIzSCfYr71u21ZxNMg010vLTP34bqgIxdeh?= =?us-ascii?Q?+LuKlMnMBEEm8ic+2o9sTHMxZXBxCOfo2SgU2S7R3EaovOwvlfFPX2Rrm7HG?= =?us-ascii?Q?hB8gR86yOLiLKFpDrKu5Y2GIiOw6WnCwZUqohlJvb+meNSnKxVCIlRIX/hIB?= =?us-ascii?Q?K3nPBLjxIY8918lWz0Mx79TgF2wbuydThZt8c2jCLWx9VY1jbJASQ5jDW80q?= =?us-ascii?Q?jA2fUwO7TXWUNkpp4xYgpnaLLraN1HzugsVvt6eyFK+7hma74dmnHaAX6Cl5?= =?us-ascii?Q?OxlBuzLBniLTHXI+lr3xihEhIc=3D?= X-Microsoft-Antispam-Message-Info: Kutt7AMUJbYVZcYay4qmaewKFxYWA9doa/Wma0NnfQz00CZ8jTUa8ubnobZklzgtCZ500tqldS5GjWx+6+sZiRz8WGh5PXTPmpDSSImkWFG8VjC8ZpTTLG+6R6diuE9O90b9k/BmovlSaXca8RVLsmSQwfcjgHsmDpKueQ6AekBM4uOLpalGjtukrax1IUqj X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 6:cRYG9W+FVEiOYelFJcw+BLqpswyxXhZnEYBCWdJ5SJ6rqhxcZdI+D9Af2NZAhJW3NbiIMRmLUCyJn4aV+MMzCrweafrOPOENveanANdzk04pMsD7nL9wLpS6xj4Lyn5VAC5FdJXll+W1h+GCh7ZFida0m56swMP+9JyO5IR18WgR7iAFX/KCEcV0KF1xkzZDaml/RXrPZPS3hnFIBXXBMnDeQWYk2Ik1X4Z4LL0uRTyjx5phABX2tCIIunCkPTCbYHDunf/A8ZVm8SoCpyQfng6cEcvRSJPgYCh5iyoSo3mhPiXENyqPV/w2PrltxShTZQ/zpdYnw55dnOBB5+WV/GsGBjVAeUSyf33a3yR/T/PPWA5HC9/liNHUQloFrdy8fZzEi0Zs2mp4Ff9XwG179GPI5B3l9rl4hHWccNGDPjI3nQcdSZXiwKZv7cnZIPGKKH/XmOZtBbPARXFZBxZOzg==; 5:z+w0llZLDLpAutKTgCXngpxb7YiUW+tDFrx32k8QJR5iWmqN0ZZ9sZ5SzeWVevbobTkaYnZDEQhHqC6stFCAEY4bXXI8pAQwc43isFHehaOto3/kh/h5RocHNV3sVqsP6osTwTmOTgI7+NvI46RpbEWN1GfIUA/Go3iX+ceRUsI=; 24:luHoA7YFe57Lr4xmNXvjWS29E6yTo47Sm9rVSai3NbsvsjcQiU1OkJiinZKNFMZgXfzkCDxtupWi8ZM6ZhODQv388W4J8SSb3NsTOIKnb8w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 7:OzSHgHQm4pytGaRTz9FSLeAvPNAR3lGdQWb0WrWywWltiiMuzkxNTf3XYjsyeQcop2x1ro8TO5O0X+224TS6LXQq4iIYdds/0tK+IfK8ICkIOxf3Z0jrFxsWxV+rcP+f8R/LJEV6Kg+A/k26EgqyMScpCMj7Zs2xX5/eoPn0mdDn/d5sw18vY9LMnzq3+XvMOitfGQ/XzsQxOhaiU4GtXllRi+iGbdLnKfD118HDYJVINcnLW7zPRnDjqWiIl6Mx X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2018 10:00:06.8254 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5db6fbc3-c3bf-4468-ecf3-08d59949aeb0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3468 Subject: Re: [dpdk-dev] [PATCH v9 5/9] eventtimer: add default software driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 10:00:13 -0000 Hi Erik, On Mon, Apr 02, 2018 at 02:39:50PM -0500, Erik Gabriel Carrillo wrote: > If an eventdev PMD does not wish to provide event timer adapter ops > definitions, the library will fall back to a default software > implementation whose entry points are added by this commit. > > Signed-off-by: Erik Gabriel Carrillo > --- > lib/Makefile | 2 +- > lib/librte_eventdev/Makefile | 2 +- > lib/librte_eventdev/rte_event_timer_adapter.c | 909 ++++++++++++++++++++++++++ > lib/librte_eventdev/rte_event_timer_adapter.h | 57 +- > 4 files changed, 966 insertions(+), 4 deletions(-) > > +const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops; We can make this as static instead of global as it is only used in this file. > + > #define EVTIM_LOG(level, logtype, ...) \ > rte_log(RTE_LOG_ ## level, logtype, \ > RTE_FMT("EVTIMER: %s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) \ > @@ -33,8 +46,14 @@ static struct rte_event_timer_adapter adapters[RTE_EVENT_TIMER_ADAPTER_NUM_MAX]; > #ifdef RTE_LIBRTE_EVENTDEV_DEBUG > #define EVTIM_LOG_DBG(...) \ > EVTIM_LOG(DEBUG, evtim_logtype, __VA_ARGS__) > +#define EVTIM_BUF_LOG_DBG(...) \ > + EVTIM_LOG(DEBUG, evtim_buffer_logtype, __VA_ARGS__) > +#define EVTIM_SVC_LOG_DBG(...) \ > + EVTIM_LOG(DEBUG, evtim_svc_logtype, __VA_ARGS__) > #else > #define EVTIM_LOG_DBG(...) (void)0 > +#define EVTIM_BUF_LOG_DBG(...) (void)0 > +#define EVTIM_SVC_LOG_DBG(...) (void)0 > #endif > + > +const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops = { > + .init = sw_event_timer_adapter_init, > + .uninit = sw_event_timer_adapter_uninit, > + .start = sw_event_timer_adapter_start, > + .stop = sw_event_timer_adapter_stop, > + .get_info = sw_event_timer_adapter_get_info, > + .stats_get = sw_event_timer_adapter_stats_get, > + .stats_reset = sw_event_timer_adapter_stats_reset, > + .arm_burst = sw_event_timer_arm_burst, > + .arm_tmo_tick_burst = sw_event_timer_arm_tmo_tick_burst, > + .cancel_burst = sw_event_timer_cancel_burst, > +}; Move this above and make it static. > + With the above changes Acked-by: Pavan Nikhilesh