From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0065.outbound.protection.outlook.com [104.47.32.65]) by dpdk.org (Postfix) with ESMTP id 606E51B68B for ; Tue, 3 Apr 2018 12:08:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=v/ZaubzCiVndub2j8VznbX7ocnhUwf1cHJ+LUWfsuZA=; b=Obyjde+Yl4ss5a+7a81EHExZVSWWv+Mw5sfqq35Slx/O6qQRKbMXQVoQdU+AW44lS6mcKwkHkczLDaxyGeWVMZZ47zPrfRQZ+A8kScWQX9oFHZSWx4WJiw6Rx1aikfhUibG//E3V3IlXLd4dIYSDNvnYPkEDRZ780HdEfWstOxo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by CY4PR07MB3461.namprd07.prod.outlook.com (2603:10b6:910:75::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Tue, 3 Apr 2018 10:08:18 +0000 Date: Tue, 3 Apr 2018 15:37:56 +0530 From: Pavan Nikhilesh To: Bruce Richardson , thomas@monjalon.net, jerin.jacob@caviumnetworks.com Cc: dev@dpdk.org Message-ID: <20180403100755.GA8587@ltp-pvn> References: <20180402182823.30688-1-pbhagavatula@caviumnetworks.com> <20180403095508.GA32@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180403095508.GA32@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR0101CA0013.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::23) To CY4PR07MB3461.namprd07.prod.outlook.com (2603:10b6:910:75::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a1add98-1aba-46f0-f570-08d5994ad3b4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY4PR07MB3461; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3461; 3:76f3P3FV8BYztctPiolbIQfxdqu9pB//OB7Idv4w9BQJJm58PJwE2a8L3Ao3NZE2GJBKiWpsq7zFkAYuuQ6pD0INl43n0kvamwdZQSgaCIpSCEOLt6FnMaXd9sMKv4QsB5oAzUvHS0MKQqgh+ZzboJLo95SE/2PYh8P8GTB+Ya1uwnHzTXqzH3p5NgGmCapQ4s7F2v+RKSJYGMIS0hlwx+wbeFlr0BRnyiNoqqnH4hfHdOcfHCkrIWCx8zMYXx7T; 25:iP7wkrQkzfRijFQHDYaWwGIx9DkDHeXBnV5XsymLGv7YAn7UI7uWvfVnBlEcHcc+kI/p6MAwRvljdKkG2YA76tyYfAA3Xu23hAglr4sJyktYziYP/Hu004TBrUGBMv52AyaBRn5nWo5mbSdpGYIvC/OYJVHwMA2K8FpMYTX9d+wAxwMJt3C3dqIa1z4IQUYftgy6f9TY68Yc+qqfo3z+VZw/2gDkcAylyhKt76y6kyWab/8SYlQavcWW6PU5KowgoVvisCpp/Uek2AiPQrD1l5gidU6Tp/CZ/xWUZBsXKBmPZbyc7CRnbC3AHsmV+5Cvi99UqhT9eDWMY4ISgR5D7g==; 31:JZ/Mx7KDQWq2EIeyjhMH+3phbbCPh2FxgKgGAJReu0JUnz8UoqoOmHeWYtJy03QnqM8onrJEjFTqUketmvG6AK8I/BzjTJJuO2vUVgy/IM68JtCjf650TTfjjox8tg+eU7llFcwLv1wzT8r07+9M1R/SHZxU/nEkzci4jNGixQFcDNI1GCT2ieeKIriwJTjIVWrbMUBOjaIkLMctit6N3zeZI+v9+r1+gs1KwQcU1lo= X-MS-TrafficTypeDiagnostic: CY4PR07MB3461: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3461; 20:iiZiIOUE7xkqQOi7vSxsFNr0z0qkYvWxD9s6Dd6SVuw5v08R9VJ8JfjhI6JVdsn7qQyxlRruP9tFVmwX++xwn75gqVti3YiIcsn6Lkge6nYvfPKqPA9lJJ8ZjkZJi0yGNRfiTT4sQVh9BViLnYNx4ScAY4lw2xRg1UJOHbqF4znxDnIcYNK+nAd+9QImog6R/Ame1iVJ3yOEEj/UCyfJ8rbCOeEgRC5fvLuAhHvfhCr3uo/JdREGQc00TsYt16v9ePtBiwQUpbkaQhKXNbjmfVaO/jfB8eufygTLlCNhqrc8h8/FEb6ba6UXCUQTnMHzg7US52+a+lwZEME6XGJe+lHrQyuuDLZYQ8R9YiBtCK4thaWNFROK6xblIlNOJ2NBX34PLyeyf3I7V/WWA5Prg2zrxXpYWZnGKPYCJgEgeY+qBP4DDWDM/+3Ivvyk7r8ou6kxwB+TTscB8UIMQWsrg0eVxaCr9rX4OHzzn5mGI2nVBnZFw8a9jvS9FHVGjdX1EBiad8BwIo+y52YwDkqGVrOA9cTfJNBZw21+0tOLXKwhhNBJivUXRJzf5dBf2Cc28Yd3erV10NYjB4AJ7lk/Uf4C9RsLr7kjyHcBnJHijAc=; 4:Ah8HtAyL89dLy7ZyMjtM8SKXTxXsS32nN2pJh1Qv/fmTwezGqUpND+IHpWplj/nevBm7L943XZFKW06rnkyHt0+zV+PWHCHAaSzz1j11NVD03MJHWMWwcxVxdFm4U0EiqAzxhYmAEVEDPS3IKPVbHHUJJALXW7PxEBWdBPTIzlt922hkUxEzyNoKkod8YoWK4qNkvzKn7iDmREl4p6OJUCLvk4XH3An0XB6eJoWUDmMu8CQ7cG589lYdYYE5Muf32L+bbOedjo3oPkk73FWmyg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(3002001)(10201501046)(3231221)(944501327)(52105095)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:CY4PR07MB3461; BCL:0; PCL:0; RULEID:; SRVR:CY4PR07MB3461; X-Forefront-PRVS: 0631F0BC3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(376002)(346002)(366004)(39860400002)(189003)(199004)(966005)(53376002)(2906002)(186003)(72206003)(16526019)(305945005)(42882007)(33656002)(106356001)(105586002)(47776003)(5009440100003)(8936002)(316002)(478600001)(7736002)(66066001)(58126008)(16586007)(53936002)(386003)(55016002)(11346002)(486005)(6246003)(1076002)(486005)(26005)(476003)(3846002)(8676002)(6116002)(956004)(50466002)(446003)(9686003)(6306002)(81156014)(81166006)(23726003)(4326008)(229853002)(6496006)(33896004)(25786009)(97736004)(6636002)(5660300001)(68736007)(76176011)(6666003)(52116002)(33716001)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3461; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3461; 23:VJNOv7YWGK816Quxyi+H0QPcLbWwx4PlvwYzcLbvJ?= =?us-ascii?Q?09luKuGEOwS/tznE9FyNqkXwEKLw5tDfoIwgGwed7G3ghgl1TxrPnjsYuoHg?= =?us-ascii?Q?2V3rgBrDvOTDdc5QkoK6cks38cRIBJgbixijhVIGsuBbtuw5ZHX7brjVWu2V?= =?us-ascii?Q?y3yKRAYz+Uw9upQc6W+F1G53MA6Akwc3DcyaYte/jff1kwaPwMuYA1PSc9e/?= =?us-ascii?Q?q97n5JnAqhiUTTpEbF6EBWbH4YGhr2qVIHSqVkAlO73nVJoJRDR94bEZ+8Hx?= =?us-ascii?Q?UFSzjG0MiY7rNU7vEif8wZFRz9LCnawy4i/TkoPkqp1nU+JGLfZmBlm82lE7?= =?us-ascii?Q?2DatErX3LmDBtL17Yrfsud+GEh+y1Q1k6CPOgFKpfp5vHzfeSegocotRnbWf?= =?us-ascii?Q?9sD4oQvvzzpiVQU2q9n4rQ75MKHf+l0+FKj6dlNOTLzWA7OnMBhnbE6YALOL?= =?us-ascii?Q?DErdJh+StZa6Vkch2nVOgIBvVDHZxJDaUXMam392buoMyojQKkiE8VLLyoqa?= =?us-ascii?Q?oXkGwiW0UruIGNzE1+3F+i2WEDxeup5vrgi4gsaHZnXBLDuTGEE8BoauXuwW?= =?us-ascii?Q?1mEwM4DOhlhqnxiNbOuKpPCM3Jwwt2gsu/+h/MkCs5vMY+o768FEJHRQkRtD?= =?us-ascii?Q?eH/Qk9/BWsudoo7y+pTAq7YgffP2iHCVeEzhTr4Le4dKWVCZ52MVHdVnCZUb?= =?us-ascii?Q?Q6od80Zueau9mpza35IY5+iCriUvWSLmDOMyVbA49blO+cb4XFmD4YyvxpWf?= =?us-ascii?Q?M5XPdDM0H6mHqC7P7uavkxVFNsVYvS4G6+Vmm37IWZMP90lShLZ0muu8WGgY?= =?us-ascii?Q?r1aFWpXUNtSKTXYEFzWE3EF8tmGkfREblKsIdye9rvcH12/3ul+Mn7ewXrYt?= =?us-ascii?Q?eOR2kLyg+9SwVxv1Nmf6/dZeJLkWFEZI8RYob+Siu8/DW9cdybEPE3KAZf8p?= =?us-ascii?Q?2Zu+rhnrO8ZY0LEIWVfbE99P9/xED5o5FPKVfRuIIGPDGDRNzG7NlMpNnKhr?= =?us-ascii?Q?zGEeym+uvUH/GHRGrWyBkzHLsdJhMUdsGD02Im8oVFXS5WNfHIK06PSyzOOv?= =?us-ascii?Q?vYJGqOjCiEn5jCpRTQ6cJMwsHKw3ASlSMCOxqWoBzR4OBMQ0lMCgxAgPNW5m?= =?us-ascii?Q?RJKFRPiZv8FLR/3G9qtJaRN1FbcsXR1wIileWLYI2kaSJV01SN66Jq8YeShd?= =?us-ascii?Q?ic03JiuEJ6w0rhUT3c/jhE9SOYLHq8Z7TpbkZqY8vNIu69PgMrXdRYLoYG9c?= =?us-ascii?Q?f57t8CqzJ5MMaAynxgzLgod1bMey03mfcgufs8HpAYHDhL6qnAYBXXtua3tG?= =?us-ascii?Q?vJU/+7N3BeR2w3zn18jcMPEgT8c9Z9kFyeqsAELDg+PBRZwicbPk6K1vqgVL?= =?us-ascii?Q?pFxJEihfV2eTjQ9gb14S519xgcKBO5dKO5XLQQiG0C9wysFLBz0VXJSZddVY?= =?us-ascii?Q?D0q0/+RsRH+oqQJCS15ufCb/Zkym2k=3D?= X-Microsoft-Antispam-Message-Info: f7exkCStmwVc77M3LzxYxG2hBOuPHr0XUHt6M5viKQSbi8NF3F7PrLOX9hawwdaaPVTkPi6h7zMIyUTG9tJccw82wdjY/gh6rWBOSwd/0lnMd3cbfHl6ZSIALZZJ48LGYUWJxtbSMvl77Na3xHmsD8FRxdLPR3WJFj63cPmYB76PYO7p+bssR7GWNqALpSYs X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3461; 6:Tfbm6au2lg23MBtXD2AzqFDrlWDcQ7SAEqqq7IsD5CPeMvyCdN0mt/JIOUQf4jgT4ZzZGznB9XIbiiH/eXMPKekH9y8PDedGnrQDDnf0wPGNCx/tR46N3FXxuAXY9zXGn3e5H58Q4pPTXPkyZvek3+UCs/4w5rn61l6O7XZ7KqGoq2X4EcpSqawvcx6fohpPBbPiYAISlET+GMcIBhOde8fZHT026kIJfrJbAC8DPih7lFeDJ/FUbKykUEQzgRKCs6fe2MjVSRf1R6Rsq0pNhJoHjqR24Ej+Ep9CBgtX3yc7kc5kBckUj0aY0416DRzJqoe9YFWjrVun5FrSLQKzDU9wxT/UQkFPj6ovJiTX6G2ZW+6dRSi8tLIzOTn2B3jd/SOVLTGvocbH5EE+I1JGfGB3Oufv1ID30yuyE53GRO8YgOJ6Rl+yrqZFNm/QmfSGO7xFB1RMdd3vaEiUfOTIGg==; 5:4yym1c3tVu5njvSv+bBaPbINX36y3CpLH3AP6PSA9+D0Rk8sihGF/K8KyUDyNLe29tJcvB5RIIGZ6vuSJsJvyLUPuIg9TZZi6vXSJ5zVqTvx96nHnS8Wx6SLabfmOjp7pQo4GxSCRuUS3QHyvyw95U/rDPx/FCCekeetk0BE8qE=; 24:UP1KOOREyN8iagKffbLE1xzRBTwKpE7/tsRzHtAHvq5v2CTsppR1kBCUHUm0TvPMlxHxSuO19NU38GHJwwc9jlv/XD8US10DYsRLFY4TJfY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3461; 7:br7jXU8PI5B+AwO1EN1mY6bFhC7Rpu/Iejn3/3t0nAO+LM4j5RDbObODthqp8mWlqaH3CBOHZDe0R2od18Q3Rsp7+dnMfE94XGQdJ9yRMVOK27PFirUE9/JH3hKGY2bJjtoE5eyAlawzvXMPp/liJC8laRP1alJU8IfPBKWLjAM1g4tdYdxzJeojfuKti/6bDkkrSvWg7C07jzNVP6Ys0dWoak1xGf6/Z/x5JxclFI5Z+HlD6ZqGmKQc1J1TCCAC X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2018 10:08:18.4712 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a1add98-1aba-46f0-f570-08d5994ad3b4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3461 Subject: Re: [dpdk-dev] [PATCH] build: meson set toolchain info during config init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 10:08:21 -0000 On Tue, Apr 03, 2018 at 10:55:08AM +0100, Bruce Richardson wrote: > On Mon, Apr 02, 2018 at 11:58:23PM +0530, Pavan Nikhilesh wrote: > > Meson set RTE_TOOLCHAIN to clang/gcc and set RTE_TOOLCHAIN_CLANG/GCC to > > 1 during initilizing dpdk_conf so that it can be used by both x86 and arm. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > config/arm/meson.build | 9 --------- > > config/meson.build | 8 ++++++++ > > 2 files changed, 8 insertions(+), 9 deletions(-) > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index c1ab6ed01..e9c9eb1a5 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > @@ -83,15 +83,6 @@ impl_0x69 = ['Intel', flags_generic, machine_args_generic] > > impl_dpaa = ['NXP DPAA', flags_dpaa, machine_args_generic] > > impl_dpaa2 = ['NXP DPAA2', flags_dpaa2, machine_args_generic] > > > > - > > -if cc.get_define('__clang__') != '' > > - dpdk_conf.set_quoted('RTE_TOOLCHAIN', 'clang') > > - dpdk_conf.set('RTE_TOOLCHAIN_CLANG', 1) > > -else > > - dpdk_conf.set_quoted('RTE_TOOLCHAIN', 'gcc') > > - dpdk_conf.set('RTE_TOOLCHAIN_GCC', 1) > > -endif > > - > > dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) > > > > if cc.sizeof('void *') != 8 > > diff --git a/config/meson.build b/config/meson.build > > index f8c67578d..5994d7b7b 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -11,6 +11,14 @@ dpdk_conf.set('RTE_MACHINE', machine) > > machine_args = [] > > machine_args += '-march=' + machine > > > > +if cc.get_define('__clang__') != '' > > + dpdk_conf.set_quoted('RTE_TOOLCHAIN', 'clang') > > + dpdk_conf.set('RTE_TOOLCHAIN_CLANG', 1) > > +else > > + dpdk_conf.set_quoted('RTE_TOOLCHAIN', 'gcc') > > + dpdk_conf.set('RTE_TOOLCHAIN_GCC', 1) > > +endif > > + > > Never thought to look this up on the original patchset, but looking at the > meson docs, the compiler object already had a "get_id" method to identify > the compiler. We can use it rather than use checking for explicit defines > ourselves. Using get_id() also allows us to identify icc and possibly > visual studio compiler for future windows compilation too. > > http://mesonbuild.com/Reference-tables.html#compiler-ids Good point will send v2 using get_id and multiple checks instead of else so that we can extend it in future. > > Regards, > /Bruce Thanks, Pavan.