From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0085.outbound.protection.outlook.com [104.47.37.85]) by dpdk.org (Postfix) with ESMTP id AC0221AFF0 for ; Tue, 3 Apr 2018 13:11:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qq3ABPT4c7q9ey27i10gzlAYoe14CWP5sDr+yFYoj60=; b=nc7aelwjJFzFEhBp78Y6t36RL4xvCWyuUkBcPVo8QMvt4gjkQRLJt2AiBWeI9v5R9pgHFD/NM3HMBkikBs7a6P58CobJlJZsUFwaAnhZUomyqU06wyPn7dckqoEKM2GxC3WxbFNX38rlbuKGV8zggNjf4qwjcbZt4yspFPi7EeI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by CY4PR07MB3464.namprd07.prod.outlook.com (2603:10b6:910:75::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Tue, 3 Apr 2018 11:11:53 +0000 Date: Tue, 3 Apr 2018 16:41:34 +0530 From: Pavan Nikhilesh To: Bruce Richardson , thomas@monjalon.net, jerin.jacob@caviumnetworks.com Cc: dev@dpdk.org Message-ID: <20180403111133.GA11787@ltp-pvn> References: <20180402182823.30688-1-pbhagavatula@caviumnetworks.com> <20180403102110.9507-1-pbhagavatula@caviumnetworks.com> <20180403105524.GA3544@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180403105524.GA3544@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR0101CA0026.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::12) To CY4PR07MB3464.namprd07.prod.outlook.com (2603:10b6:910:75::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38bffaeb-ccc1-441d-a8ea-08d59953b56c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY4PR07MB3464; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 3:k93Y+wWtJkm6QCwbw+FZqAk/IyZW8fpeghi5LHPB+xK15bgb7c+8aAflVmlg1p2rejQzYW1Ou4yNoYNhedtjzxnQjzF+BgDcjQyi0C+oTfrRwdHsZRPmoJPSSNUXVVOqz1sfVJbe5S/TZcfoE7JZL8Zh1uxz4375Lj4LAAiVfz0Ussgf/25EJ5uckGvu4wP9M2OafeRmz0F1XWtGxzmtN4G+6YqJOK0d4UT7bVHL6kFQTY1sWdK1KjdqihES4pWI; 25:D15lkfJj/tZgpOIFv5H6VspYRtWtZoV5ot6c08KoLARuSSuR++9dgls8nlH7bnmQRu0B8/SBUh+aMflL4qWkKwCIuUOPO6v/IH4GFzNWvaFf6sL1tj8AOo1nvMi5vyJqJByo7fBKr4yVmr9TBGBfHQH/xIYz1Sbf34zjnhmIQo7A6BjWtlVsn5BMO6eI9AWvPHZf7iZoWMybBJop2fcVnlSoT2BNF407pimAFJTYwRQu9+wFujOSh8+DDvebm54gLznwD290ri8aIFwoiMuQrRWiasS/Qk9BsAuMWgV7tLfSqMuU2x7VQ/xaE8nENIBtuqgQP7DFfAd979CR0kvq8Q==; 31:a/mNoIKzTL5DPUOm2kbQdB3WHvmZhYD1TllUqNxP8BOTyCpiqB//dTWmKTTK8ZNxTsxO4gn5RM41sHS3vzS7u7FWJIg1fPGIFGcVkQPziLU9w5ej5WmwWUviBcB3E03DHWeWyu8opzwkJGu8c/ti6jsUWndzR2dhaVNoLFOWvUHJf0Yr/EPGHKs5EnzDiWP2oL1bbv4MXPppMCGHGH6HXVozVVpN5/V9DLE0tKxTXv0= X-MS-TrafficTypeDiagnostic: CY4PR07MB3464: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 20:kkeMa5kgB7SPftR32VrfMlc0zLQ+QTu/T62lq5X6klo7M2/NvE2e3yw/JFJsSqslKPYWqT1s41kx/KwryhlhGE+7KsZPjxaZSxpdy6xepXDbkyB/IGJ450HNJ+28EIzLOPRYesgg57co3VBn5HoateFEYDO3+u34xlBa8hTH6trSn/d6pnfSsx44YR5SWOKKWyfRrhfO20aTo5en7JmkGcnApMurxmz7R9YbYDQD7axzmFeynSDIGkzuC9NhmPNPmZzuk6pP0J0yFmPUPrzy1WyGpxEm305XJuO+XqwO20TWbchpbwp66uBn748AIiaFaTQZiPu38ZmXGfDM+ftOxFJgD6qD1WZwDIkSZRA+DQoDfYB17SIAp+NceBTasJ9vzqYk0Rjopm3H5o/TnvXO2ZPHG2e0uINXQ/ev3zLlpXohaBdT6nYwSXhflbcZtMyzS0CPiMmEIjKer4V6mowdpZob4VPqlToL0N46gZWa8/gDbEtTDYpD/icnFfWq+5mIWHQtC0Hi012SsyAT4NRFK+aPbyYRJ0vZZMvHoEF9WcB5+2KaV+fBzPA9YU68ZFdsT0cZx+TRFXXOyNOvBuYqx2+YKcnXVNvwySc7CgiuxzY=; 4:P1GPftzahb8U/1Ie5mGjoglNGXctis8hRlUhsdm1hs53VPKbx6uU9uTKVaa6fuAjYlHGruRumary3zyqLp9LpBKBgFP3wDTWZkBxS5Bh4LA99it+g9I1QUqWzBddNsugo23Q2xqi6RHMP8NAkfE8s4HAJogviC1M0+UTXANWTqEiy0vtlOdauJ/a6wTt9/gcoQH6j4FgS7FldQLGsuNI2BuF6EnW010fuCS/N7fvtiDXp89Nuc+kbSAkbj0e+5mKKnkvcjloPdMHzPSZ9SOa9w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(3002001)(10201501046)(93006095)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR07MB3464; BCL:0; PCL:0; RULEID:; SRVR:CY4PR07MB3464; X-Forefront-PRVS: 0631F0BC3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(39860400002)(376002)(39380400002)(396003)(189003)(199004)(486005)(316002)(33716001)(6496006)(55016002)(50466002)(76176011)(11346002)(53936002)(42882007)(97736004)(33896004)(9686003)(446003)(52116002)(25786009)(106356001)(476003)(66066001)(186003)(486005)(72206003)(956004)(23726003)(81166006)(16586007)(6636002)(26005)(6666003)(59450400001)(6116002)(6246003)(7736002)(3846002)(105586002)(33656002)(5660300001)(81156014)(47776003)(16526019)(68736007)(229853002)(8676002)(58126008)(2906002)(1076002)(4326008)(386003)(478600001)(5009440100003)(305945005)(8936002)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3464; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3464; 23:bpNHa1Xf5tyIykJlzM1DnFyOtu4S+/1iwMRzeYPjb?= =?us-ascii?Q?iJfbyfJ07BPcWugGryAq14FcXo5hrtFyobqh5UbE8ktaKECb2ZDjRbv3rkas?= =?us-ascii?Q?aMX0Q52tYKNIx1YYYJrskttgVU0lut21Hw8h33Wz+wKx+pTe3D/GWhPRJvtv?= =?us-ascii?Q?Pl0VB2NSiHz8sVBJuB6EmK75WmXMNDI8FHJ7UcZc6Q4bPQtBeJzPtE4rwtLB?= =?us-ascii?Q?EQgLqsv9s48k75h+LOoMHbMdXX+wctSmSEJ0r0BzeJOqCBS5s16Eerc2z6jj?= =?us-ascii?Q?J3acnhE9EGvlkDcZXyJiHnEiqoB52xwdH3okwitXOV/BbupTZF7KaUvKfcYp?= =?us-ascii?Q?Y0XPDS5sqsMOxCr+IJniEhEHKfVWjUKn/0Ec4f6Nd4ZBTW99QiS2hwqkAFb+?= =?us-ascii?Q?blmjoaC57w96pr1kBY/87e3qBAQSBgBVV/qNTAfEXhu43nFCV3AOKoIA45mo?= =?us-ascii?Q?u22FCGc/SYO3eAXP+Fh5S/lmN+kSLgZkzL5m5eWC1q00y4L85ilg58y6Mytr?= =?us-ascii?Q?gGkJpmKxz085ST82RgGvLasNB1WIo5aisNpOBokVUrx3xASmwQCvAeaK2x4V?= =?us-ascii?Q?MF4eccMPweGLhyaCtIeku/KfN6eWlwO3l9DPUmJHgC6BD6AmpV9GyjDwqQgH?= =?us-ascii?Q?TUur8l332UNLqGUFA8zpAivK1BuQSO1KNU2LWCy6DqP5CO7I7h4bzf7zTixL?= =?us-ascii?Q?tVOE8oLbIzVYp+uaS9f7zksnvrpyHy7PYpf4WHTEnGP5gujux/Xx+z8Aeudy?= =?us-ascii?Q?Fek2B4yXdVoNQ+26DUa+lAn+qib+OC+1bCsku3qt32scyQk7DLEE6nqb3KUT?= =?us-ascii?Q?xbh9Fq1nV68gEORp8DKgJmLIl9FXHuGMI5vueAqHSRbIEXif18sKF9w8rgNe?= =?us-ascii?Q?QJmeDrJ6BPY2nMS+4g6BQ/Z14rgEDN6a7FJR/BNR9yo0NQYnOriFcVUGFa4E?= =?us-ascii?Q?WQiWH4vjUfTZRTPdenoRGDW2HoLAizDguXP2BO956YTYsJmQ3n+QBkd+qnqF?= =?us-ascii?Q?o2UD3la548DG1ICUkqg5OMLwZ9S6kaOVT82/PH6ZNwkHYblZZzK+QDP3Fs+c?= =?us-ascii?Q?bkY2gJdXUJZ11r+gTVYFAwPCxDnjq/9Lm1t2WReN2q1iRbMUqyCe+3PQ6SAI?= =?us-ascii?Q?hsbzSQXJaunqplZa0yZ5djAXdSyFERlACEi6bwYa0p1MCn6vYGLGtGLG885y?= =?us-ascii?Q?olrJDxHWJfECORRGWfynKY5aAXSM6ebT+TKqV9ZX5CU+5zNDBNfAT1YOe+mp?= =?us-ascii?Q?jtvMTdwTLKOuB3htVIDMMD3INxx0leAB/CBmW2ySImhCbollAMYpAQhJA1sn?= =?us-ascii?Q?PMROq2n4D5aURiDuAdVhYV6rvThqWhzCXo1uVYeSN38wxV8pYvCeD2ww8oXj?= =?us-ascii?Q?62+kqvwZbw5MaLagxh60QUXa7n7TcSJL6x9OHMUr8e+fhcdUlQtxsYgwg/si?= =?us-ascii?Q?jnhZBuW1A=3D=3D?= X-Microsoft-Antispam-Message-Info: 1ykQNiIpLIwAkSZnm/EomXxuoGnbWRkuSvRfnxy/JoCgZzTU0rzvf8yAeZxeWY2ZuBfzphn4VdC9mlzFKcH5FCN7okseTrRpR9ZF5rkBK4/jfoAabEKMORmiL8w1f8T8Ec3DA/zGZZAh9kyIoFuQY4TU5JFsOJ9/Bty278j5ro4k8P7CBdMr6nFvLP9gh7FT X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 6:yA5Gws7OXo8G67OUDfx10isxkpbyxTl3G9JOwZ2ZzEQ2BLzTJc9rNSVpvWthIGWqHAUlvNMEfijb2g86oTz75ZCHWz2zKFiVWyNu/exXgLCji3rnrEyynepJhIimdeMeE6SRPKiZk6yS/SYiiANKSGSKBtnO7Z4TEtme+v5KOXmZsqkKdvX4vX0YxN4tdk7v2KXGLeJX3iUqKBqu8xA8RdzT7vuhSvk+t8LkBGlwFSfOLevX0cgWtAvfYfZyqCzr7HzWz7AJuU3LLQk0g+SfkX7SoF2FmyWr1CRhajdycJrsMO2T5NvJJdmupSocG5s4+HjWas6cQ2J69V8+M8yh/7httpqX3+dQvHTAAZ2+KzDSrKUcPQ2H9fxa6xxiskEAXexuYuR2rFaLOWukzYmR9py4A7KtcL4tIZiG6pBt21uzwUbNDrbqSO/2xtTJURiH9Znu+D+wfhMT2puS++bJYQ==; 5:F5To33m6ws3H6sF9yDbsetr4uwEgCa0SFOiu7jM3Wijf1Hu9RdOnh0j2n4cbdEGqMu4ebnvxsfmFrgNrUQtDsFDcsKdym835OBDdXfhn1CozEH7YiUENe5GRx1gKX3lEpCtoJWA/Xw5TyQxn63wJa0wSpijvAuY8xjTjQQsqczg=; 24:l1BD7bpKicVCKGKRVs9i9SNKHNxokc4PJaTmIoSGr28YRuGdCh8t+gfdMQFtWtixpV/Th2CufW1zWm/4FsmSMXzHZRKJ9ZifoiUVXf3/YN8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 7:6nX4aWsncRjrIRqY0YCZ/YiYsfWYM+lZ2rOH/ZphBUaxQGa+BeWwLd+0IFG7DeFJqGgUZyIrpNXn/qLKAsWnp7oNbL8smW866oMPeDPp7yndaXuqlBTf94OdK4sZtPht9m8S5B0K/aRYmqEXhf1YgWWrQSc+FroED88GHaZLJ8Br/cCKJ7N/FoVjAz6Ke3sU1dkWcnWFhkKPBEhYUh7qPUQOLQnKaXqiA/stcFt8PIBNv/bdW/9WNDM+aDX3FkuZ X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2018 11:11:53.1206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38bffaeb-ccc1-441d-a8ea-08d59953b56c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3464 Subject: Re: [dpdk-dev] [PATCH v2] build: meson set toolchain info during config init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 11:11:57 -0000 On Tue, Apr 03, 2018 at 11:55:24AM +0100, Bruce Richardson wrote: > On Tue, Apr 03, 2018 at 03:51:10PM +0530, Pavan Nikhilesh wrote: > > Meson set RTE_TOOLCHAIN to clang/gcc and set RTE_TOOLCHAIN_CLANG/GCC to > > 1 during initilizing dpdk_conf so that it can be used by both x86 and arm. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > > > v2 Changes: > > - Use get_id for identifying compiler instead of checking for compiler defines > > manually.(Bruce) > > > > config/arm/meson.build | 9 --------- > > config/meson.build | 8 ++++++++ > > 2 files changed, 8 insertions(+), 9 deletions(-) > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index c1ab6ed01..e9c9eb1a5 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > @@ -83,15 +83,6 @@ impl_0x69 = ['Intel', flags_generic, machine_args_generic] > > impl_dpaa = ['NXP DPAA', flags_dpaa, machine_args_generic] > > impl_dpaa2 = ['NXP DPAA2', flags_dpaa2, machine_args_generic] > > > > - > > -if cc.get_define('__clang__') != '' > > - dpdk_conf.set_quoted('RTE_TOOLCHAIN', 'clang') > > - dpdk_conf.set('RTE_TOOLCHAIN_CLANG', 1) > > -else > > - dpdk_conf.set_quoted('RTE_TOOLCHAIN', 'gcc') > > - dpdk_conf.set('RTE_TOOLCHAIN_GCC', 1) > > -endif > > - > > dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) > > > > if cc.sizeof('void *') != 8 > > diff --git a/config/meson.build b/config/meson.build > > index f8c67578d..b8f953b54 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -11,6 +11,14 @@ dpdk_conf.set('RTE_MACHINE', machine) > > machine_args = [] > > machine_args += '-march=' + machine > > > > +if cc.get_id() == 'clang' > > + dpdk_conf.set_quoted('RTE_TOOLCHAIN', 'clang') > > + dpdk_conf.set('RTE_TOOLCHAIN_CLANG', 1) > > +elif cc.get_id() == 'gcc' > > + dpdk_conf.set_quoted('RTE_TOOLCHAIN', 'gcc') > > + dpdk_conf.set('RTE_TOOLCHAIN_GCC', 1) > > +endif > > + > > What about: > toolchain = cc.get_id() > dpdk_conf.set_quoted('RTE_TOOLCHAIN', toolchain) > dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper()) > Agreed, will send out v3. > It will give the exact same result for GCC and CLANG and save us having to > update in future for other compilers. The one potential gotcha is that for > ICC, it's going to report "intel" instead of "icc". However, from use of > grep, it appears that we don't ever check for icc except in the makefiles, > so having it reported as "intel" for meson builds should not be a problem. > [If it is a problem later on we can always put in a special case: if > toolchain == 'intel'; toolchain = 'icc']. > > /Bruce