From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3384DAABA for ; Tue, 3 Apr 2018 14:33:56 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 05:33:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,401,1517904000"; d="scan'208";a="30327524" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga007.jf.intel.com with SMTP; 03 Apr 2018 05:33:53 -0700 Received: by (sSMTP sendmail emulation); Tue, 03 Apr 2018 13:33:52 +0100 Date: Tue, 3 Apr 2018 13:33:52 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Ferruh Yigit , John McNamara , Marko Kovacevic , dev@dpdk.org Message-ID: <20180403123352.GA4152@bricha3-MOBL.ger.corp.intel.com> References: <20180403092859.71589-1-ferruh.yigit@intel.com> <8464158.iTavIsMWKz@xps> <20180403105755.GB3544@bricha3-MOBL.ger.corp.intel.com> <2713963.Nlhf7d0HAF@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2713963.Nlhf7d0HAF@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 12:33:57 -0000 On Tue, Apr 03, 2018 at 02:20:30PM +0200, Thomas Monjalon wrote: > 03/04/2018 12:57, Bruce Richardson: > > On Tue, Apr 03, 2018 at 12:24:15PM +0200, Thomas Monjalon wrote: > > > 03/04/2018 11:28, Ferruh Yigit: > > > > Library folder name and output library name are same except a few flaws > > > > including librte_ether. > > > > > > > > This library is network device abstraction layer, the name "ethdev" fits > > > > better than "ether", and library & header files already named as ethdev. > > > > > > > > Also there is a rte_ether.h in the net library which can cause confusion. > > > > > > > > Signed-off-by: Ferruh Yigit > > > > --- > > > > Not sure if the we are ready for this change J > > > > > > > > This is one the issues that the hassle of the change doesn't worth the > > > > benefit and you may prefer to live with the flaw. > > > > > > > > Also a concern is this breaks the git history. > > > > > > Yes it breaks the git history. > > > I am a big user of gitk. Do you know how to follow the history after rename > > > with gitk? > > > > > > I think it is a good change but I would like to be sure it will not > > > bother us every day. > > > > > For those of use with even slight OCD, having it the way it is bothers us > > every day! :-) > > I view this as something that we really should do some day - it's just > > broken the way the way it is right now - and so the sooner we take the hit > > and fix it, the better. > > Yes > > > If you do need to find the history of the file, would git blame work well > > enough for you? > > No, blame is not enough, but it does not matter. > > When should we do this rename? 18.05-rc1? > If we are going to do this rename, I don't see why we should wait. /Bruce