From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 20FA51B83D
 for <dev@dpdk.org>; Tue,  3 Apr 2018 18:25:48 +0200 (CEST)
Received: from lfbn-lil-1-702-109.w81-254.abo.wanadoo.fr ([81.254.39.109]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1f3OlI-0005zB-0T; Tue, 03 Apr 2018 18:26:21 +0200
Received: by droids-corp.org (sSMTP sendmail emulation);
 Tue, 03 Apr 2018 18:25:40 +0200
Date: Tue, 3 Apr 2018 18:25:40 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Tomasz Duszynski <tdu@semihalf.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Ivan Malov <Ivan.Malov@oktetlabs.ru>
Message-ID: <20180403162540.aa46l65ecxwpuq4m@platinum>
References: <20180227151129.30387-1-olivier.matz@6wind.com>
 <20180403124103.13124-1-olivier.matz@6wind.com>
 <1aed0285-eba5-5ca0-dcb6-486ffd98c4eb@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1aed0285-eba5-5ca0-dcb6-486ffd98c4eb@intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting
	MAC address
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2018 16:25:48 -0000

On Tue, Apr 03, 2018 at 05:19:06PM +0100, Ferruh Yigit wrote:
> On 4/3/2018 1:41 PM, Olivier Matz wrote:
> > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
> > index 6ab515ca9..87748f789 100644
> > --- a/drivers/net/mvpp2/mrvl_ethdev.c
> > +++ b/drivers/net/mvpp2/mrvl_ethdev.c
> > @@ -987,7 +987,7 @@ mrvl_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index)
> >  		return;
> >  
> >  	if (priv->isolated)
> > -		return;
> > +		return -ENOTSUP;
> >  
> >  	ret = pp2_ppio_remove_mac_addr(priv->ppio,
> >  				       dev->data->mac_addrs[index].addr_bytes);
> > @@ -996,6 +996,8 @@ mrvl_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index)
> >  				  &dev->data->mac_addrs[index]);
> >  		RTE_LOG(ERR, PMD, "Failed to remove mac %s\n", buf);
> >  	}
> > +
> > +	return ret;
> >  }
> 
> I guess mrvl_mac_addr_remove() updated by mistake?

erf... that explains why I had to do the modification twice :D
Thanks for spotting it, will send an update.