Re: [dpdk-dev] [PATCH] eventdev: fix incorrect MP/MC tail updates in rte_event_ring

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Tue, 3 Apr 2018 10:19:03 +0200
> From: Mattias Rönnblom <hofors@lysator.liu.se>
> To: dev@dpdk.org
> CC: jerin.jacob@caviumnetworks.com, Mattias Rönnblom
>  <hofors@lysator.liu.se>, bruce.richardson@intel.com
> Subject: [PATCH] eventdev: fix incorrect MP/MC tail updates in
>  rte_event_ring
> X-Mailer: git-send-email 2.7.4
> 
> rte_event_ring enqueue and dequeue tail updates were hardcoded for a
> SC/SP configuration.
> 
> Fixes: dc39e2f359b5 ("eventdev: add ring structure for events")
> Cc: bruce.richardson@intel.com

Bruce,

As an original author of this file, Can you review this change?

> 
> Signed-off-by: Mattias Rönnblom <hofors@lysator.liu.se>
> 
> v2:
> * Fixed issue with update_tail() parameter order.
> ---
>  lib/librte_eventdev/rte_event_ring.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_eventdev/rte_event_ring.h b/lib/librte_eventdev/rte_event_ring.h
> index 29d4228..827a320 100644
> --- a/lib/librte_eventdev/rte_event_ring.h
> +++ b/lib/librte_eventdev/rte_event_ring.h
> @@ -99,7 +99,7 @@ rte_event_ring_enqueue_burst(struct rte_event_ring *r,
>  
>  	ENQUEUE_PTRS(&r->r, &r[1], prod_head, events, n, struct rte_event);
>  
> -	update_tail(&r->r.prod, prod_head, prod_next, 1, 1);
> +	update_tail(&r->r.prod, prod_head, prod_next, r->r.prod.single, 1);
>  end:
>  	if (free_space != NULL)
>  		*free_space = free_entries - n;
> @@ -140,7 +140,7 @@ rte_event_ring_dequeue_burst(struct rte_event_ring *r,
>  
>  	DEQUEUE_PTRS(&r->r, &r[1], cons_head, events, n, struct rte_event);
>  
> -	update_tail(&r->r.cons, cons_head, cons_next, 1, 0);
> +	update_tail(&r->r.cons, cons_head, cons_next, r->r.cons.single, 0);
>  
>  end:
>  	if (available != NULL)
> -- 
> 2.7.4
>