From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0057.outbound.protection.outlook.com [104.47.42.57]) by dpdk.org (Postfix) with ESMTP id 807A81BA46 for ; Wed, 4 Apr 2018 02:52:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QZp/akmD2PwZ/Pk8CysBttjWjgwa0eD0+53bS0TB5OQ=; b=P2sY/6wod2qEsk2DJ6sQSjlJQ+fiXSAnuM7Rd1kn1q3lliOkufPU0ckt6bwS7wx3NfhhVajl+g/9DYgAhuTdGGP46UcNdQjZ7NcisY/F8BlR0y+VYS/PCEtXekMiPUuIY9WU8i8UrKKrkIAZex7o96/P6SmVu8BZGUMXmoBhDEI= Received: from jerin (106.200.202.48) by CO2PR07MB2518.namprd07.prod.outlook.com (2603:10b6:102:12::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Wed, 4 Apr 2018 00:52:44 +0000 Date: Wed, 4 Apr 2018 06:22:26 +0530 From: Jerin Jacob To: Mattias =?iso-8859-1?Q?R=F6nnblom?= Cc: dev@dpdk.org, bruce.richardson@intel.com Message-ID: <20180404005225.GB3031@jerin> References: <1522228611-4838-1-git-send-email-hofors@lysator.liu.se> <1522743543-7974-1-git-send-email-hofors@lysator.liu.se> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1522743543-7974-1-git-send-email-hofors@lysator.liu.se> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [106.200.202.48] X-ClientProxiedBy: MA1PR0101CA0071.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:20::33) To CO2PR07MB2518.namprd07.prod.outlook.com (2603:10b6:102:12::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64014968-f7b9-40ff-b61b-08d599c66179 X-Microsoft-Antispam: UriScan:(12572780692934); BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CO2PR07MB2518; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 3:ccBYnY8sE8EslPL2Dm0ZTkSVgCrCeltH6YUTVT2HohMgWCHVCIJybhHVvCqyp3hPcrldkRTaxRTT1LXBdCExJyM/KzTRLYJHdiRl/a79uRKeIVFmAbaOJmzW1PLp2Q9ntiZUkDEd4tuYkIklUnObQxSWhKIrPzs4GLz17cnmqMjBvMbuqxaT+hGpyaDSTAABMjTzhlxob0JBq5ZSfvF13j0yCwr3FlidosGzQEa5DFEKJB/N14TkvP2rHf1LKo6ygAISb6h/Y4rSwD0w76mHoJnXDdAzhyyq1WA5Dyo+ab0=; 25:M1zGmt2+/+FYNnoNzS16mwgNdqOEyTI9NYufKoWjoCWvCPWe47XIIrBIOQgcWODB6mgw7gZK+JamuOAdQVqzspmHrqoHEpZI/Rc1/Us1wqxoSHRPjJoVqsXERFJKFZPBAUKib5RmZJzH8HcH5OX2R44Hmxz7+enqYkAbXMFoMZm9DvwAvRwyqNeOYdLuS8HD+ejvAeoSkmQI0GYRCU02vQ9SJvEV7Y81sJ9Ivjd5czwM3sHsa/uL6lEf8Uei9ooSBCAo/5eSorPaKcP4YZHPn9dx8gQSIftpzRZfLrH9dYPbT+j+ZzkfaRFOOIgBMrnH0X12zsH+P8E9jlaRulKv8A==; 31:f6P1e5TuRuiIQ4PL7i2ZgP6NHCsjSY87sHnQcX8n1xhOsdA4uOxAr0R1abiXFjy8gcnrxoJIcJSKAWwR2JsoVX9mynWol78doXoHAmtiWpASNoomn3lbVCSHOf9aWgxhuBIXWsqcErAcf5CncgQft2xCpnPt5folXnwdmc29Lu1SfW6aSjEGwxI/Bf0SxWpTfysDryA5avD/Gzmt6br9o9rdhivPZ7/tJ041t+c5Qmw= X-MS-TrafficTypeDiagnostic: CO2PR07MB2518: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 20:Wxjdq/c1Rznfb3yMDvJy64YKfSke9KwRME6o0jcnvWCEix1FdfxJw11QhljXgNc0J12XpiUzRCFExDSnzwQdKz62urwiC29xk2m4qRL0cn3TbidGeDNkYNaHqHi7ASJO63jLmDzHAAmbHvr9rOTeHT+BLOOXEoKJTWy/syJ+wKEkJD5wRxOBIcISTb6mfeuMCDFdIDnSsmRXwjG9McPcbjuPB23Nwhp4knyP15fHRhkc4coAhBTZm0+zbmOb63Q4kPovDbnt8TVMdCDrsMIH7RP8YfGVKgKI9WKg2svCe25ibmogiuBpjfuC28FISae6dEqGgw62vbEnOKkMh2ZAfVRwTWN3MZJSOe8/CbHhVhY6SDf7ynH/cR0G8wHcqGudd0Ae5UTze3zNUXqfk/jjg9kKno5FPVzuz+4meFv4TB0Gh6KN/dzM8546GwFPGrPLZr7SVavQr9FRSkaR6kWGDvOwKmka/awuFmX1H3uwdGPE+Ozaze1Sdxa60WrgBjxaRidBF1JsQn26upDa1Txqd/unuF7kAX7XQECzvBQjQvS5MKSyD9mbLSQ8Yh8+lo2zKe1RMeus0IP+assTjPLMKWOvdMtMRNbfB/Hdftxb/c8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(12572780692934)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(10201501046)(93006095)(3002001)(6041310)(20161123558120)(201703131423095)(201703031522075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:CO2PR07MB2518; BCL:0; PCL:0; RULEID:; SRVR:CO2PR07MB2518; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 4:Xx7xuFilbwG34T2aEggVIUu/m5HjB28ESEjMWQCyDLBShSGlwpsX41/U5XbAJqvGGFBYQrgV6jB1VBOzMMEUn37IWXc3vI/vOq91uREG097BsRdlmRTW5LDHyhfI0piuGFPhhz8TANiUr6HEcnAuU7QP4ro2EEX56RVDLpiyizBdHgIl4ZGAeatYgW0/3/DqNo2hGfqapP52CFXk1MWbJSOx/p0aC4KkQUEPKjtvAvhVZaI7TXtNMFhqmoF2JDQSBbWdC13ovTeI/YTD8yIrVXv1Yq7CwaHpKO9y4Bu1hfOPULymJNnkruq+fwBIYjhzdw6P9b1HP+WbED5qOC3+FgrVL5WMQJd4pNo10zzLJiY= X-Forefront-PRVS: 0632519F33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(396003)(39380400002)(376002)(39860400002)(199004)(13464003)(189003)(11346002)(52116002)(106356001)(50466002)(8936002)(2870700001)(2906002)(47776003)(66066001)(8676002)(81166006)(81156014)(33716001)(42882007)(58126008)(33896004)(76176011)(486006)(105586002)(5009440100003)(476003)(68736007)(72206003)(478600001)(6246003)(7736002)(956004)(6496006)(446003)(6116002)(33656002)(305945005)(9686003)(229853002)(97736004)(59450400001)(6916009)(23756003)(25786009)(5660300001)(186003)(386003)(316002)(16526019)(296002)(1076002)(55016002)(4326008)(15650500001)(6666003)(53936002)(26005)(3846002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2518; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; CO2PR07MB2518; 23:TzPI/VSql9jo3eAO9GxrEMBh8I6xtUvNg5VFc55?= =?iso-8859-1?Q?JDqiOBkg3h0xu8ITnvLBwWDgUmqcLV2lyaKqF6jZe7sHMH+U0LkRdPLa4k?= =?iso-8859-1?Q?jUT0R8/Maok+DHM43MjkebZ5/4KPUX6P0Dh+CQ622kpjrTgPkJ0JLgAc8E?= =?iso-8859-1?Q?eNxryqZF1/dbLTtc408ksSeq7JxjubocS346pFaNzLSyqmUirH8yVBtreK?= =?iso-8859-1?Q?rlnqPiHwO3YmLXKCNWlQuwCBtlxV+fBfw7ZzIatn9HJUdlGkQAghj2xPvV?= =?iso-8859-1?Q?mnCq1BcqnfQPTz2Pf6S23zZQNUspnDQr2UpVbr7EKJNldZRzBU0Y/Pf2JC?= =?iso-8859-1?Q?OWXH9UmAhTbC8TIpRkl6cK4LtaZ3FoBUBcqFYoyPJnuCeQV9UB1/R4QZrB?= =?iso-8859-1?Q?4B96Uq63Idbs9D5LO7i3UOuLXS1px5+rZ5n9Y0Auy6tpvFNXpaAqY7nXcS?= =?iso-8859-1?Q?dHx+QxcuYneV7ZJp5AbdCxXW3mbfxo9Nv/xbRE+jXpwRLcPqAF2Uz+4E+I?= =?iso-8859-1?Q?8un/NW/D+ihuaiTzoqTXfUc6GQY7uu/riYMEoMFW+XXvvLvn/scqeWsWQh?= =?iso-8859-1?Q?Vk2Zs74vwEJyKJUz5wFI+Fpew0fwRKtJbXCu3uiuwwH/USe+qMte6CLKrS?= =?iso-8859-1?Q?Aha2sKzF9IDY1J7E29+2Sq93i6JkHy82j2pgnhTDNkb51i5JIg8/Y6t+wa?= =?iso-8859-1?Q?q+66hK9SOJIxHXUC/6XPFkyDFUgf4wHEp7ep+lV3mYKhSfOaUiy7YX7v3x?= =?iso-8859-1?Q?mQH2bEGpuLbt7oyIy5FC2TnMjqFC+TlnwcK/BRtj5wLcifwDEC2wioa6Aq?= =?iso-8859-1?Q?MEGgRHkOnjGiOiWG7B+XT3D9OgzGyMBzDK6QZE0179iRfzBRpuotwGDRKf?= =?iso-8859-1?Q?CDQ/58pwAR8aNK3rgvZ/+dZKN/cOo7v2hTpeehofkCdYq8am3wELf13aCU?= =?iso-8859-1?Q?O8Gv7MjllNvJaGNnrJDNzMwsnRRUcD/jY49Y7TDIMPun4OzGzaSvlJN0fx?= =?iso-8859-1?Q?KW079T3ErLPSqxl6QCqNzjxesWS46LNzUeecTobkVxLD0694CA4iNbm0+m?= =?iso-8859-1?Q?tR1IQfF/lvKcYVBSvSAJe/I/ph+j84dzxrDvenEbTFbsVv/jxq29+XZ49D?= =?iso-8859-1?Q?dwcIhzxave5rdPmjbFwRhh/4HPSBLejh4ASwzgb2R/RjbDpdVViZC6Hv7a?= =?iso-8859-1?Q?3lJmhXu3wnBcRwpu7b6Aa1G+wtlKQfLWRGtBaTJL5e4NVwXGNbIcr+Ux0t?= =?iso-8859-1?Q?hVRTUZ9vuO5ko7+UEsW3jan9cNg50m8gjsjUk52t/xKlQAskEuIXWWa8HZ?= =?iso-8859-1?Q?v54H/Th8PAh1bw62aAHuMkXxWtJcx6QWmQ1kmxIR4+gLk1M5WWoTYuU6vX?= =?iso-8859-1?Q?5xelGL13LbzgRcAraqngFLLKfgn16jfLIBailZ9UctoHQcGvYUbkUY98Tg?= =?iso-8859-1?Q?ysUH3l24a5pWznwBgiH7LQTrjLnp7+yDPwF8whYiHodHiupYMdiYdy1Ww?= =?iso-8859-1?Q?=3D=3D?= X-Microsoft-Antispam-Message-Info: XPsk+G2Ay42lx8iS5ae0zOt0W/+7ES6qYzhA9BC0cfPE5p1c8S2CHPbX/i5lBJXyQ4khkB1P7r3g9XxyWmoHtVbjA3lMaq7gb9xtTcwv55D2NSvwcybCFrYOFKHFdVwW0jjXidOR+mX0JUYHgq8I2hRplJ6/mOS9Fx5mjYIsj67a6Ll0Dma4ya7z6gh2fe9b X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 6:ro9Yw6Sc+/aPP4qLR88Bhv00fczeTrJasWQUiJFybaEiKsu9m4Pom83qOBs8NGXZiL/D895xGUa3qvj8JoPRqDPVv6xkqICbI8fPtwoMg/qAqGNPXeSZgqxWAvI6upEGcHGKKgW9WiAitzNvprOvCgKN3bC9tnMv4m3aBNHCna2EdjZtcUOf42jHM+pZAWud6LUouGQ/oNKQurGP0LqFdi5p3wLMlzw5Kbr+HeVC2Ds587Yqdr/ofEmJlBuqQ979eZYR2sPcI4v9JaospkS7+rWPwlK2TzUwP4OfD71qZYL1pLjq8py37GmMIdbkQn5hYRXoEFAvlHNNt2htHxakAIi1eQMW9NCj/EdNeJ+V6EX/1vn9BgXqLQ3EfMjxuAZzLk5KCgcb1dasIXh5jNnT3XTQABOhwOlWWr6Dymxyjb11uyEZWB3DmKLBuP8nhLXR3ijL7a7nJWisY8uNqPTDsQ==; 5:0AQBfNyXXmL63Btz4J375bwNGblKD7qXM9CDlNzA6JEbdV1Y+B2AyPRSAJemQXgSyLDHMV1UpiznBxXYcGCqqsAH29DAbpoFOY3PwWNvxe58zHiJ1hB+ja1F++CGDGtx2sSsquKArkrSsraSgZmEnG+S5+0GjNmSmZPP7Jb6xjs=; 24:yDMbLCpmUkXj41WV/ZxV3GKbksQ+Hm+SrVjHrykMRD46oVHk6kXmGApuouDa1VqVT14f0mSMGg3fmBFdtNo3m+XgXm28E3UV3fNbTxhEGTg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 7:U55Cyqi6rTbfWtkSn2Djd0QcPzqhuaOBFpDTFs3jBaxq4wSK/rhf+W9+6YK/Nas5QuX8W0i5b5xE6HKXJvyYi95iSo91FXFdZMHWN0SfyX+P6DaSnAlGLZoMopTM+bXDXMUhSj1GHCG0c0QURshTNO0pP5amh5HMlTpwFgLTOPpAdWpgomFT+Cxv2DvCznOs0rUDRO4SFtigJPYSUfRHZihZG8l2B4Z5hxTCG++r1V+OVkfMCU9VNlvSAN71PpIm X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2018 00:52:44.4952 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 64014968-f7b9-40ff-b61b-08d599c66179 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2518 Subject: Re: [dpdk-dev] [PATCH] eventdev: fix incorrect MP/MC tail updates in rte_event_ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 00:52:49 -0000 -----Original Message----- > Date: Tue, 3 Apr 2018 10:19:03 +0200 > From: Mattias Rönnblom > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, Mattias Rönnblom > , bruce.richardson@intel.com > Subject: [PATCH] eventdev: fix incorrect MP/MC tail updates in > rte_event_ring > X-Mailer: git-send-email 2.7.4 > > rte_event_ring enqueue and dequeue tail updates were hardcoded for a > SC/SP configuration. > > Fixes: dc39e2f359b5 ("eventdev: add ring structure for events") > Cc: bruce.richardson@intel.com Bruce, As an original author of this file, Can you review this change? > > Signed-off-by: Mattias Rönnblom > > v2: > * Fixed issue with update_tail() parameter order. > --- > lib/librte_eventdev/rte_event_ring.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eventdev/rte_event_ring.h b/lib/librte_eventdev/rte_event_ring.h > index 29d4228..827a320 100644 > --- a/lib/librte_eventdev/rte_event_ring.h > +++ b/lib/librte_eventdev/rte_event_ring.h > @@ -99,7 +99,7 @@ rte_event_ring_enqueue_burst(struct rte_event_ring *r, > > ENQUEUE_PTRS(&r->r, &r[1], prod_head, events, n, struct rte_event); > > - update_tail(&r->r.prod, prod_head, prod_next, 1, 1); > + update_tail(&r->r.prod, prod_head, prod_next, r->r.prod.single, 1); > end: > if (free_space != NULL) > *free_space = free_entries - n; > @@ -140,7 +140,7 @@ rte_event_ring_dequeue_burst(struct rte_event_ring *r, > > DEQUEUE_PTRS(&r->r, &r[1], cons_head, events, n, struct rte_event); > > - update_tail(&r->r.cons, cons_head, cons_next, 1, 0); > + update_tail(&r->r.cons, cons_head, cons_next, r->r.cons.single, 0); > > end: > if (available != NULL) > -- > 2.7.4 >