From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0083.outbound.protection.outlook.com [104.47.42.83]) by dpdk.org (Postfix) with ESMTP id 2EF361BB29 for ; Wed, 4 Apr 2018 05:29:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PhRJmIvqFKCcJhCHzBMfIP6Yvf12IAfQYeFBfBpnvaA=; b=Gwzd51GEOpoBm0fYzcxbg5jHNGYAkSLuMwwHzqQCUr0UaaQiCd754a9cmvjMB6Dl5Hfq/xJy2x6/Tf3ekcQ1Gp1EVa7GLBTIzQfoF8Xrd+i+63v3PCMOj0oHgColS3t9haym9y5Mcjp7aNvXbLoJY7NOdg9jvT/nul0xM0H4zBI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by BN3PR07MB2513.namprd07.prod.outlook.com (2a01:111:e400:7bbf::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.653.12; Wed, 4 Apr 2018 03:29:37 +0000 Date: Wed, 4 Apr 2018 08:59:19 +0530 From: Jerin Jacob To: Pavan Nikhilesh Cc: santosh.shukla@caviumnetworks.com, thomas@monjalon.net, anatoly.burakov@intel.com, lironh@marvell.com, bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com, dev@dpdk.org Message-ID: <20180404032919.GB8574@jerin> References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com> <20180402091000.9208-1-pbhagavatula@caviumnetworks.com> <20180402091000.9208-2-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180402091000.9208-2-pbhagavatula@caviumnetworks.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN3PR07MB2513.namprd07.prod.outlook.com (2a01:111:e400:7bbf::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09e2cb9b-e518-442b-777f-08d599dc4d17 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603328)(7153060)(7193020); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:xnm0afz4VmCN/EfYuwJH/gqeIOi0Ayy7isPHJ2CVRs833WRou6s0UqLtTC3VNdLe5SQX9KtCtV+MRfvFv33z+v6F4yEgJ52+zAKAz1w0MGkgFuWWhjUgzq3BiSad1/MvYILXtFu37Fq1abamFq3TXb6xi7ljQf+70CX6ruymWFN2MrW/qZiuMJxO+JmGfvO5xRqeA8spFyCn+kBYnBxtUsIMh39EQ4BhQ3GWS/mDk/Gp7okC7+2usCug9Zqn2w/8; 25:EF02JPFvk6YHgSFPvvCtgYF6OchTaAQ70anHhOPxVnezYYlWMT7bWVWAfCv59cakYUP5khO53ts5tqOBaJ08R6t3LGsRfHL8wm+4SLL+2DYewxnV5AwTh0ucRC2ThR/12RzuM9e56U0mxdXfMt7E48bHis1ZZDXiPqEZq+kKgUKHibcz/5Q+ajMvI2CnyIv9v9N2sMSBiCRs2cq4OZd4SYpeNQ3rhy9aTopjYECUzBfocxSDv8+oRNBY4qXOhZZSg1YmQp6lkfv224gA8m2vJXXxRI/Ku0Ew6RM0FYbU8aQrcXWbfhIeeK9feoHIJ7h3r+GeLmDgjyr+r6plN39u9w==; 31:GfwYcvc32mOODl7iOHHuwwDimQnd6O6Qy17b2M2w/Y2VNcDVkfRYiB21U+HjofLAXr3ufY7arH1WFPyAUx8nn9Gs5r36Hh5xwUpikyRzbCPjisMWXw8TKgeWVhpx/H6tqJH12p7eYZdr07ylI9S9CdzGOrDT278FpRlD7JESXruQH3xTRovpNdVDJEs78vfIKsf9i7vyszHMJH7AAwQnufzE0UooU1RVA8Qf7xVqxUQ= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:9PYP7I55u4tpbvxVHY2ql/5tpf5uqZr+rAy9DXYLobuJ0ZwuM2v7VaRVS88TRwXp0miq/35IrM4NZiNtCkQ69rv04a9fUQBVbe5J+6g4TzOBhPMsA7+7aZP7awg9XTB3Jfq8b/tqbE4V0Gi6dotGqKjeoZqc+nW4H5Ee/NCQYmrrcpT9xPdOzTq2EDuMZmNsgaKT7G39WF7n6aHhpcuJumvUt2dWCJw+KJUFjWFePszK4tu/6YXF1NLhILvek5POAt9UM+qqQw2ENa/fNZMj+xkrIqMI+bNY6KCkXBrTME4phJZuNJTXP3B4PVPaaGJ+89gOVBJnMKaVYCGmilzDLRJhYbq1h+ZPHlBk/65h3xXKavOQlWqi3RJA7OXZVKYUvineTi9j/crL+txWOve19Vl2od/L8vgViVyOGlDtIo5oTZiWFkRBgXgWegX0YwdxEcgBBuAi5zKn9F4j6mmKFZMVPOuspMlL3b/X3h5lHQMaQglMzLlSNBqPcJIyUJXDj644Etnj9bgcZvzUwgh5tMWTHnHrePy5GC6LVU9/ecAANQuPGIZOP/70s0UEzbSX+clQL1gst061U1+5Nh33EUmMsTG9yEck4y+21JvnrFw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231221)(944501327)(52105095)(93006095)(10201501046)(6041310)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:; SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 4:m52jm7c3dwey+X7Ncbk3OsKpDAAhZ3Ymr/oHuqb8bDj47Oxym4w4ttq+tc9kq+zEFIPd2dIXI6xwF6usdmXetM5tGdLuMDgyWewAtels/bdjVxqPvw2mMhHjtPd4BK4oBX3opHFHl0YQIZue6etZl/FVOxtaVw75EDElUKisZJ1AmiIOR+fz4rg0aXtg5s8CMIlK0V2ZMQNiVhRKe7FstI/xpJNZp7VeuXj1lsF7ZqTesl186f5jqL04McJMgoJi32nirTNkpTSXR2sRvbfIM8Lw0RUt4onNQley22/0Qjhze4KF4yI3Ld+4kT134uPIgDhIKB1dBzDOXb8qvbVxqs1uhbmbQXjp+bSyHwEradE= X-Forefront-PRVS: 0632519F33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(366004)(346002)(39380400002)(396003)(13464003)(189003)(199004)(66066001)(3846002)(6862004)(6246003)(23726003)(478600001)(1076002)(2906002)(5009440100003)(6666003)(6116002)(68736007)(6636002)(76176011)(486006)(9686003)(47776003)(476003)(53936002)(42882007)(25786009)(229853002)(5660300001)(4326008)(33656002)(446003)(81156014)(50466002)(956004)(305945005)(7736002)(16526019)(26005)(16586007)(8676002)(8936002)(81166006)(58126008)(316002)(386003)(33716001)(8656006)(106356001)(6496006)(52116002)(11346002)(33896004)(105586002)(72206003)(97736004)(55016002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2513; 23:eansrGuenF/o09Kn8Hb80Pm0AyUPvr+2DB1TI39ba?= =?us-ascii?Q?7pAUD3Q/VDCgwnTm89Hi6B0DO0YwGAwvK7KeEPR7A7jZHcboeWSxkjUnfVhA?= =?us-ascii?Q?m4eeSu7lbvEPJrV17UWPTht9/vbmbZgqybKF/h4BAbm3rDNsS7WBYMJytz65?= =?us-ascii?Q?OMeuH12DgkX3oGq4IXWeVIti2eJqA0vxhir63xfDwHQB6JmvsQTJj4Xdbioz?= =?us-ascii?Q?r+2L7ZhfUUGJagA0wWKyLhlYchGsgDd0BVGWRIio/ZF91dpQh44/wv5wxVo7?= =?us-ascii?Q?r1J58X3/1yY5/wNUu3eUz+u5z+n4KMmaCatzM5/3ChGNfUpeThCMpUmzDkyq?= =?us-ascii?Q?QuBOF6yNvRyUxoQh1n3AT0S73iJ/jvZ64yE9QZCYPjzpz627byejpMT9DMXK?= =?us-ascii?Q?mAS+7r5ABIYzeGkYgrAtFkM3LSAkJkqhyOo72MyVJQ1EgIC8HBSl0nh+ezlK?= =?us-ascii?Q?/idqn2wBpzkGgiTyG+QtRm9/TMUULr1ypaR7lp+stbeD+uQzj6m+F8Zq404p?= =?us-ascii?Q?ssrCF+nGQhfUBbTEWtc3xjlWpKvEoZdVQwVx9VsmocCpsWxqXy5TujwdLFtM?= =?us-ascii?Q?Q/EsEdW8tOTCyk5CneGrCay7iZBuesx18Yxqr69m8sTMylYoYmhPh82eT5T5?= =?us-ascii?Q?EzgptbPI6+p2KwTjSuGJoEx9pO9nHVbnS6JOKei+ff5Qbu6GoIrdUnaeu7C/?= =?us-ascii?Q?fkLkBl5Yu8Lsb3tTVECXCSySCdgjcafMiJlJE5zrVvAfa718pyGhqH+LSukW?= =?us-ascii?Q?ek4EadNdfGiJU6KmE+b58+St6f+4PS+rgyAcKrF2SocrKycLPpguJ4JrZ53/?= =?us-ascii?Q?FcbAzuSoxAl/0SlRkqOXgLqDYazFy0rXFyASVT6Oov303UVS01oYAbumstz7?= =?us-ascii?Q?QElnH4jd+AQyhi3MKBhGsb/nLL4W42Mx1C8DkGHotSKANFg713vT/++4e2BO?= =?us-ascii?Q?4dNlAmDKAlNehAq91vYYGg+xJ845gdw+M6Uh2XFHvC7wExrGlQ+4ASdMMLpl?= =?us-ascii?Q?vGPZckLVWJxPgWgFd9lpGIinOBAKb84kJizp3xjnMj6V5+kCKlr9bY2JTbCR?= =?us-ascii?Q?crnzc6V2HD55VMhgs7w7DZS8ztC2Fq/GAhHaMnEGi0NAoSleiUxU0PT1OmHF?= =?us-ascii?Q?dL/Y6Ir0lexqqVXryPuz6bL84tjn9gpRNGfDE4VcKcGRS3Kxo6oo24myYgto?= =?us-ascii?Q?mCaE2nGVe0Rs2KebIXYmZl2nostdjqPmYOy53pNVK6+YzdeDonHwrtw6mNw2?= =?us-ascii?Q?GXk+Pdv1y8p5iSmQIMkraQyxjPgNy8JDl4YVe5CEvrPxPwzkvXb2r/EomDDo?= =?us-ascii?Q?I9rzS2zhQdRK4caHWZ9OrHjnl/aFXuPtGzas273WKFh+Cj/WSMhLPEqHFHeE?= =?us-ascii?Q?FEG3A=3D=3D?= X-Microsoft-Antispam-Message-Info: 2fNowUDDbny/jLR2VHQj2mARn9fbY4MUKO8OhAeMn+zYxXMr+I2Cd1fFc7ENdsD5cXhi4eTEbXRdvDjlS0lkGZnp+p974pbHdi2cylpzZB0VbB2XtcUaBG0pzghBnqajoQyIq1q3OaaAd5GMEgG1qyd70EmGmbfqGBePCtWDBgYkg+xVAUD9f7Qg47tGrTqN X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:SABhamC/jqLYQ+8uasYKuJ6U/xRXN1MkKdGz/p0KHnyN5gQdKCHg7rh7lTkXeTUgG1IDhGVnZXEWFg4Xv76K2XYc2VNx/QDIMpLsiTIp4fliF4cjy/gcOqZNBgscSN1a6of86NoIP3wXoPqabC8j6CnOsHOTjWvpZPINaYyWGmMamkDm1f43kTDQ0vNpWW2YIUMPg8ULpGo2aHnm7tVK7HEUtL+uj38rv97AeHmQ41iBsKoe6sYfA61u2wSLUP/nd5+WXiD9qboSQ8SRr5KAj/VF75dikPWTq7K62XmBETklZKBC9jPSYUmNmFpOwFenS0k8YWnALDL8fkQF65wcyuM7GyvkazrEufFwIP5RN4KULaYNhKXPGeOgzjfyf3oK+N5emEgRzBi1yHQtfb8/uyhPA6On4TZKT/LbDu1zR2vRPXpK3+9GDLsZXVf1umHFDXgsc5LLySGhnOzEK5dYiw==; 5:5xdrKjt8vpCvheAWpMY82Zf13E+f7g067qNlE6ynDWt+09oRjBnydawnC51ShqhN9h/TKz97EJ9mJIVEWzZx74obHRjRVeh/lq+IJc18KCTrvZYWgYva6yUpLHsvZs7i1ZbYRlt+oPAkSV4XZphT9f5qWanc3n3KalZnxms8V5g=; 24:3fs/2ye91M0K/wlVicKdpHb3AU4RhK19VX6W8M3vBdrizCOe+iBZQrFNprL/pKsdYR7PVTV66eQaHNJbk/eCNB3KpTZLQmyF0Ea8NqHfYBE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 7:kcV1XRQz1YiuHGFZy3TWYMD9/vzjh1yHe53IP8NlFWhyH/cjHG3I3xhaz4P63mmeM9X6lMggT1B52oTS+wWi3R3KsNNpkOI+M5CzKwR639JQ7qdtwNeDgHFbNiPKGwm+1VCbjngfUyteEH/PMB36fNZnfyxxowcsXD35xv8hAEneyGqQjJN/zkkxWZ7fVN0cSVThrhE95dGdbOyYwMP8rgxSoHqu59u6Kom794oRPTXgbDuggmgMtv63zhDreYMc X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2018 03:29:37.3041 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09e2cb9b-e518-442b-777f-08d599dc4d17 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to common folder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 03:29:44 -0000 -----Original Message----- > Date: Mon, 2 Apr 2018 14:40:00 +0530 > From: Pavan Nikhilesh > To: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, > thomas@monjalon.net, anatoly.burakov@intel.com, lironh@marvell.com, > bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com, > hemant.agrawal@nxp.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to common folder > X-Mailer: git-send-email 2.16.3 > > Move commonly used functions across mempool, event and net devices to a > common folder in drivers. > > Signed-off-by: Pavan Nikhilesh > --- > +include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/drivers/common/octeontx/meson.build b/drivers/common/octeontx/meson.build > new file mode 100644 > index 000000000..8a28ce800 > --- /dev/null > +++ b/drivers/common/octeontx/meson.build > @@ -0,0 +1,6 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2018 Cavium, Inc > +# > + > +sources = files('octeontx_mbox.c' > +) Does it make sense to change to, sources = files('octeontx_mbox.c') i.e no sepreate line for ")" > diff --git a/drivers/mempool/octeontx/octeontx_mbox.c b/drivers/common/octeontx/octeontx_mbox.c > similarity index 83% > rename from drivers/mempool/octeontx/octeontx_mbox.c > rename to drivers/common/octeontx/octeontx_mbox.c > index f8cb6a453..c98e110f3 100644 > --- a/drivers/mempool/octeontx/octeontx_mbox.c > +++ b/drivers/common/octeontx/octeontx_mbox.c > @@ -11,7 +11,6 @@ > #include > > #include "octeontx_mbox.h" > -#include "octeontx_pool_logs.h" > > /* Mbox operation timeout in seconds */ > #define MBOX_WAIT_TIME_SEC 3 > @@ -60,6 +59,17 @@ struct mbox_ram_hdr { > }; > }; > > +++ b/drivers/common/octeontx/octeontx_mbox.h > @@ -6,10 +6,22 @@ > #define __OCTEONTX_MBOX_H__ > > #include > +#include > > #define SSOW_BAR4_LEN (64 * 1024) > #define SSO_VHGRP_PF_MBOX(x) (0x200ULL | ((x) << 3)) > > +#define MBOX_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, octeontx_logtype_mbox,\ > + "%s() line %u: " fmt "\n", __func__, __LINE__, ## args) > + > +#define mbox_log_info(fmt, ...) MBOX_LOG(INFO, fmt, ##__VA_ARGS__) > +#define mbox_log_dbg(fmt, ...) MBOX_LOG(DEBUG, fmt, ##__VA_ARGS__) > +#define mbox_log_err(fmt, ...) MBOX_LOG(ERR, fmt, ##__VA_ARGS__) > +#define mbox_func_trace mbox_log_dbg > + > +extern int octeontx_logtype_mbox; > + > struct octeontx_ssovf_info { > uint16_t domain; /* Domain id */ > uint8_t total_ssovfs; /* Total sso groups available in domain */ > @@ -30,6 +42,8 @@ struct octeontx_mbox_hdr { > > int octeontx_ssovf_info(struct octeontx_ssovf_info *info); > void *octeontx_ssovf_bar(enum octeontx_ssovf_type, uint8_t id, uint8_t bar); IMO, prototype for octeontx_ssovf_bar(), octeontx_ssovf_info(), and defintion octeontx_ssovf_info can be moved to driver/event/octeontx as it is the only driver is using that(i.e no need not to be in common code) > +int octeontx_mbox_set_ram_mbox_base(uint8_t *ram_mbox_base); > +int octeontx_mbox_set_reg(uint8_t *reg); > int octeontx_ssovf_mbox_send(struct octeontx_mbox_hdr *hdr, > void *txdata, uint16_t txlen, void *rxdata, uint16_t rxlen); > > diff --git a/drivers/common/octeontx/rte_common_octeontx_version.map b/drivers/common/octeontx/rte_common_octeontx_version.map > new file mode 100644 > index 000000000..59dbed5b2 > --- /dev/null > +++ b/drivers/common/octeontx/rte_common_octeontx_version.map > @@ -0,0 +1,9 @@ > +DPDK_18.05 { > + global: > + > + octeontx_ssovf_info; > + octeontx_ssovf_bar; Same as above, move above stuff from rte_common_octeontx_version.map > + octeontx_mbox_set_ram_mbox_base; > + octeontx_mbox_set_reg; > + octeontx_ssovf_mbox_send; I think, octeontx_ssovf_mbox_send can be replaced with octeontx_mbox_send() to inline with other APIs above(octeontx_mbox_set*) > +}; > diff --git a/drivers/event/octeontx/Makefile b/drivers/event/octeontx/Makefile > index 0e49efd84..34dcb844c 100644 > --- a/drivers/event/octeontx/Makefile > +++ b/drivers/event/octeontx/Makefile > @@ -10,10 +10,11 @@ include $(RTE_SDK)/mk/rte.vars.mk > LIB = librte_pmd_octeontx_ssovf.a > > CFLAGS += $(WERROR_FLAGS) > +CFLAGS += -I$(RTE_SDK)/drivers/common/octeontx/ > CFLAGS += -I$(RTE_SDK)/drivers/mempool/octeontx/ > CFLAGS += -I$(RTE_SDK)/drivers/net/octeontx/ > > -LDLIBS += -lrte_eal -lrte_eventdev -lrte_mempool_octeontx -lrte_pmd_octeontx > +LDLIBS += -lrte_eal -lrte_eventdev -lrte_common_octeontx -lrte_pmd_octeontx > LDLIBS += -lrte_bus_pci -lrte_mempool -lrte_mbuf -lrte_kvargs > LDLIBS += -lrte_bus_vdev > > @@ -27,6 +28,7 @@ LIBABIVER := 1 > SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF) += ssovf_worker.c > SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF) += ssovf_evdev.c > SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF) += ssovf_evdev_selftest.c > +SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF) += octeontx_ssovf.c s/octeontx_ssovf.c/ssovf_probe.c see next comment. > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > CFLAGS_ssovf_worker.o += -fno-prefetch-loop-arrays > diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build > index 358fc9fc9..1181f337b 100644 > --- a/drivers/event/octeontx/meson.build > +++ b/drivers/event/octeontx/meson.build > @@ -3,7 +3,8 @@ > > sources = files('ssovf_worker.c', > 'ssovf_evdev.c', > - 'ssovf_evdev_selftest.c' > + 'ssovf_evdev_selftest.c', > + 'octeontx_ssovf.c' I think, it makes sense to change the name to ssovf_probe.c as all files in this directory starts with ssovf_* > ) > > -deps += ['mempool_octeontx', 'bus_vdev', 'pmd_octeontx'] > +deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', 'pmd_octeontx'] > diff --git a/drivers/mempool/octeontx/octeontx_ssovf.c b/drivers/event/octeontx/octeontx_ssovf.c > similarity index 92% > rename from drivers/mempool/octeontx/octeontx_ssovf.c > rename to drivers/event/octeontx/octeontx_ssovf.c > index 97b240665..c32b49a01 100644 > --- a/drivers/mempool/octeontx/octeontx_ssovf.c > +++ b/drivers/event/octeontx/octeontx_ssovf.c > @@ -10,7 +10,6 @@ > #include > > #include "octeontx_mbox.h" > -#include "octeontx_pool_logs.h" > > #define PCI_VENDOR_ID_CAVIUM 0x177D > #define PCI_DEVICE_ID_OCTEONTX_SSOGRP_VF 0xA04B > @@ -142,6 +141,7 @@ ssowvf_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) > uint16_t vfid; > struct ssowvf_res *res; > struct ssowvf_identify *id; > + uint8_t *ram_mbox_base; > > RTE_SET_USED(pci_drv); > > @@ -180,6 +180,14 @@ ssowvf_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) > res->domain = id->domain; > > sdev.total_ssowvfs++; > + if (!vfid) { vfid == 0 ? > + ram_mbox_base = octeontx_ssovf_bar(OCTEONTX_SSO_HWS, 0, 4); > + if (octeontx_mbox_set_ram_mbox_base(ram_mbox_base)) { > + mbox_log_err("Invalid Failed to set ram mbox base"); > + return -EINVAL; > + } > + } > + > rte_wmb(); > mbox_log_dbg("Domain=%d hws=%d total_ssowvfs=%d", res->domain, > res->vfid, sdev.total_ssowvfs); > @@ -213,6 +221,7 @@ ssovf_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) > uint16_t vfid; > uint8_t *idreg; > struct ssovf_res *res; > + uint8_t *reg; > > RTE_SET_USED(pci_drv); > > @@ -246,6 +255,15 @@ ssovf_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) > res->domain = val & 0xffff; > > sdev.total_ssovfs++; > + if (!vfid) { vfid == 0 ? > + reg = octeontx_ssovf_bar(OCTEONTX_SSO_GROUP, 0, 0); > + reg += SSO_VHGRP_PF_MBOX(1); > + if (octeontx_mbox_set_reg(reg)) { > + mbox_log_err("Invalid Failed to set mbox_reg"); > + return -EINVAL; > + } > + } > + > rte_wmb(); > mbox_log_dbg("Domain=%d group=%d total_ssovfs=%d", res->domain, > res->vfid, sdev.total_ssovfs); With above changes: Acked-by: Jerin Jacob