From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 2137F1BC55 for ; Wed, 4 Apr 2018 09:48:30 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57C324040853; Wed, 4 Apr 2018 07:48:29 +0000 (UTC) Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E97622024CA1; Wed, 4 Apr 2018 07:48:28 +0000 (UTC) Date: Wed, 4 Apr 2018 09:48:27 +0200 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, yliu@fridaylinux.org, mst@redhat.com Message-ID: <20180404074827.d7zqu36kp6d6fpnj@reserved-198-163.str.redhat.com> References: <20180316152120.13199-1-jfreimann@redhat.com> <20180316152120.13199-2-jfreimann@redhat.com> <58c7998d-e6c7-2785-79aa-65d475c9d41b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <58c7998d-e6c7-2785-79aa-65d475c9d41b@redhat.com> User-Agent: NeoMutt/20180223 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 04 Apr 2018 07:48:29 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 04 Apr 2018 07:48:29 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH 01/17] net/virtio: vring init for packed queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 07:48:30 -0000 On Wed, Apr 04, 2018 at 09:33:20AM +0200, Maxime Coquelin wrote: > > >On 03/16/2018 04:21 PM, Jens Freimann wrote: >>Add and initialize descriptor data structures. >> >>Signed-off-by: Jens Freimann >>--- >> drivers/net/virtio/virtio_ethdev.c | 22 ++++++++++++---------- >> drivers/net/virtio/virtio_pci.h | 8 ++++++++ >> drivers/net/virtio/virtio_ring.h | 25 +++++++++++++++++++++++-- >> drivers/net/virtio/virtqueue.h | 10 ++++++++++ >> 4 files changed, 53 insertions(+), 12 deletions(-) >> >>diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >>index 884f74a..ce4f53d 100644 >>--- a/drivers/net/virtio/virtio_ethdev.c >>+++ b/drivers/net/virtio/virtio_ethdev.c >>@@ -299,19 +299,21 @@ struct rte_virtio_xstats_name_off { >> PMD_INIT_FUNC_TRACE(); >>- /* >>- * Reinitialise since virtio port might have been stopped and restarted >>- */ > >Are you sure the comment has to be removed? Fixed in v3. Thanks! regards, Jens