From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4C13E1C09C for ; Wed, 4 Apr 2018 12:40:47 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2018 03:40:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,405,1517904000"; d="scan'208";a="217535748" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga005.fm.intel.com with SMTP; 04 Apr 2018 03:40:44 -0700 Received: by (sSMTP sendmail emulation); Wed, 04 Apr 2018 11:40:43 +0100 Date: Wed, 4 Apr 2018 11:40:42 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: "Lu, Wenzhuo" , Shweta Choudaha , "dev@dpdk.org" , "shweta.choudaha@att.com" Message-ID: <20180404104042.GA17064@bricha3-MOBL.ger.corp.intel.com> References: <20180223115913.19266-1-shweta.choudaha@gmail.com> <20180223115913.19266-2-shweta.choudaha@gmail.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B76070A@shsmsx102.ccr.corp.intel.com> <58259bea-6f5b-3bb9-0a82-f3e2b9dd428f@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58259bea-6f5b-3bb9-0a82-f3e2b9dd428f@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 10:40:47 -0000 On Wed, Apr 04, 2018 at 11:14:35AM +0100, Ferruh Yigit wrote: > On 4/4/2018 3:25 AM, Lu, Wenzhuo wrote: > > Hi Shweta, > > > > > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shweta Choudaha > >> Sent: Friday, February 23, 2018 7:59 PM > >> To: dev@dpdk.org > >> Cc: shweta.choudaha@att.com > >> Subject: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit > >> > >> From: Shweta Choudaha > >> > >> Add ixgbe API to enable SBP bit in FCTRL register to allow receiving packets > >> that may otherwise be considered length errors by ixgbe and dropped > >> > >> Signed-off-by: Shweta Choudaha > >> Reviewed-by: Chas Williams > >> Reviewed-by: Luca Boccassi > >> --- > > > > > >> --- a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map > >> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map > >> @@ -52,3 +52,9 @@ DPDK_17.08 { > >> rte_pmd_ixgbe_bypass_wd_timeout_show; > >> rte_pmd_ixgbe_bypass_wd_timeout_store; > >> } DPDK_17.05; > >> + > >> +EXPERIMENTAL { > >> + global: > >> + > >> + rte_pmd_ixgbe_upd_fctrl_sbp; > >> +} DPDK_17.08; > > The patch is fine except we should use 18.05 here. > > We have a rule to have an API as experimental for one release. > > Not sure about this rule covering the PMD specific APIs but by default it is, we > can discuss to have an exception for PMD APIs or not. > > After one release developer should send patch to remove experimental from API > +1 for following the process. I don't see why pmd-specific APIs should be a general exception. Any exceptions should be on an individual case-by-case basis IMHO