From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E93C11C820 for ; Wed, 4 Apr 2018 20:27:58 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2018 11:27:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,407,1517904000"; d="scan'208";a="39379704" Received: from slenorma-mobl3.ger.corp.intel.com ([10.252.3.198]) by FMSMGA003.fm.intel.com with SMTP; 04 Apr 2018 11:27:55 -0700 Received: by (sSMTP sendmail emulation); Wed, 04 Apr 2018 19:27:54 +0100 Date: Wed, 4 Apr 2018 19:27:54 +0100 From: Bruce Richardson To: Hemant Agrawal Cc: "dev@dpdk.org" Message-ID: <20180404182753.GA41636@bricha3-MOBL.ger.corp.intel.com> References: <20180222173817.31872-1-bruce.richardson@intel.com> <20180404155332.87143-1-bruce.richardson@intel.com> <20180404155717.GA40576@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] build: clean up building kernel modules using meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 18:27:59 -0000 On Wed, Apr 04, 2018 at 04:47:25PM +0000, Hemant Agrawal wrote: > Just checked. Your V2 got build without any warnings for me. > > Regards, > Hemant > Thanks. /Bruce > > -----Original Message----- > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Wednesday, April 04, 2018 9:27 PM > > To: Hemant Agrawal > > Cc: dev@dpdk.org > > Subject: Re: [PATCH v2] build: clean up building kernel modules using meson > > Importance: High > > > > On Wed, Apr 04, 2018 at 04:53:32PM +0100, Bruce Richardson wrote: > > > The meson.build files for building the kernel modules directory could > > > be improved now that it is extracted from the EAL. For example, no > > > global processing is necessary inside the kernel folder, just need to > > > subdir to the appropriate bsd or linux folder to do the actual work. > > > > > > To avoid potential race conditions with the BSD module builds when the > > > kernel build system is creating the dev_if.h and other files, we > > > serialize the kernel module builds (all 2 of them!) by setting up each > > > module to depend on all the previous. > > > > > > Signed-off-by: Bruce Richardson > > > Tested-by: Hemant Agrawal > > > > > > --- > > > v2: serialize the BSD module builds to try and resolve the > > > warnings seen about bus_if.h/dev_if.h/etc. in some cases. > > > Issue reported by Hemant. > > > --- > > > > Hi Hemant, > > > > I haven't been able to reproduce reliably the issue you reported, but the above > > fixes what I *think* to be the issue causing the error print. If you get a chance, > > can you do a quick re-test and see if it re-occurs for you. > > If not, I'll apply this version - otherwise I might just apply V1, since the error > > itself appears harmless, as you say. > > > > /Bruce