DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Stephen Hemminger <sthemmin@microsoft.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] net/netvsc: add hyper-v netvsc network device
Date: Thu, 5 Apr 2018 13:59:46 -0700	[thread overview]
Message-ID: <20180405135946.38d4c60b@xeon-e3> (raw)
In-Reply-To: <8666220.g7qk7zlF1B@xps>

On Thu, 05 Apr 2018 22:52:31 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> Hi Stephen,
> 
> Good to see there is a good progress.
> 
> This patch should add an entry in the release notes.
> But I guess it is not ready for 18.05?
> 
> 
> 05/04/2018 21:13, Stephen Hemminger:
> > +#
> > +# Compile native PMD for Hyper-V/Azure
> > +#
> > +CONFIG_RTE_LIBRTE_NETVSC_PMD=n
> > +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_RX=n
> > +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_TX=n
> > +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_DUMP=n  
> 
> Please switch to the new dynamic logging.

It does use dynamic logging for the normal driver logs. For debug the dump
code is a config option (same as other current drivers).

> 
> 
> [...]
> > +the Data Plane Development Kit (DPDK), we provide a Netwwork Virtual  
> 
> typo: Netwwork
> 
> 
> > +The following prerequisites apply:
> > +
> > +*   Linux kernel uio_hv_generic driver that supports subchannels. This should be present in 4.17 or later.  
> 
> The DPDK policy is to wait for prerequisite be available for merging.

Does linux-next count?

> 
> 
> > --- a/drivers/net/Makefile
> > +++ b/drivers/net/Makefile
> > @@ -46,6 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += thunderx
> >  DIRS-$(CONFIG_RTE_LIBRTE_VDEV_NETVSC_PMD) += vdev_netvsc
> >  DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio
> >  DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += vmxnet3
> > +DIRS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += netvsc  
> 
> Please keep the alphabetical order.

Ok

  reply	other threads:[~2018-04-05 20:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 19:13 [dpdk-dev] [PATCH 0/3] add Hyper-V bus and network driver Stephen Hemminger
2018-04-05 19:13 ` [dpdk-dev] [PATCH 1/3] bus/vmbus: add hyper-v virtual bus support Stephen Hemminger
2018-04-05 19:13 ` [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script Stephen Hemminger
2018-04-05 20:43   ` Thomas Monjalon
2018-04-05 21:03     ` Stephen Hemminger
2018-04-05 21:13       ` Thomas Monjalon
2018-04-05 21:18         ` Stephen Hemminger
2018-04-05 21:20         ` Stephen Hemminger
2018-04-05 22:39         ` Stephen Hemminger
2018-04-05 21:07     ` Bruce Richardson
2018-04-05 21:10       ` Thomas Monjalon
2018-04-05 22:43         ` Stephen Hemminger
2018-04-05 23:57         ` Ananyev, Konstantin
2018-04-06  0:22           ` Stephen Hemminger
2018-04-06  8:38             ` Bruce Richardson
2018-04-05 19:13 ` [dpdk-dev] [PATCH 3/3] net/netvsc: add hyper-v netvsc network device Stephen Hemminger
2018-04-05 20:52   ` Thomas Monjalon
2018-04-05 20:59     ` Stephen Hemminger [this message]
2018-04-05 21:07       ` Thomas Monjalon
2018-04-05 21:19         ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180405135946.38d4c60b@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=sthemmin@microsoft.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).