From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id BF66D1CC1F for ; Thu, 5 Apr 2018 16:33:55 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A05E8160F98; Thu, 5 Apr 2018 14:33:55 +0000 (UTC) Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4193AB3FC; Thu, 5 Apr 2018 14:33:48 +0000 (UTC) Date: Thu, 5 Apr 2018 16:33:47 +0200 From: Jens Freimann To: Tiwei Bie Cc: dev@dpdk.org, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mst@redhat.com Message-ID: <20180405143347.qfkvjwq5bdj76jar@reserved-198-163.str.redhat.com> References: <20180405101031.26468-1-jfreimann@redhat.com> <20180405101031.26468-4-jfreimann@redhat.com> <20180405142721.polm2pf4elze7fmh@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20180405142721.polm2pf4elze7fmh@debian> User-Agent: NeoMutt/20180223 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 05 Apr 2018 14:33:55 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 05 Apr 2018 14:33:55 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3 03/21] net/virtio: add virtio 1.1 defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 14:33:56 -0000 On Thu, Apr 05, 2018 at 10:27:21PM +0800, Tiwei Bie wrote: >On Thu, Apr 05, 2018 at 12:10:13PM +0200, Jens Freimann wrote: >> Signed-off-by: Jens Freimann >> --- >> drivers/net/virtio/virtio_ring.h | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h >> index 1bd7ba98e..54a11d2a9 100644 >> --- a/drivers/net/virtio/virtio_ring.h >> +++ b/drivers/net/virtio/virtio_ring.h >> @@ -16,7 +16,10 @@ >> #define VRING_DESC_F_WRITE 2 >> /* This means the buffer contains a list of buffer descriptors. */ >> #define VRING_DESC_F_INDIRECT 4 >> - > >Why remove this empty line? > >VRING_DESC_F_* and VRING_USED_F_NO_NOTIFY/VRING_AVAIL_F_NO_INTERRUPT >are unrelated. I think we still need this to make the code more >readable. Figured it was unnecessary, but I'll add it back. Thanks! regards, Jens > >> +/* This flag means the descriptor was made available by the driver */ >> +#define VRING_DESC_F_AVAIL (1ULL << 7) >> +/* This flag means the descriptor was used by the device */ >> +#define VRING_DESC_F_USED (1ULL << 15) >> /* The Host uses this in used->flags to advise the Guest: don't kick me >> * when you add a buffer. It's unreliable, so it's simply an >> * optimization. Guest will still kick if it's out of buffers. */ >> -- >> 2.14.3 >>