From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0075.outbound.protection.outlook.com [104.47.36.75]) by dpdk.org (Postfix) with ESMTP id 989641CE6A for ; Fri, 6 Apr 2018 08:56:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Qe8JWJUZaV03MSc7b2AMBEprLYNma3eTNDlz7ZNraRo=; b=NyJhWvr4iEiGfYzGzeXsJgWMyNaCy2DJIYqpPGxrnYjrigEJyDItmABDAvvoErxa9U8X9PPkgdVpCmgnEQQd55ycuaQgckSiEBgyIsatmUCJPDia/+Orf+4rlI38Zcbd2Sf3Z2ZNupSqS3iE9OOEzRxc1mT7ZVMqgabLWL5S5wM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (122.178.210.9) by CY1PR07MB2524.namprd07.prod.outlook.com (2a01:111:e400:c636::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Fri, 6 Apr 2018 06:56:01 +0000 Date: Fri, 6 Apr 2018 12:25:40 +0530 From: Jerin Jacob To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20180406065539.GA16663@jerin> References: <20180405151228.16595-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180405151228.16595-1-stephen@networkplumber.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [122.178.210.9] X-ClientProxiedBy: BM1PR0101CA0019.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::29) To CY1PR07MB2524.namprd07.prod.outlook.com (2a01:111:e400:c636::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fd399446-5364-4e02-954f-08d59b8b7626 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY1PR07MB2524; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 3:4+bsoc5CRQKLEydVg8HqEMa/SoB4nqV+PmdvnJEagbfWr9cyMJ72Sxhb8LTzBRBR2d6pK6m45ganIuibSL6Fw/OnTGevlN2Ktl7UKItbsmgjVllKrIfcdG25rryxxhJI9Cc29cjhKHe3r0U7myVtbjybnvG2GrjWw58Rxkfw8KsxM1PhmJ8dZez8Y3eWUFihIQ4l3XiCQrYGhdKpmBZUQ6htATOgiV0St5kw6ogDItUPi5P2qF/18+LYCQdPuF1c; 25:+DKrsrsj81bx1Qt6WO4cHAia1youGzQJWv4ZaQp5Vj+gD+yWpQw4WtsGxHu0iTgA1AUvRxB0bYCTbqheSFigziOzfu/CsN5J1jzIBYmXXlqLcRs22P5Q2g1Tw96R90Oro/DjbbHb61C8V6pm4PghGT2L/e8mOC1uwDzCi7tMlIO1uMtPaAESswRA5yhX4ZK6TOoW8xfiMZTU36TZ/nnY2mkx0ZVpkwKiN8nqh7JC1BmQcvIZwr5A7LZD9ZY+mcIRbKzrXWvUguqYEQw81fjomk8v10U4+p+zPmGqXjUM5MUPCZiUw1rr0L+DcoJfj2EO3SFfDABZzuWUj576vKipHw==; 31:r6H3NFKgkpGKl90Aea9gTiDUoKccOfQ1oKF75tRuXM4P3NXUc/q/pBBNk/u0qFfYkfmEoXCf2Q37FkQ+kojcr5PCEf34YpDKaaIgWG+Ta9ehThn3sbScjvSV3kul9ul0ICN90ypQR+il2XFFfjLUH4SewkyLPZyX0HNHQPIuMurMN+uRTG2zLTcEr6fXFbY4uZa9MprBm58ql4pSGLUQlPGKxsPgHnBZh/AyAaLHN8g= X-MS-TrafficTypeDiagnostic: CY1PR07MB2524: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 20:h0yXXABfWNLoWjdXRooO+pqzsk+nA9K56j8qU3Cw1k4wRF+gv/Rm2ebya8T6L/15xdgmnqeYtKvdUvE27e99zNXt3gz7NgxpAQma737odb2Frs5aCzfiDf2O0Jx1th0AjXq5tPVRSAhmb2QrLfVvE/8NPQvI+WYsMWuSPjRlvG0hE7OBp+QpIpGcdxiTPGSYw4SfVAgHmdJd4PcJ6/pc7IZd7t4/NaLeksIs8+nrWyQSMuvejym/AfhzzNqFZxWhHFfxQMCXDrJdowQpBQc94T5qXVIzzvP4rQ/Ghnwz5za4mweAEBpz7GV9q9KM6izix9U3ypoieOfRz4TWY/2ePruuKYJbqaq6uMTpqlGnhMw92FZMf4gs+APavy1oOs6q1Gyy2vvTwaEX9+LDf611H8af41OssoHHwys03NVQV/v8r355GM4UiCJW3BdFRJkNGhXa9BBIS9uh6PbXfnNuI7aTBJKiNWSi+ySY8iAlpTAnrb+nhiCpHD0HPYVpIdIIVK291v3wzpUJ5BixJrT1vHuoQ2eWVQu7wINAd6bSQkIQ9scU3WKTODXtoUeT3OVHzO0vHXeySzOylqHLeM3SDmym/+/PCCAfcYI2KOB7ix0=; 4:j3AbjxcqX63PFDUSF9q2D5ZI/7Ic/7+RQJ8b9WwH7gHanKYyPOwXlUtFuxcRuw0TR88r601SYFkSSSWrFmD3SbaLE133paybMw53YJkMXLiVTUEE9HJ8MZuqkEVk7+hbpEzyccLtPQh0B7eaJdWDKg9sS6hdcNa5DFt3/gMW8cPb62RSB433mq7VhKEjKh5RoeivJb4zuaOC/4+EcWVza68nPevMmTgWj51RxURukQfuuJzcXCHjf9/JUphsT7vr+HD5mtXEG5mt8TO3txFJWA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(3231221)(944501327)(52105095)(10201501046)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:CY1PR07MB2524; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2524; X-Forefront-PRVS: 0634F37BFF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(346002)(376002)(39860400002)(39380400002)(13464003)(199004)(189003)(25786009)(478600001)(4326008)(105586002)(6916009)(81156014)(8676002)(81166006)(6496006)(33656002)(23726003)(6116002)(3846002)(1076002)(229853002)(50466002)(6666003)(72206003)(8936002)(6246003)(5660300001)(97736004)(26005)(7736002)(305945005)(53936002)(33896004)(9686003)(55016002)(66066001)(33716001)(186003)(47776003)(16526019)(42882007)(956004)(11346002)(52116002)(76176011)(476003)(58126008)(106356001)(446003)(16586007)(316002)(486006)(68736007)(386003)(575784001)(2906002)(59450400001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2524; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2524; 23:P2gahWbGTirHXOpY3Pf+h+SqHcVdOA1BCno/OlbVY?= =?us-ascii?Q?n+GVXkM/U7eO1HxLW7u/WR2Z7dX1YA27YIhCZUgxGNdaAPWcN6ClabAC9YVM?= =?us-ascii?Q?Z1PtGmCXN71MkPVVdWkIIqUaK5gTRAr/RskhGb2BTqzAjLNjl4uW6QMC4JHI?= =?us-ascii?Q?0aEX4S8tcf4EMZcYy59Z3CMO38aReJ9HWrISjHxtjwXMP509HtqQC6c3k+SX?= =?us-ascii?Q?9M1BU7ntjo4oQ4wi1JpW3dnF3xEPXceJ+86ocAiDsl4PeYVlA3PupdjdUeyr?= =?us-ascii?Q?fn7mJTtFYxxqzE7BaMbNq6QwNPsdxeLs9OvD87RJjyygwhELwK1AW8ehhsa2?= =?us-ascii?Q?hwMdRZjjvWm0kHTFnwERNiUJkZn4uuupa1ou4oyFPtV9QC7ppnF2Xhb7Ruot?= =?us-ascii?Q?u5/fKBRTcNeY1cFxqy9T5JZGDu0q5Nl/t3/4LBk0ZKSjhhe6vuTu8s2cJOUi?= =?us-ascii?Q?/f3C4l0IRHdA/644NxCi87aaJcUnky8BbbAoFY+bp8lILzioaOuQUgicnRYR?= =?us-ascii?Q?zn1o1zfERI0QpYJDwXlmjf482HmnH1UpH4zGSd5cE+/8KiOEJ+5ZEOsT4mqq?= =?us-ascii?Q?HHwKsASiUn5r4ucp/pW1vlv6j2gQRumFIHanNsMuuDtlrd+iZmSX8WCtVs2w?= =?us-ascii?Q?Ay/Cp4dLpoErr9fErHQeYI6FjLIGP6IqWnCXV25uQeNJ1uxnHUWmx9uPuV6x?= =?us-ascii?Q?zpzWQjpppYpF8R6wYmZhAJeFdJn/QpRZjmxRnorcRytmDnR+ANccnuRv4S3A?= =?us-ascii?Q?zXi2IXleDo7MkL7kYfq/5m9uzjcn9JzoMYd9u0u0wgmuBdB0tzz+8G1o2V0l?= =?us-ascii?Q?LFdKXflk5qT6nMsODcm0gt+efj7kr+rx+kHc+zoQiT2lsn6eQg7NrKcusENt?= =?us-ascii?Q?SGUAWfhLEXK/6/cFnvjgM7PODVUeolhy7sY2LavDtMc/nBzCOw7ZZSsdKCml?= =?us-ascii?Q?m+BYMYTojKniMhTEqyXqpjCpH3pyoCkfkvSdVc2Tp2MAGjxckUi0sB3gblLR?= =?us-ascii?Q?V2y6DjeNTyLKde00M8mpbb/6EjfrqPFhaCNIfZEqA+lLYxdRffW92ZAYd0Ma?= =?us-ascii?Q?D/kmClOIDRm+iMbfepSXoXelWg222Tl+zullY8MBnlML3qD+U705KBFtuOZi?= =?us-ascii?Q?4p1fezcdx9Cx/zgsCZa0DfIUf7IzcEWo3SWIqCkQiZbLpEGSroB3qAIW5umj?= =?us-ascii?Q?4+Co/fKIBLTKia32PizszTcOgRuDQVtQTwk3c7FxBKNLjmxok3qdjMnsKE9j?= =?us-ascii?Q?DPtiNZoIq3vEFWfuKtVth264mvqcixwoYKY435VQlwrDHCMrsHgK8opIvznp?= =?us-ascii?Q?glI+Hjj4/Fg7wdnUWqAEmSfHCUjrkPmVHU/f6bEA5uN26+s+m9RUwzDZ3Txl?= =?us-ascii?Q?mrDvg=3D=3D?= X-Microsoft-Antispam-Message-Info: 1Z8SSZFRB4gKCrcTSkA4wEsM14dzKuMvhT1Rhx5VTS2DloukveLfEyZTMfa2XGF6SMB6kFW2Yxjqs2uumC/H5rt0P8O5ZSRXuOyNmIxj24CFXpLYtEz2FnKK/SOqrE0KfFaHc+4uA0Pqs4skfdn4D3n6MOT7ZXPZyqLSF2CGX1/cPVwtyJevQzDi6v+nS5I7 X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 6:0IuooxduBPiQ3Qd95rb5CxD5mXoHtoR0W2ZCZmrGeg0gWXA5IqD5fZc9IlM+zRg4XSDEMeEQKPP1Ap8ghcz2aron9SowWMwtuoUJmwMnm7xPXNHX3DcjPA+Z7UQZPxt2sfpTyPvYSyYN6tAdrheD+WJCi/NFnGFf7NZklxHz4OlNesTDp3OSiIjkTXzbHRs2D1X+0PfDj1OjcQa8z9jQRkMXHe8KX/2Rg7leEMG4a9pzeZ7PCuSRvFoEaDmEhaHGRdWj4J54SylOXOHfucsBB9jfpqcGrVOnxnYStyjJ9RMzbc7Oc3zg5h/hdUTVS2cKp+bWITvdOEsZx14YqjVEDs84+ionwCUTH0OizZ5Wd4gbVbPQf6IPEp43tU25rlPXsyrJoOYdoDvO2NAh3aPFw6fMCAGaO2S3JxqYNQAquuSA8YQld+QQ+3ExxSJ4PEywt8SGroJc5wrQAcjWjAUn3A==; 5:Vzdx6RjwCtD4qrq06vDDZyM40nnuvEm8sekYsnxoRYpPFeb2DPddTE2q/oR/VQFWPdihyXJaKp6/pNu/6DuBy088c4EwFATfqBu35dtDGaFoy4WIu43M+8625wtfyDXSAd+tsPchRD/+PEgHr4/csAL4BpnAAxw4rl70NQZkIWw=; 24:E0Fa68HwwHHMIVpoaY93iSZx78DdUohThlECKqYL1RGT6BxLiGwZTR0DW9exmdbJ4Ax9JEK0Xr2sFRX76pEPoYOsO+KMOdk4EE2C9I52Mi8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 7:PKOPkJJ0+3NfxbA9LWc4CgLu4ZOHrlGVHs9VQkAwBHarpmC1Oj6empvKXuFFxxZbouLOTywUu3g1oqBD54O8PDG7msIVxJjyeXnhYM4hLTq3VWalKE57tMIVptovNbyZPPphVABq/RwJR6EqDmgPvlGMiHFFpICHtffFxPzmQQ8bWb0SnDPJYmuU63bNlHxQ3/BdJOFtgIhocC9wcJ6oq0CWl+caQMAPDcn6mE4MlAIwNG5znIPQ4xvwUsymzTwp X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2018 06:56:01.5292 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fd399446-5364-4e02-954f-08d59b8b7626 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2524 Subject: Re: [dpdk-dev] [PATCH] net/octeneontx: fix warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 06:56:06 -0000 -----Original Message----- > Date: Thu, 5 Apr 2018 08:12:28 -0700 > From: Stephen Hemminger > To: jerin.jacob@caviumnetworks.com > Cc: dev@dpdk.org, Stephen Hemminger > Subject: [PATCH] net/octeneontx: fix warnings > X-Mailer: git-send-email 2.16.3 > > This is fix for Coverity Devect 268319 about uninitialized speed s/Devect/defect > in an error case. Also drop unnecessary assignment. Coverity issue: 268319 Fixes: 4fac7c0a147e ("net/octeontx: add link update") CC: stable@dpdk.org with above changes in the commit log: Acked-by: Jerin Jacob > > Signed-off-by: Stephen Hemminger > --- > drivers/net/octeontx/octeontx_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c > index 90dd249a6b84..ec3438cb1941 100644 > --- a/drivers/net/octeontx/octeontx_ethdev.c > +++ b/drivers/net/octeontx/octeontx_ethdev.c > @@ -518,7 +518,6 @@ octeontx_dev_link_update(struct rte_eth_dev *dev, > struct rte_eth_link link; > int res; > > - res = 0; > PMD_INIT_FUNC_TRACE(); > > res = octeontx_port_link_status(nic); > @@ -552,6 +551,7 @@ octeontx_dev_link_update(struct rte_eth_dev *dev, > case OCTEONTX_LINK_SPEED_RESERVE1: > case OCTEONTX_LINK_SPEED_RESERVE2: > default: > + link.link_speed = ETH_SPEED_NUM_NONE; > octeontx_log_err("incorrect link speed %d", nic->speed); > break; > } > -- > 2.16.3 >