From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id AD5AA1C693 for ; Fri, 6 Apr 2018 11:21:37 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4F148406E8A4; Fri, 6 Apr 2018 09:21:37 +0000 (UTC) Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05B16215CDAF; Fri, 6 Apr 2018 09:21:36 +0000 (UTC) Date: Fri, 6 Apr 2018 11:21:35 +0200 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, yliu@fridaylinux.org, mst@redhat.com Message-ID: <20180406092135.5wkqu4q244jgd4gf@dhcp-192-241.str.redhat.com> References: <20180405101031.26468-1-jfreimann@redhat.com> <20180405101031.26468-14-jfreimann@redhat.com> <955ef4fc-eacf-12ed-797b-9d274bbeb054@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <955ef4fc-eacf-12ed-797b-9d274bbeb054@redhat.com> User-Agent: NeoMutt/20180223 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 06 Apr 2018 09:21:37 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 06 Apr 2018 09:21:37 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3 13/21] vhost: add helpers for packed virtqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 09:21:37 -0000 On Fri, Apr 06, 2018 at 11:20:10AM +0200, Maxime Coquelin wrote: > > >On 04/05/2018 12:10 PM, Jens Freimann wrote: >>Add some helper functions to set/check descriptor flags >>and toggle the used wrap counter. >> >>Signed-off-by: Jens Freimann >>--- >> lib/librte_vhost/virtio-1.1.h | 44 +++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> >>diff --git a/lib/librte_vhost/virtio-1.1.h b/lib/librte_vhost/virtio-1.1.h >>index 7b48caed7..e77d7aa6c 100644 >>--- a/lib/librte_vhost/virtio-1.1.h >>+++ b/lib/librte_vhost/virtio-1.1.h >Shouldn't the file be named virtio-packed.h? yes, will rename it. >>@@ -15,4 +15,48 @@ struct vring_desc_packed { >> uint16_t flags; >> }; >>+static inline void >>+toggle_wrap_counter(struct vhost_virtqueue *vq) >>+{ >>+ vq->used_wrap_counter ^= 1; >>+} >>+ >>+static inline int >>+desc_is_avail(struct vhost_virtqueue *vq, struct vring_desc_packed *desc) >>+{ >>+ if (vq->used_wrap_counter == 1) { >>+ if ((desc->flags & VRING_DESC_F_AVAIL) && >>+ !(desc->flags & VRING_DESC_F_USED)) >>+ return 1; >>+ } >>+ if (vq->used_wrap_counter == 0) { >>+ if (!(desc->flags & VRING_DESC_F_AVAIL) && >>+ (desc->flags & VRING_DESC_F_USED)) >>+ return 1; >>+ } >>+ return 0; >>+} >>+ >>+static inline void >>+_set_desc_used(struct vring_desc_packed *desc, int wrap_counter) >>+{ >>+ uint16_t flags = desc->flags; >>+ >>+ if (wrap_counter == 1) { >>+ flags |= VRING_DESC_F_USED; >>+ flags |= VRING_DESC_F_AVAIL; >>+ } else { >>+ flags &= ~VRING_DESC_F_USED; >>+ flags &= ~VRING_DESC_F_AVAIL; >>+ } >>+ >>+ desc->flags = flags; >>+} >>+ >>+static inline void >>+set_desc_used(struct vhost_virtqueue *vq, struct vring_desc_packed *desc) >>+{ >>+ _set_desc_used(desc, vq->used_wrap_counter); >>+} >>+ > >Maybe prefix all with vring_ >> #endif /* __VIRTIO_PACKED_H */ ok Thanks! regards, Jens >>